* [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM
@ 2015-08-26 14:48 Aníbal Limón
2015-08-26 21:53 ` Benjamin Esquivel
2015-08-27 16:27 ` Aníbal Limón
0 siblings, 2 replies; 4+ messages in thread
From: Aníbal Limón @ 2015-08-26 14:48 UTC (permalink / raw)
To: openembedded-core
If $TCPSERIAL_PORTNUM is empty string causes an error because
expands the expresion to,
$TCPSERIAL_PORTNUM == "" -> == ""
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
scripts/runqemu-internal | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index b317358..1b1bc9e 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -620,7 +620,7 @@ if [ "x$QEMUOPTIONS" = "x" ]; then
return 1
fi
-if [ $TCPSERIAL_PORTNUM != "" ]; then
+if [ "$TCPSERIAL_PORTNUM" != "" ]; then
if [ "$MACHINE" = "qemuarm64" ]; then
QEMUOPTIONS="$QEMUOPTIONS -device virtio-serial-device -chardev socket,id=virtcon,port=$TCPSERIAL_PORTNUM,host=127.0.0.1 -device virtconsole,chardev=virtcon"
else
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM
2015-08-26 14:48 [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM Aníbal Limón
@ 2015-08-26 21:53 ` Benjamin Esquivel
2015-08-27 16:27 ` Aníbal Limón
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Esquivel @ 2015-08-26 21:53 UTC (permalink / raw)
To: Aníbal Limón, openembedded-core
On Wed, 2015-08-26 at 09:48 -0500, Aníbal Limón wrote:
> If $TCPSERIAL_PORTNUM is empty string causes an error because
> expands the expresion to,
>
> $TCPSERIAL_PORTNUM == "" -> == ""
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> scripts/runqemu-internal | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index b317358..1b1bc9e 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -620,7 +620,7 @@ if [ "x$QEMUOPTIONS" = "x" ]; then
> return 1
> fi
>
> -if [ $TCPSERIAL_PORTNUM != "" ]; then
> +if [ "$TCPSERIAL_PORTNUM" != "" ]; then
I believe this would work but if you want to make it bulletproof you'd:
if [ X"$TCPSERIAL_PORTNUM" != X"" ]; then
> if [ "$MACHINE" = "qemuarm64" ]; then
> QEMUOPTIONS="$QEMUOPTIONS -device virtio-serial-device
> -chardev socket,id=virtcon,port=$TCPSERIAL_PORTNUM,host=127.0.0.1
> -device virtconsole,chardev=virtcon"
> else
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM
2015-08-26 14:48 [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM Aníbal Limón
2015-08-26 21:53 ` Benjamin Esquivel
@ 2015-08-27 16:27 ` Aníbal Limón
2015-08-27 17:08 ` Burton, Ross
1 sibling, 1 reply; 4+ messages in thread
From: Aníbal Limón @ 2015-08-27 16:27 UTC (permalink / raw)
To: openembedded-core
ping
On 26/08/15 09:48, Aníbal Limón wrote:
> If $TCPSERIAL_PORTNUM is empty string causes an error because
> expands the expresion to,
>
> $TCPSERIAL_PORTNUM == "" -> == ""
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> scripts/runqemu-internal | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index b317358..1b1bc9e 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -620,7 +620,7 @@ if [ "x$QEMUOPTIONS" = "x" ]; then
> return 1
> fi
>
> -if [ $TCPSERIAL_PORTNUM != "" ]; then
> +if [ "$TCPSERIAL_PORTNUM" != "" ]; then
> if [ "$MACHINE" = "qemuarm64" ]; then
> QEMUOPTIONS="$QEMUOPTIONS -device virtio-serial-device -chardev socket,id=virtcon,port=$TCPSERIAL_PORTNUM,host=127.0.0.1 -device virtconsole,chardev=virtcon"
> else
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-27 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26 14:48 [PATCH] runqemu-internal: Fixes unary operator expected in new TCPSERIAL_PORTNUM Aníbal Limón
2015-08-26 21:53 ` Benjamin Esquivel
2015-08-27 16:27 ` Aníbal Limón
2015-08-27 17:08 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox