From: Kang Kai <Kai.Kang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] useradd_base.bbclass: fix simultaneous with flock
Date: Wed, 17 Feb 2016 13:40:27 +0800 [thread overview]
Message-ID: <56C407CB.4060100@windriver.com> (raw)
In-Reply-To: <CAJTo0LYOpP40zsTFKahoMzU1caXH+=qTUwgAAy1aV--pK_-E_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On 2016年02月16日 20:09, Burton, Ross wrote:
>
> On 16 February 2016 at 07:14, <kai.kang@windriver.com
> <mailto:kai.kang@windriver.com>> wrote:
>
> +FLOCK_FILE=$SYSROOT/etc
>
>
> useradd_base is also used by extrausers.bbclass, so it would be best
> if useradd_base decided where to use as a lock ($rootdir/${sysconfdir}
> sounds sensible) instead of expecting that the caller sets FLOCK_FILE
> and mysteriously failing if it wasn't set.
OK. Sounds good.
>
> Also if we're locking and waiting properly instead of using timeouts
> and loops, can we remove the "does it exist?" check before the
> operation (eg groupadd -f will exit 0 if the group exists) and after
> (with proper locking that shouldn't be happening).
I prefer to keep such check. There is more than one case that causes
operation error such as pass wrong parameters. The messages are helpful
for developers.
Thanks,
Kai
>
> Ross
--
Regards,
Neil | Kai Kang
[-- Attachment #2: Type: text/html, Size: 2656 bytes --]
next prev parent reply other threads:[~2016-02-17 5:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 7:14 [PATCH 0/1] V2: Replace retry logic in useradd with flock kai.kang
2016-02-16 7:14 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-16 12:09 ` Burton, Ross
2016-02-17 5:40 ` Kang Kai [this message]
2016-02-17 23:49 ` Burton, Ross
2016-02-22 8:41 ` Kang Kai
-- strict thread matches above, loose matches on Subject: below --
2016-02-23 2:45 [PATCH 0/1] V3: Replace retry logic in useradd " kai.kang
2016-02-23 2:45 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-23 3:05 ` Khem Raj
2016-02-23 3:35 ` Kang Kai
2016-02-23 7:25 ` Richard Purdie
2016-02-23 7:31 ` Kang Kai
2016-02-23 16:29 ` Burton, Ross
2016-02-23 17:01 ` Burton, Ross
2016-02-23 17:10 ` Burton, Ross
2016-02-24 8:51 ` Kang Kai
2016-02-15 1:59 [PATCH 0/1] Replace retry logic in useradd " kai.kang
2016-02-15 1:59 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-15 12:31 ` Burton, Ross
2016-02-16 2:14 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C407CB.4060100@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox