From: Kang Kai <Kai.Kang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] useradd_base.bbclass: fix simultaneous with flock
Date: Wed, 24 Feb 2016 16:51:12 +0800 [thread overview]
Message-ID: <56CD6F00.3060402@windriver.com> (raw)
In-Reply-To: <CAJTo0Lbs50h0=46rp2ZV6cv=OgcyBCpfPJh6nvhEFB8HpMQzsA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On 2016年02月24日 01:10, Burton, Ross wrote:
>
> On 23 February 2016 at 17:01, Burton, Ross <ross.burton@intel.com
> <mailto:ross.burton@intel.com>> wrote:
>
> The *amazing* BB_VERBOSE_LOGS option (set to 1 in local.conf to
> get all shell scripts to do set -x) tells me this is due to
> missing quotes around the opts assignment:
>
>
> Why do some of the opts assignments just do opts=$2, and others do a sed?
In the previous version, there are:
local opts="$2"
...
opts=`echo $opts | sed s/\'/\"/g`
And I want to refactor them but lost the double quotes.
Only do sed operations for useradd and groupadd that they may be passed in "opts" with space but others didn't.
I'll restore to previous version.
Sorry for inconvenience that I built pass on Ubuntu 14.04 so didn't find
this error.
--Kai
>
> Ross
--
Regards,
Neil | Kai Kang
[-- Attachment #2: Type: text/html, Size: 2261 bytes --]
next prev parent reply other threads:[~2016-02-24 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 2:45 [PATCH 0/1] V3: Replace retry logic in useradd with flock kai.kang
2016-02-23 2:45 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-23 3:05 ` Khem Raj
2016-02-23 3:35 ` Kang Kai
2016-02-23 7:25 ` Richard Purdie
2016-02-23 7:31 ` Kang Kai
2016-02-23 16:29 ` Burton, Ross
2016-02-23 17:01 ` Burton, Ross
2016-02-23 17:10 ` Burton, Ross
2016-02-24 8:51 ` Kang Kai [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-16 7:14 [PATCH 0/1] V2: Replace retry logic in useradd " kai.kang
2016-02-16 7:14 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-16 12:09 ` Burton, Ross
2016-02-17 5:40 ` Kang Kai
2016-02-17 23:49 ` Burton, Ross
2016-02-22 8:41 ` Kang Kai
2016-02-15 1:59 [PATCH 0/1] Replace retry logic in useradd " kai.kang
2016-02-15 1:59 ` [PATCH 1/1] useradd_base.bbclass: fix simultaneous " kai.kang
2016-02-15 12:31 ` Burton, Ross
2016-02-16 2:14 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD6F00.3060402@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox