[PATCH v2] kernel-uimage: change target image to vmlinux

[PATCH v2] kernel-uimage: change target image to vmlinux

[Ruslan Bilovol]

Commit e69525: "kernel: Build uImage only when really
needed" hardcoded target kernel image to zImage for
case if uImage is generated by OpenEmbedded buildsystem.

However not all kernel architectures support zImage
target, for example AArch64 doesn't, so building of
kernel is failing on this step.

So instead of building zImage target that may not
exist for many architectures, build vmlinux target
that exists for all architectures.

Since kernel-uboot.bbclass uses vmlinux anyway for
creating image, there is no side effect on this change.

Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>
---
 meta/classes/kernel-uimage.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-uimage.bbclass b/meta/classes/kernel-uimage.bbclass
index f73965b..de7ca38 100644
--- a/meta/classes/kernel-uimage.bbclass
+++ b/meta/classes/kernel-uimage.bbclass
@@ -13,7 +13,7 @@ python __anonymous () {
 	# KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into
 	# the uImage .
 	if d.getVar("KEEPUIMAGE", True) != 'yes':
-            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "zImage")
+            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "vmlinux")
 }
 
 do_uboot_mkimage() {
-- 
1.9.1

Re: [PATCH v2] kernel-uimage: change target image to vmlinux

[Marek Vasut]

On 04/13/2016 08:17 PM, Ruslan Bilovol wrote:
> Commit e69525: "kernel: Build uImage only when really
> needed" hardcoded target kernel image to zImage for
> case if uImage is generated by OpenEmbedded buildsystem.
> 
> However not all kernel architectures support zImage
> target, for example AArch64 doesn't, so building of
> kernel is failing on this step.
> 
> So instead of building zImage target that may not
> exist for many architectures, build vmlinux target
> that exists for all architectures.
> 
> Since kernel-uboot.bbclass uses vmlinux anyway for
> creating image, there is no side effect on this change.
> 
> Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>

To me, this looks sensible:

Reviewed-by: Marek Vasut <marex@denx.de>

If someone depends on this uImage bbclass generating also zImage,
there will be a failure and that should be fixed therein.

> ---
>  meta/classes/kernel-uimage.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel-uimage.bbclass b/meta/classes/kernel-uimage.bbclass
> index f73965b..de7ca38 100644
> --- a/meta/classes/kernel-uimage.bbclass
> +++ b/meta/classes/kernel-uimage.bbclass
> @@ -13,7 +13,7 @@ python __anonymous () {
>  	# KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into
>  	# the uImage .
>  	if d.getVar("KEEPUIMAGE", True) != 'yes':
> -            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "zImage")
> +            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "vmlinux")
>  }
>  
>  do_uboot_mkimage() {
> 


-- 
Best regards,
Marek Vasut