* [PATCH] packagroup-base: use virtual runtime instead of keymap
@ 2012-12-07 14:44 Ciprian Ciubotariu
2012-12-11 9:18 ` Martin Jansa
0 siblings, 1 reply; 9+ messages in thread
From: Ciprian Ciubotariu @ 2012-12-07 14:44 UTC (permalink / raw)
To: openembedded-core
---
.../packagegroups/packagegroup-base.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 347a7e1..3e75190 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
SUMMARY_packagegroup-base-keyboard = "Keyboard support"
RDEPENDS_packagegroup-base-keyboard = "\
- keymaps"
+ ${VIRTUAL-RUNTIME_keymaps}"
SUMMARY_packagegroup-base-pci = "PCI bus support"
RDEPENDS_packagegroup-base-pci = "\
--
1.7.8.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] packagroup-base: use virtual runtime instead of keymap
2012-12-07 14:44 [PATCH] packagroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
@ 2012-12-11 9:18 ` Martin Jansa
2012-12-11 9:28 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2012-12-11 9:18 UTC (permalink / raw)
To: Ciprian Ciubotariu; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> ---
> .../packagegroups/packagegroup-base.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 347a7e1..3e75190 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
>
> SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> RDEPENDS_packagegroup-base-keyboard = "\
> - keymaps"
> + ${VIRTUAL-RUNTIME_keymaps}"
you need to specify default value with weak assignment like
packagegroup-core-boot.bb does
Cheers,
>
> SUMMARY_packagegroup-base-pci = "PCI bus support"
> RDEPENDS_packagegroup-base-pci = "\
> --
> 1.7.8.6
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] packagroup-base: use virtual runtime instead of keymap
2012-12-11 9:18 ` Martin Jansa
@ 2012-12-11 9:28 ` Paul Eggleton
2012-12-11 9:30 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2012-12-11 9:28 UTC (permalink / raw)
To: Ciprian Ciubotariu; +Cc: openembedded-core
On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > ---
> >
> > .../packagegroups/packagegroup-base.bb | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > 347a7e1..3e75190 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > "${MACHINE_EXTRA_RRECOMMENDS}">
> > SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> > RDEPENDS_packagegroup-base-keyboard = "\
> >
> > - keymaps"
> > + ${VIRTUAL-RUNTIME_keymaps}"
>
> you need to specify default value with weak assignment like
> packagegroup-core-boot.bb does
Also, could you please include a commit message explaining why this is needed?
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] packagroup-base: use virtual runtime instead of keymap
2012-12-11 9:28 ` Paul Eggleton
@ 2012-12-11 9:30 ` Paul Eggleton
2012-12-15 0:50 ` [PATCH v2] packagegroup-base: " Ciprian Ciubotariu
0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2012-12-11 9:30 UTC (permalink / raw)
To: Ciprian Ciubotariu; +Cc: openembedded-core
On Tuesday 11 December 2012 09:28:47 Paul Eggleton wrote:
> On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> > On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > > ---
> > >
> > > .../packagegroups/packagegroup-base.bb | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > > 347a7e1..3e75190 100644
> > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > > "${MACHINE_EXTRA_RRECOMMENDS}">
> > >
> > > SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> > > RDEPENDS_packagegroup-base-keyboard = "\
> > >
> > > - keymaps"
> > > + ${VIRTUAL-RUNTIME_keymaps}"
> >
> > you need to specify default value with weak assignment like
> > packagegroup-core-boot.bb does
>
> Also, could you please include a commit message explaining why this is
> needed?
Ah, well; not so much why this is needed but explaining that this makes it
consistent with packagegroup-core-boot.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] packagegroup-base: use virtual runtime instead of keymap
2012-12-11 9:30 ` Paul Eggleton
@ 2012-12-15 0:50 ` Ciprian Ciubotariu
2012-12-15 6:59 ` Martin Jansa
0 siblings, 1 reply; 9+ messages in thread
From: Ciprian Ciubotariu @ 2012-12-15 0:50 UTC (permalink / raw)
To: openembedded-core
This makes it consistent with packagegroup-core-base, and also avoids
unneeded dependencies towards sysvinit packages.
---
.../packagegroups/packagegroup-base.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 347a7e1..3e75190 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
SUMMARY_packagegroup-base-keyboard = "Keyboard support"
RDEPENDS_packagegroup-base-keyboard = "\
- keymaps"
+ ${VIRTUAL-RUNTIME_keymaps}"
SUMMARY_packagegroup-base-pci = "PCI bus support"
RDEPENDS_packagegroup-base-pci = "\
--
1.7.8.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] packagegroup-base: use virtual runtime instead of keymap
2012-12-15 0:50 ` [PATCH v2] packagegroup-base: " Ciprian Ciubotariu
@ 2012-12-15 6:59 ` Martin Jansa
2012-12-18 7:04 ` packagegroup-base notes Ciprian Ciubotariu
0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2012-12-15 6:59 UTC (permalink / raw)
To: Ciprian Ciubotariu; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
On Sat, Dec 15, 2012 at 02:50:14AM +0200, Ciprian Ciubotariu wrote:
> This makes it consistent with packagegroup-core-base, and also avoids
> unneeded dependencies towards sysvinit packages.
> ---
> .../packagegroups/packagegroup-base.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 347a7e1..3e75190 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
>
> SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> RDEPENDS_packagegroup-base-keyboard = "\
> - keymaps"
> + ${VIRTUAL-RUNTIME_keymaps}"
>
> SUMMARY_packagegroup-base-pci = "PCI bus support"
> RDEPENDS_packagegroup-base-pci = "\
Same comment as last time:
http://patchwork.openembedded.org/patch/40649/
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* packagegroup-base notes
2012-12-15 6:59 ` Martin Jansa
@ 2012-12-18 7:04 ` Ciprian Ciubotariu
2012-12-18 7:04 ` [PATCH v3] packagegroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
2012-12-18 9:03 ` packagegroup-base notes Martin Jansa
0 siblings, 2 replies; 9+ messages in thread
From: Ciprian Ciubotariu @ 2012-12-18 7:04 UTC (permalink / raw)
To: openembedded-core
Please note that packagegroup-base also contains references to VIRTUAL-RUNTIME_apm and VIRTUAL-RUNTIME_alsa-state, which are not defined within the same recipe (I did a search to find a good place to add my own weak definition for keymaps).
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] packagegroup-base: use virtual runtime instead of keymap
2012-12-18 7:04 ` packagegroup-base notes Ciprian Ciubotariu
@ 2012-12-18 7:04 ` Ciprian Ciubotariu
2012-12-18 9:03 ` packagegroup-base notes Martin Jansa
1 sibling, 0 replies; 9+ messages in thread
From: Ciprian Ciubotariu @ 2012-12-18 7:04 UTC (permalink / raw)
To: openembedded-core
This makes it consistent with packagegroup-core-base, and also avoids
unneeded dependencies towards sysvinit packages.
---
.../packagegroups/packagegroup-base.bb | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 347a7e1..4ab34bb 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -43,6 +43,9 @@ PACKAGES = ' \
#
PACKAGE_ARCH = "${MACHINE_ARCH}"
+# Override by distro if needed
+VIRTUAL-RUNTIME_keymaps ?= "keymaps"
+
#
# packagegroup-base contain stuff needed for base system (machine related)
#
@@ -141,7 +144,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
SUMMARY_packagegroup-base-keyboard = "Keyboard support"
RDEPENDS_packagegroup-base-keyboard = "\
- keymaps"
+ ${VIRTUAL-RUNTIME_keymaps}"
SUMMARY_packagegroup-base-pci = "PCI bus support"
RDEPENDS_packagegroup-base-pci = "\
--
1.7.8.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: packagegroup-base notes
2012-12-18 7:04 ` packagegroup-base notes Ciprian Ciubotariu
2012-12-18 7:04 ` [PATCH v3] packagegroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
@ 2012-12-18 9:03 ` Martin Jansa
1 sibling, 0 replies; 9+ messages in thread
From: Martin Jansa @ 2012-12-18 9:03 UTC (permalink / raw)
To: Ciprian Ciubotariu; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Tue, Dec 18, 2012 at 09:04:14AM +0200, Ciprian Ciubotariu wrote:
> Please note that packagegroup-base also contains references to VIRTUAL-RUNTIME_apm and VIRTUAL-RUNTIME_alsa-state, which are not defined within the same recipe (I did a search to find a good place to add my own weak definition for keymaps).
Those 2 have default values set in
meta/conf/distro/include/default-providers.inc
VIRTUAL-RUNTIME_keymaps has not.
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-12-18 9:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-07 14:44 [PATCH] packagroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
2012-12-11 9:18 ` Martin Jansa
2012-12-11 9:28 ` Paul Eggleton
2012-12-11 9:30 ` Paul Eggleton
2012-12-15 0:50 ` [PATCH v2] packagegroup-base: " Ciprian Ciubotariu
2012-12-15 6:59 ` Martin Jansa
2012-12-18 7:04 ` packagegroup-base notes Ciprian Ciubotariu
2012-12-18 7:04 ` [PATCH v3] packagegroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
2012-12-18 9:03 ` packagegroup-base notes Martin Jansa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox