Re: [RFC] opkg: avoid running postinst scripts twice when using systemd

[Stefan Agner <stefan@agner.ch>]

On 2017-12-14 19:04, Alexander Kanavin wrote:
> On 12/14/2017 07:49 PM, Alexander Kanavin wrote:
>> On 12/14/2017 07:40 PM, Stefan Agner wrote:
>>
>>> Oh, I see, well that simplifies it, doesn't it? E.g.
>>>
>>>      # If package managers support postinsts and the package manager is
>>> present on the
>>>      # rootfs, then it will handle postinsts just fine, no need to deploy
>>> scripts again.
>>>      if delayed_postinsts and not runtime_pkgmanage:
>>>          self._save_postinsts()
>>>
>>> And with that it will be as it used to be before the above commit, and
>>> the way it should be.
>>
>> Sorry, but no. You are making an implicit assumption about how rpmrootfs child class behaves here, which is not a good thing to do in a parent class.
> 
> What you *can* do however is move the "and not runtime_pkgmanage"
> check into the child classes for opkg and dpkg. I'm fine with that.
> 

That sounds sensible. Will send a patchset.

--
Stefan