Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Stefan Agner <stefan.agner@toradex.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [RFC] opkg: avoid running postinst scripts twice when using systemd
Date: Thu, 14 Dec 2017 20:04:28 +0200	[thread overview]
Message-ID: <129da6c9-63f8-c660-ec6c-d6b9ba28e480@linux.intel.com> (raw)
In-Reply-To: <d86099aa-2449-6afd-38a9-8bc3270f3e35@linux.intel.com>

On 12/14/2017 07:49 PM, Alexander Kanavin wrote:
> On 12/14/2017 07:40 PM, Stefan Agner wrote:
> 
>> Oh, I see, well that simplifies it, doesn't it? E.g.
>>
>>      # If package managers support postinsts and the package manager is
>> present on the
>>      # rootfs, then it will handle postinsts just fine, no need to deploy
>> scripts again.
>>      if delayed_postinsts and not runtime_pkgmanage:
>>          self._save_postinsts()
>>
>> And with that it will be as it used to be before the above commit, and
>> the way it should be.
> 
> Sorry, but no. You are making an implicit assumption about how rpmrootfs 
> child class behaves here, which is not a good thing to do in a parent 
> class.

What you *can* do however is move the "and not runtime_pkgmanage" check 
into the child classes for opkg and dpkg. I'm fine with that.

Alex


  reply	other threads:[~2017-12-14 18:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 18:06 [RFC] opkg: avoid running postinst scripts twice when using systemd Stefan Agner
2017-12-13 18:29 ` Stefan Agner
2017-12-14 13:10   ` Alexander Kanavin
2017-12-14 13:11     ` Stefan Agner
2017-12-14 13:52       ` Alexander Kanavin
2017-12-14 13:59         ` Stefan Agner
2017-12-14 14:24           ` Alexander Kanavin
2017-12-14 14:41             ` Stefan Agner
2017-12-14 14:55               ` Alexander Kanavin
2017-12-14 14:57                 ` Stefan Agner
2017-12-14 15:14                   ` Alexander Kanavin
2017-12-14 16:46                     ` Stefan Agner
2017-12-14 16:59                       ` Alexander Kanavin
2017-12-14 17:16                         ` Stefan Agner
2017-12-14 17:28                           ` Alexander Kanavin
2017-12-14 17:40                             ` Stefan Agner
2017-12-14 17:49                               ` Alexander Kanavin
2017-12-14 18:04                                 ` Alexander Kanavin [this message]
2017-12-16 12:02                                   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=129da6c9-63f8-c660-ec6c-d6b9ba28e480@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=stefan.agner@toradex.com \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox