Re: [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/

Re: [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/

[Scott Murray]

On Mon, 20 Jan 2025, Enrico Scholz wrote:

> Scott Murray <scott.murray@konsulko.com> writes:
>
> >> bitbake looks first in 'classes-recipes/' and then in 'classes/'.
> >> Hence, content had no effect and was just ignored.
> >>
> >> Rename folder so that it overrides the OE-core classes.
> >>
> >> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> > [snip]
> >
> > I'm pretty sure this is incorrect.
>
> Logic is in [1]
>
> --> first iterate (using $BBPATH) in 'recipes-%', then in 'recipes'

Hmm, the code I looked at was in lib/bblayers/query.py, and its logic is
different AFAICT.  Can you confirm that "bitbake-layers show-overlayed"
shows it as being overlayed for you as it does for me?  That it does
would seem to indicate a bblayers bug, and there is perhaps some missing
documentation of this behavior (change) (e.g. I don't see any mention of
classes-global vs classes-recipe vs classes and how their prioritization
works wrt layers in the docs).  I'm CC'ing oe-core just in case I'm
really missing something here...

> For now, it does not matter because classes in OE core and meta-lts-mixins
> are very similar.  But 1.81 seems to introduce other data layouts so correct
> classes are probably important.
>
> I stumpled across it while fixing cargo-native build errors [2]

Okay, I'll queue it up once I have some cycles to do some test builds
here.

> Enrico
>
> Footnotes:
> [1]  https://github.com/openembedded/bitbake/blob/0329a7e3ac694737f2d2c1861f65492551360663/lib/bb/parse/parse_py/BBHandler.py#L53-L68
>
> [2]  https://lists.openembedded.org/g/openembedded-core/message/210043
>
>

Scott

Re: [yocto-patches] [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/

[Richard Purdie]

On Mon, 2025-01-20 at 16:32 -0500, Scott Murray via lists.yoctoproject.org wrote:
> On Mon, 20 Jan 2025, Enrico Scholz wrote:
> 
> > Scott Murray <scott.murray@konsulko.com> writes:
> > 
> > > > bitbake looks first in 'classes-recipes/' and then in
> > > > 'classes/'.
> > > > Hence, content had no effect and was just ignored.
> > > > 
> > > > Rename folder so that it overrides the OE-core classes.
> > > > 
> > > > Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> > > [snip]
> > > 
> > > I'm pretty sure this is incorrect.
> > 
> > Logic is in [1]
> > 
> > --> first iterate (using $BBPATH) in 'recipes-%', then in 'recipes'
> 
> Hmm, the code I looked at was in lib/bblayers/query.py, and its logic is
> different AFAICT.  Can you confirm that "bitbake-layers show-overlayed"
> shows it as being overlayed for you as it does for me?  That it does
> would seem to indicate a bblayers bug, and there is perhaps some missing
> documentation of this behavior (change) (e.g. I don't see any mention of
> classes-global vs classes-recipe vs classes and how their prioritization
> works wrt layers in the docs).  I'm CC'ing oe-core just in case I'm
> really missing something here...

I think bblayers needs fixing and we need to sort the docs too...

Copying Antonin as we probably want a bug to track that.

Cheers,

Richard

Re: [yocto-patches] [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/

[Antonin Godard]

Hi all,

On Mon Jan 20, 2025 at 11:54 PM CET, Richard Purdie wrote:
> On Mon, 2025-01-20 at 16:32 -0500, Scott Murray via lists.yoctoproject.org wrote:
>> On Mon, 20 Jan 2025, Enrico Scholz wrote:
>> 
>> > Scott Murray <scott.murray@konsulko.com> writes:
>> > 
>> > > > bitbake looks first in 'classes-recipes/' and then in
>> > > > 'classes/'.
>> > > > Hence, content had no effect and was just ignored.
>> > > > 
>> > > > Rename folder so that it overrides the OE-core classes.
>> > > > 
>> > > > Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
>> > > [snip]
>> > > 
>> > > I'm pretty sure this is incorrect.
>> > 
>> > Logic is in [1]
>> > 
>> > --> first iterate (using $BBPATH) in 'recipes-%', then in 'recipes'
>> 
>> Hmm, the code I looked at was in lib/bblayers/query.py, and its logic is
>> different AFAICT.  Can you confirm that "bitbake-layers show-overlayed"
>> shows it as being overlayed for you as it does for me?  That it does
>> would seem to indicate a bblayers bug, and there is perhaps some missing
>> documentation of this behavior (change) (e.g. I don't see any mention of
>> classes-global vs classes-recipe vs classes and how their prioritization
>> works wrt layers in the docs).  I'm CC'ing oe-core just in case I'm
>> really missing something here...
>
> I think bblayers needs fixing and we need to sort the docs too...
>
> Copying Antonin as we probably want a bug to track that.

I've created a bug to track this:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15724

Scott, I've assigned you to it, as you proposed to add this yesterday on the
tech meeting. Let me know if you need any help for adding documentation (it
should be part of bitbake/doc most likely).

Also let me know if I got it wrong yesterday and if I should re-assign this.

Thank you,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com