Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

[Hongxu Jia]

Ping

//Hongxu
On 7/16/25 15:32, hongxu via lists.openembedded.org wrote:
> When building with GCC 14+ using -Og (DEBUG_BUILD = 1), got
> the following errors:
>
> $ echo 'DEBUG_BUILD = "1"' >> conf/local.conf
> $ echo 'DISTRO_FEATURES:append = " vulkan"' >> conf/local.conf
> $ bitbake vulkan-validation-layers
> ...
> |tmp/work/core2-64-poky-linux/vulkan-validation-layers/1.4.313.0/sources/
> vulkan-validation-layers-1.4.313.0/layers/./external/xxhash.h:4822:1: error:
> inlining failed in call to 'always_inline' 'void XXH3_scrambleAcc_sse2(void*,
> const void*)': function not considered for inlining
> ...
>
> Refer [1], using XXH_NO_INLINE_HINTS when compiling with -Og (DEBUG_BUILD = 1)
>
> [1] https://github.com/Cyan4973/xxHash/issues/943
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   .../vulkan/vulkan-validation-layers_1.4.313.0.bb                | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> index 63a3aa4ae64..c05a1d87007 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> @@ -26,6 +26,8 @@ EXTRA_OECMAKE = "\
>       -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
>       "
>   
> +CXXFLAGS:append = " ${@oe.utils.vartrue('DEBUG_BUILD', '-DXXH_NO_INLINE_HINTS=1', '', d)}"
> +
>   PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr"
>   PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON, -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland"
>   
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#220435): https://lists.openembedded.org/g/openembedded-core/message/220435
> Mute This Topic: https://lists.openembedded.org/mt/114181365/3617049
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [hongxu.jia@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

[Mathieu Dubois-Briand]

On Fri Aug 1, 2025 at 6:56 AM CEST, hongxu via lists.openembedded.org wrote:
> Ping
>
> //Hongxu

Strangely I did not had the original mail. I start to believe my mail
provider is doing some nasty things...

It's in my master-next branch now, thanks.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

[Randy MacLeod]

[-- Attachment #1: Type: text/plain, Size: 2902 bytes --]

On 2025-07-16 3:32 a.m., hongxu via lists.openembedded.org wrote:
> When building with GCC 14+ using -Og (DEBUG_BUILD = 1), got
> the following errors:
>
> $ echo 'DEBUG_BUILD = "1"' >> conf/local.conf
> $ echo 'DISTRO_FEATURES:append = " vulkan"' >> conf/local.conf
> $ bitbake vulkan-validation-layers
> ...
> |tmp/work/core2-64-poky-linux/vulkan-validation-layers/1.4.313.0/sources/
> vulkan-validation-layers-1.4.313.0/layers/./external/xxhash.h:4822:1: error:
> inlining failed in call to 'always_inline' 'void XXH3_scrambleAcc_sse2(void*,
> const void*)': function not considered for inlining
> ...
>
> Refer [1], using XXH_NO_INLINE_HINTS when compiling with -Og (DEBUG_BUILD = 1)
>
> [1]https://github.com/Cyan4973/xxHash/issues/943
>
> Signed-off-by: Hongxu Jia<hongxu.jia@windriver.com>
> ---
>   .../vulkan/vulkan-validation-layers_1.4.313.0.bb                | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> index 63a3aa4ae64..c05a1d87007 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.313.0.bb
> @@ -26,6 +26,8 @@ EXTRA_OECMAKE = "\
>       -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
>       "
>   
> +CXXFLAGS:append = " ${@oe.utils.vartrue('DEBUG_BUILD', '-DXXH_NO_INLINE_HINTS=1', '', d)}"
> +
>   PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr"
>   PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON, -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland"
>   
>
Hi Hongxu,

The issue was resolved upstream but fixed in a slightly different way.

Rather than carry this change in oe-core and have to remember to remove 
it or rather forgetting about it for a release or two,
can you  get upstream vulkan to update to pull in the xxHash change and 
then update vulkan for oe-core/master?

Meanwhile, we should carry this in WR Linux until the vulkan update gets 
into oe-core.

This is probably a good approach for DEBUG_BUILD issues in general 
unless other people
on this list speak up and explain why they are also interested in the 
DEBUG_BUILD working.

../Randy



> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#220435):https://lists.openembedded.org/g/openembedded-core/message/220435
> Mute This Topic:https://lists.openembedded.org/mt/114181365/3616765
> Group Owner:openembedded-core+owner@lists.openembedded.org
> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

-- 
# Randy MacLeod
# Wind River Linux

[-- Attachment #2: Type: text/html, Size: 4315 bytes --]

Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

[Antonin Godard]

On Mon Sep 1, 2025 at 9:39 AM CEST, hongxu via lists.openembedded.org wrote:
> When building with GCC 14+ using -Og (DEBUG_BUILD = 1), got
> the following errors:
>
> $ echo 'DEBUG_BUILD = "1"' >> conf/local.conf
> $ echo 'DISTRO_FEATURES:append = " vulkan opengl"' >> conf/local.conf
> $ bitbake vulkan-validation-layers
> ...
> |TOPDIR/tmp/work/core2-32-wrs-linux/vulkan-validation-layers/1.4.309.0/git/layers/./external/
> xxhash.h:4822:1: error: inlining failed in call to 'always_inline' 'void XXH3_scrambleAcc_sse2
> (void*, const void*)': function not considered for inlining
> ...
>
> Refer [1], using XXH_NO_INLINE_HINTS when compiling with -Og (DEBUG_BUILD = 1)
>
> [1] https://github.com/Cyan4973/xxHash/issues/943
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  .../vulkan/vulkan-validation-layers_1.4.321.0.bb                | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> index fa7873b62d3..466e757a908 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> @@ -26,6 +26,8 @@ EXTRA_OECMAKE = "\
>      -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
>      "
>  
> +CXXFLAGS:append = " ${@oe.utils.vartrue('DEBUG_BUILD', '-DXXH_NO_INLINE_HINTS=1', '', d)}"

Minor optmization: could we use "CXXFLAGS +=" instead of :append here?

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com