[whinlatter][PATCH 0/4] gn: upgrade to latest revision

[whinlatter][PATCH 0/4] gn: upgrade to latest revision

[Zoltán Böszörményi]

The latest revision of gn is needed to build Chromium 145
for whinlatter. Nothing else.

See https://github.com/OSSystems/meta-browser/pull/963

Please merge these into whinlatter.

Thanks in advance,
Zoltán Böszörményi

[whinlatter][PATCH 1/4] gn: upgrade to latest revision

[Zoltán Böszörményi]

From: Khem Raj <raj.khem@gmail.com>

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
(cherry picked from commit 11acd84d42608ae8838506e2fbe27878b1429a33)
---
 meta/recipes-devtools/gn/gn_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gn/gn_git.bb b/meta/recipes-devtools/gn/gn_git.bb
index d8896609b1..8637216988 100644
--- a/meta/recipes-devtools/gn/gn_git.bb
+++ b/meta/recipes-devtools/gn/gn_git.bb
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native"
 UPSTREAM_CHECK_COMMITS = "1"
 
 SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main"
-SRCREV = "81b24e01531ecf0eff12ec9359a555ec3944ec4e"
+SRCREV = "092f4f0d612e5982728c8b872c2e69cf3d04b21f"
 PV = "0+git"
 
 BB_GIT_SHALLOW = ""
-- 
2.53.0

[whinlatter][PATCH 2/4] gn: upgrade to latest revision

[Zoltán Böszörményi]

From: Alexander Kanavin <alex@linutronix.de>

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 67419b9a5a03b68bd5df0b080f923b1e513e4537)
---
 meta/recipes-devtools/gn/gn_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gn/gn_git.bb b/meta/recipes-devtools/gn/gn_git.bb
index 8637216988..e61f3936c9 100644
--- a/meta/recipes-devtools/gn/gn_git.bb
+++ b/meta/recipes-devtools/gn/gn_git.bb
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native"
 UPSTREAM_CHECK_COMMITS = "1"
 
 SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main"
-SRCREV = "092f4f0d612e5982728c8b872c2e69cf3d04b21f"
+SRCREV = "64d35867ca0a1088f13de8f4ccaf1a5687d7f1ce"
 PV = "0+git"
 
 BB_GIT_SHALLOW = ""
-- 
2.53.0

[whinlatter][PATCH 3/4] gn: upgrade to latest revision

[Zoltán Böszörményi]

From: Khem Raj <raj.khem@gmail.com>

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 8a59c0c601cd9c52c15f24e0d7b65c0012f1ecc7)
---
 meta/recipes-devtools/gn/gn_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gn/gn_git.bb b/meta/recipes-devtools/gn/gn_git.bb
index e61f3936c9..81d1814191 100644
--- a/meta/recipes-devtools/gn/gn_git.bb
+++ b/meta/recipes-devtools/gn/gn_git.bb
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native"
 UPSTREAM_CHECK_COMMITS = "1"
 
 SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main"
-SRCREV = "64d35867ca0a1088f13de8f4ccaf1a5687d7f1ce"
+SRCREV = "103f8b437f5e791e0aef9d5c372521a5d675fabb"
 PV = "0+git"
 
 BB_GIT_SHALLOW = ""
-- 
2.53.0

[whinlatter][PATCH 4/4] gn: upgrade to latest revision

[Zoltán Böszörményi]

From: Hongxu Jia <hongxu.jia@windriver.com>

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 0ab101678860100c8dd0a47eb1d297624fd95cc9)
---
 meta/recipes-devtools/gn/gn_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gn/gn_git.bb b/meta/recipes-devtools/gn/gn_git.bb
index 81d1814191..0b139ac5f0 100644
--- a/meta/recipes-devtools/gn/gn_git.bb
+++ b/meta/recipes-devtools/gn/gn_git.bb
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native"
 UPSTREAM_CHECK_COMMITS = "1"
 
 SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main"
-SRCREV = "103f8b437f5e791e0aef9d5c372521a5d675fabb"
+SRCREV = "9d19a7870add65151ff91bcc26252bb7521065cf"
 PV = "0+git"
 
 BB_GIT_SHALLOW = ""
-- 
2.53.0

Re: [OE-core] [whinlatter][PATCH 0/4] gn: upgrade to latest revision

[Yoann Congal]

On Sat Mar 21, 2026 at 8:36 AM CET, Zoltan Boszormenyi via lists.openembedded.org wrote:
>
> The latest revision of gn is needed to build Chromium 145
> for whinlatter. Nothing else.
>
> See https://github.com/OSSystems/meta-browser/pull/963
>
> Please merge these into whinlatter.

Hello,

Sorry but general upgrades like this are not acceptable for stable.

Is there a verifiable stability promise from gn upstream that would
somehow make that acceptable? Note that I'm not familiar with it.

Regards,

>
> Thanks in advance,
> Zoltán Böszörményi


-- 
Yoann Congal
Smile ECS

Re: [OE-core] [whinlatter][PATCH 0/4] gn: upgrade to latest revision

[Böszörményi Zoltán]

2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
> On Sat Mar 21, 2026 at 8:36 AM CET, Zoltan Boszormenyi via lists.openembedded.org wrote:
>> The latest revision of gn is needed to build Chromium 145
>> for whinlatter. Nothing else.
>>
>> See https://github.com/OSSystems/meta-browser/pull/963
>>
>> Please merge these into whinlatter.
> Hello,
>
> Sorry but general upgrades like this are not acceptable for stable.

I can keep the gn_git.bbappend in the meta-browser PR.

But then it's not better when every layer shipped their version
before moving it to core.

> Is there a verifiable stability promise from gn upstream that would
> somehow make that acceptable? Note that I'm not familiar with it.

Chromium updates carry a lot of CVE fixes, too.
gn is just a build tool for it and other projects.

Re: [OE-core] [whinlatter][PATCH 0/4] gn: upgrade to latest revision

[Yoann Congal]

On Sat Mar 21, 2026 at 3:02 PM CET, Böszörményi Zoltán wrote:
> 2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
>> On Sat Mar 21, 2026 at 8:36 AM CET, Zoltan Boszormenyi via lists.openembedded.org wrote:
>>> The latest revision of gn is needed to build Chromium 145
>>> for whinlatter. Nothing else.
>>>
>>> See https://github.com/OSSystems/meta-browser/pull/963
>>>
>>> Please merge these into whinlatter.
>> Hello,
>>
>> Sorry but general upgrades like this are not acceptable for stable.
>
> I can keep the gn_git.bbappend in the meta-browser PR.
>
> But then it's not better when every layer shipped their version
> before moving it to core.
>
>> Is there a verifiable stability promise from gn upstream that would
>> somehow make that acceptable? Note that I'm not familiar with it.
>
> Chromium updates carry a lot of CVE fixes, too.
> gn is just a build tool for it and other projects.
Yes I understand.
But this upgrade has feature changes in it (see below) and those are
generaly unacceptable on the risk breaking existing code and our
stability promise.

Your whole series upgrade gn by 43 commits. I saw these ones that are
problematic just by reading the commit title:
 $ git log --oneline 81b24e01531ecf0eff12ec9359a555ec3944ec4e..9d19a7870add65151ff91bcc26252bb7521065cf
7498ca2e Add validation support to gn analyze/desc/path/refs
3c0f5be7 Add pcm files to the deps of phony target
bd3356ac Add `validations` dependency type to targets
1d89b984 Add conductor setup files
4e0818fd Add a sha256 hash implementation and use it for string_hash
0eb071f6 Add a `module_name` flag to source_set.
bf891ce4 Refactor module name to be dynamic.
8450d601 Optimize vector creation in compile_commands_writer.cc.
6e0b557d Run 'tools/run_formatter.sh'
ab6f8b21 Implement `string_hash` function.
d92aee22 Support weak_libraries
4619125b Do not add .inputdeps paths to --ninja-outputs-file
fb3b73df Make clang modules output -fmodule-file=foo=<pcm>.
e7f32021 Add --file_relation to gn refs command
20a6b6d6 Optimize vector initialization and preallocation in desc_builder.cc.
a0c5124a Add `reserve` statement when vector size is known beforehand.
092f4f0d Refactor container update by preferring the range insert.

If you want a shared repo with an upgraded gn for LTS, what do
you think about creating a mixin layer?
https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#LTS_%E2%80%9CMixin%E2%80%9D_repositories
https://git.yoctoproject.org/meta-lts-mixins

For whinlatter (stable but not a LTS) which have more or less a month of
support left, the bbappend in your layer is, IMHO, the realistic
solution.

Regards,
-- 
Yoann Congal
Smile ECS

Re: [OE-core] [whinlatter][PATCH 0/4] gn: upgrade to latest revision

[Böszörményi Zoltán]

2026. 03. 21. 19:45 keltezéssel, Yoann Congal írta:
> On Sat Mar 21, 2026 at 3:02 PM CET, Böszörményi Zoltán wrote:
>> 2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
>>> On Sat Mar 21, 2026 at 8:36 AM CET, Zoltan Boszormenyi via lists.openembedded.org wrote:
>>>> The latest revision of gn is needed to build Chromium 145
>>>> for whinlatter. Nothing else.
>>>>
>>>> See https://github.com/OSSystems/meta-browser/pull/963
>>>>
>>>> Please merge these into whinlatter.
>>> Hello,
>>>
>>> Sorry but general upgrades like this are not acceptable for stable.
>> I can keep the gn_git.bbappend in the meta-browser PR.
>>
>> But then it's not better when every layer shipped their version
>> before moving it to core.
>>
>>> Is there a verifiable stability promise from gn upstream that would
>>> somehow make that acceptable? Note that I'm not familiar with it.
>> Chromium updates carry a lot of CVE fixes, too.
>> gn is just a build tool for it and other projects.
> Yes I understand.
> But this upgrade has feature changes in it (see below) and those are
> generaly unacceptable on the risk breaking existing code and our
> stability promise.
>
> Your whole series upgrade gn by 43 commits. I saw these ones that are
> problematic just by reading the commit title:
>   $ git log --oneline 81b24e01531ecf0eff12ec9359a555ec3944ec4e..9d19a7870add65151ff91bcc26252bb7521065cf
> 7498ca2e Add validation support to gn analyze/desc/path/refs
> 3c0f5be7 Add pcm files to the deps of phony target
> bd3356ac Add `validations` dependency type to targets
> 1d89b984 Add conductor setup files
> 4e0818fd Add a sha256 hash implementation and use it for string_hash
> 0eb071f6 Add a `module_name` flag to source_set.
> bf891ce4 Refactor module name to be dynamic.
> 8450d601 Optimize vector creation in compile_commands_writer.cc.
> 6e0b557d Run 'tools/run_formatter.sh'
> ab6f8b21 Implement `string_hash` function.

At least this one is needed by Chromium 145.
Its do_configure failed due to missing function.

> d92aee22 Support weak_libraries
> 4619125b Do not add .inputdeps paths to --ninja-outputs-file
> fb3b73df Make clang modules output -fmodule-file=foo=<pcm>.
> e7f32021 Add --file_relation to gn refs command
> 20a6b6d6 Optimize vector initialization and preallocation in desc_builder.cc.
> a0c5124a Add `reserve` statement when vector size is known beforehand.
> 092f4f0d Refactor container update by preferring the range insert.
>
> If you want a shared repo with an upgraded gn for LTS, what do
> you think about creating a mixin layer?
> https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#LTS_%E2%80%9CMixin%E2%80%9D_repositories
> https://git.yoctoproject.org/meta-lts-mixins
>
> For whinlatter (stable but not a LTS) which have more or less a month of
> support left, the bbappend in your layer is, IMHO, the realistic
> solution.

meta-browser is not my layer, I just create PRs for it.
Thanks, anyway.

cc-ed the maintainer of meta-browser.
Maybe it would be best to branch off whinlatter and
cherry-pick new versions and add the gn bbappend there later.