[PATCH] uboot-sign: fix concat_dtb arguments

[PATCH] uboot-sign: fix concat_dtb arguments

[Clayton Casciato]

Fixes [YOCTO #15642]

Ensure empty argument passed from do_uboot_assemble_fitimage is passed to
concat_dtb

Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
---
Sponsor: 21SoftWare LLC

 meta/classes-recipe/uboot-sign.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/uboot-sign.bbclass b/meta/classes-recipe/uboot-sign.bbclass
index 3e5f5dcf66..a17be745ce 100644
--- a/meta/classes-recipe/uboot-sign.bbclass
+++ b/meta/classes-recipe/uboot-sign.bbclass
@@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
 	binary="$2"
 
 	if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
-		concat_dtb $type $binary
+		concat_dtb "$type" "$binary"
 	fi
 
 	if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then
-- 
2.34.1

Re: [PATCH] uboot-sign: fix concat_dtb arguments

[Clayton Casciato]

Hello!

I am looking for feedback and/or the status for this patch.

Thanks!

--
Clayton Casciato

On 11/7/24 10:10 AM, Clayton Casciato wrote:
> Fixes [YOCTO #15642]
> 
> Ensure empty argument passed from do_uboot_assemble_fitimage is passed to
> concat_dtb
> 
> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> ---
> Sponsor: 21SoftWare LLC
> 
>  meta/classes-recipe/uboot-sign.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/uboot-sign.bbclass b/meta/classes-recipe/uboot-sign.bbclass
> index 3e5f5dcf66..a17be745ce 100644
> --- a/meta/classes-recipe/uboot-sign.bbclass
> +++ b/meta/classes-recipe/uboot-sign.bbclass
> @@ -338,7 +338,7 @@ uboot_assemble_fitimage_helper() {
>  	binary="$2"
>  
>  	if [ "${UBOOT_SIGN_ENABLE}" = "1" -a -n "${UBOOT_DTB_BINARY}" ] ; then
> -		concat_dtb $type $binary
> +		concat_dtb "$type" "$binary"
>  	fi
>  
>  	if [ "${UBOOT_FITIMAGE_ENABLE}" = "1" -a -n "${SPL_DTB_BINARY}" ]; then

Re: [OE-core] [PATCH] uboot-sign: fix concat_dtb arguments

[Mathieu Dubois-Briand]

On Thu, Nov 14, 2024 at 06:35:29AM -0700, Clayton Casciato via lists.openembedded.org wrote:
> Hello!
> 
> I am looking for feedback and/or the status for this patch.
> 
> Thanks!
> 

Hi Clayton,

This patch has now been merged in master:
https://git.openembedded.org/openembedded-core/commit/?id=b3c473785e5ceef677ff2b77c5fc17f5704c622f

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] uboot-sign: fix concat_dtb arguments

[Clayton Casciato]

> On Thu, Nov 14, 2024 at 06:35:29AM -0700, Clayton Casciato via lists.openembedded.org wrote:
>> Hello!
>>
>> I am looking for feedback and/or the status for this patch.
>>
>> Thanks!
>>
> 
> Hi Clayton,
> 
> This patch has now been merged in master:
> https://git.openembedded.org/openembedded-core/commit/?id=b3c473785e5ceef677ff2b77c5fc17f5704c622f
> 

Hi, Mathieu!

That's good to see.

Thank you for the quick response and link!