[PATCH] Fixes [YOCTO #15965]

[PATCH] Fixes [YOCTO #15965]

[Barne Carstensen]

Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)

Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
CC: randy.macleod@windriver.com
---
 meta/classes-recipe/testexport.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
index 843d777e3b..2f473a8811 100644
--- a/meta/classes-recipe/testexport.bbclass
+++ b/meta/classes-recipe/testexport.bbclass
@@ -79,6 +79,7 @@ def testexport_main(d):
 def copy_needed_files(d, tc):
     import shutil
     import oe.path
+    import glob
 
     from oeqa.utils.package_manager import _get_json_file
     from oeqa.core.utils.test import getSuiteCasesFiles
@@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
                     oe.path.copytree(src, dst)
                 else:
                     shutil.copy2(src, dst)
+    
+    # Copy all parselogs-ignores files
+    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
+    for f in parselogs_ignores:
+         shutil.copy2(f, cases_path)
 
     # Copy test data
     image_name = ("%s/%s" % (d.getVar('DEPLOY_DIR_IMAGE'),

Patchtest results for [PATCH] Fixes [YOCTO #15965]

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/Fixes-YOCTO-15965.patch

FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli]

Hi,

This is not for master branch and subject line should be
something like "[branch name][PATCH] testexport.bbclass: always capture ignore files"

On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)
> 
> Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> CC: randy.macleod@windriver.com
> ---
>  meta/classes-recipe/testexport.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
> index 843d777e3b..2f473a8811 100644
> --- a/meta/classes-recipe/testexport.bbclass
> +++ b/meta/classes-recipe/testexport.bbclass
> @@ -79,6 +79,7 @@ def testexport_main(d):
>  def copy_needed_files(d, tc):
>      import shutil
>      import oe.path
> +    import glob
>  
>      from oeqa.utils.package_manager import _get_json_file
>      from oeqa.core.utils.test import getSuiteCasesFiles
> @@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
>                      oe.path.copytree(src, dst)
>                  else:
>                      shutil.copy2(src, dst)
> +    
> +    # Copy all parselogs-ignores files
> +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> +    for f in parselogs_ignores:
> +         shutil.copy2(f, cases_path)

Master branch is quite different. There the tests and their data
files are now copied from all enabled layers, not just core.
So I would rather port those fixes to relevant branches to avoid
duplicating maitenance.

Cheers,

-Mikko

>      # Copy test data
>      image_name = ("%s/%s" % (d.getVar('DEPLOY_DIR_IMAGE'),

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223546): https://lists.openembedded.org/g/openembedded-core/message/223546
> Mute This Topic: https://lists.openembedded.org/mt/115271587/7159507
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli]

Hi,

On Tue, Sep 16, 2025 at 04:09:58PM +0300, Mikko Rapeli via lists.openembedded.org wrote:
> This is not for master branch and subject line should be
> something like "[branch name][PATCH] testexport.bbclass: always capture ignore files"
> 
> On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> > Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)
> > 
> > Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> > CC: randy.macleod@windriver.com
> > ---
> >  meta/classes-recipe/testexport.bbclass | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
> > index 843d777e3b..2f473a8811 100644
> > --- a/meta/classes-recipe/testexport.bbclass
> > +++ b/meta/classes-recipe/testexport.bbclass
> > @@ -79,6 +79,7 @@ def testexport_main(d):
> >  def copy_needed_files(d, tc):
> >      import shutil
> >      import oe.path
> > +    import glob
> >  
> >      from oeqa.utils.package_manager import _get_json_file
> >      from oeqa.core.utils.test import getSuiteCasesFiles
> > @@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
> >                      oe.path.copytree(src, dst)
> >                  else:
> >                      shutil.copy2(src, dst)
> > +    
> > +    # Copy all parselogs-ignores files
> > +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> > +    for f in parselogs_ignores:
> > +         shutil.copy2(f, cases_path)
> 
> Master branch is quite different. There the tests and their data
> files are now copied from all enabled layers, not just core.
> So I would rather port those fixes to relevant branches to avoid
> duplicating maitenance.

Since the commits are bit scattered, these from master branch
would be needed if not already in the relevant branch:

e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers
05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
2d900c3061e12 oeqa/runtime: set self.runner and handle None

Cheers,

-Mikko

RE: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Barne Carstensen]

Hello,

Okay sorry, was my first time sending a patch and in the manual (https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes) was written to use that form. I am a bit in doubt, which branch should I use as reference? The target milestone of the bug is set to 5.3

>Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:

>e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
>2d900c3061e12 oeqa/runtime: set self.runner and handle None

I cannot find these commits, but do you ask me to cherry pick these as well?
Thanks for the help and sorry again for the inconvenience. I will try to send the patch again with the right subject and reference branch 😊

Barne


Classified as Business
-----Original Message-----
From: Mikko Rapeli <mikko.rapeli@linaro.org>
Sent: Dienstag, 16. September 2025 15:41
To: Barne Carstensen <barne.carstensen@danfoss.com>; openembedded-core@lists.openembedded.org; randy.macleod@windriver.com
Subject: Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[You don't often get email from mikko.rapeli@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi,

On Tue, Sep 16, 2025 at 04:09:58PM +0300, Mikko Rapeli via lists.openembedded.org wrote:
> This is not for master branch and subject line should be something
> like "[branch name][PATCH] testexport.bbclass: always capture ignore files"
>
> On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> > Copy all the parselogs-ignores file so that they are always packed
> > into the testexport.tar.gz (even when testsuite parselog is not
> > selected)
> >
> > Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> > CC: randy.macleod@windriver.com
> > ---
> >  meta/classes-recipe/testexport.bbclass | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/meta/classes-recipe/testexport.bbclass
> > b/meta/classes-recipe/testexport.bbclass
> > index 843d777e3b..2f473a8811 100644
> > --- a/meta/classes-recipe/testexport.bbclass
> > +++ b/meta/classes-recipe/testexport.bbclass
> > @@ -79,6 +79,7 @@ def testexport_main(d):
> >  def copy_needed_files(d, tc):
> >      import shutil
> >      import oe.path
> > +    import glob
> >
> >      from oeqa.utils.package_manager import _get_json_file
> >      from oeqa.core.utils.test import getSuiteCasesFiles @@ -120,6
> > +121,11 @@ def copy_needed_files(d, tc):
> >                      oe.path.copytree(src, dst)
> >                  else:
> >                      shutil.copy2(src, dst)
> > +
> > +    # Copy all parselogs-ignores files
> > +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> > +    for f in parselogs_ignores:
> > +         shutil.copy2(f, cases_path)
>
> Master branch is quite different. There the tests and their data files
> are now copied from all enabled layers, not just core.
> So I would rather port those fixes to relevant branches to avoid
> duplicating maitenance.

Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:

e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
2d900c3061e12 oeqa/runtime: set self.runner and handle None

Cheers,

-Mikko

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Quentin Schulz]

Hi Barne,

On 9/17/25 9:26 AM, Barne Carstensen via lists.openembedded.org wrote:
> [You don't often get email from barne.carstensen=danfoss.com@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hello,
> 
> Okay sorry, was my first time sending a patch and in the manual (https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes) was written to use that form. I am a bit in doubt, which branch should I use as reference? The target milestone of the bug is set to 5.3
> 

It wasn't meant to be understood that way, but I understand how it 
could. I'll try to rephrase it so it clearly states the Fixes mention 
should be in the commit log and not commit title. Thanks for the report!

Would just reordering the example to

"""
detailed description of change

Fixes [YOCTO #bug-id]
"""

be enough?

We could also have:

"""
single-line summary

Fixes [YOCTO #bug-id]

detailed description of change
"""

or

"""
single-line summary

detailed description of change

Fixes [YOCTO #bug-id]
"""

Which of those would be the most understandable (to you)?



5.3 is not out yet, so I would say not specifying the branch is fine as 
that would be master. We're very late in the cycle though, so not 
guaranteed it'll make it in time for the release (but may be a candidate 
for backporting. I'll let Mikko provide background on why they thought 
it isn't for master (did you (Barne) try pulling master and applying 
your patch on top of current master?)

>> Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:
> 
>> e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
>> 2d900c3061e12 oeqa/runtime: set self.runner and handle None
> 
> I cannot find these commits, but do you ask me to cherry pick these as well?

Those are in poky. People refer to commit either in OE-Core or in Poky 
git repositories. The commits from the former end up in the latter but 
with a different hash (hence why we have a "(From OE-Core rev: <hash>)" 
in the commit log.

I guess what Mikko wanted is - if this patch here is for an older 
branch, which doesn't seem to be the case according to you - to also 
backport the listed commits in addition to your patch so that things 
work properly on the older branch.

> Thanks for the help and sorry again for the inconvenience. I will try to send the patch again with the right subject and reference branch 😊
> 

Thanks for the patch and feedback!

Cheers,
Quentin

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli]

Hi,

On Wed, Sep 17, 2025 at 07:26:49AM +0000, Barne Carstensen wrote:
> Hello,
> 
> Okay sorry, was my first time sending a patch and in the manual (https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes) was written to use that form. I am a bit in doubt, which branch should I use as reference? The target milestone of the bug is set to 5.3

Is this for master branch or some other? The bug references 5.0 which is scarthgap but
5.3 is for master branch. In master branch this bug should not exist anymore since
e5e8f2aa0a63d fixes this, and 05e97d5e6e24b and 2d900c3061e12 improve
testexport.bbclass usage even more, on par with testimage.bbclass used in
Auto Builder (AB) testing in oe-core/yocto upstream.

> >Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:
> 
> >e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
> >2d900c3061e12 oeqa/runtime: set self.runner and handle None
> 
> I cannot find these commits, but do you ask me to cherry pick these as well?

Yes, the commits are in master branch. They can be cherry-picked to other
branches and hopefully there are not many other changes or adaptations
needed. Then these need to be proposed for that branch on mailing list.

Cheers,

-Mikko

> Thanks for the help and sorry again for the inconvenience. I will try to send the patch again with the right subject and reference branch 😊
>
> Barne
> 
> 
> Classified as Business
> -----Original Message-----
> From: Mikko Rapeli <mikko.rapeli@linaro.org>
> Sent: Dienstag, 16. September 2025 15:41
> To: Barne Carstensen <barne.carstensen@danfoss.com>; openembedded-core@lists.openembedded.org; randy.macleod@windriver.com
> Subject: Re: [OE-core] [PATCH] Fixes [YOCTO #15965]
> 
> [You don't often get email from mikko.rapeli@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi,
> 
> On Tue, Sep 16, 2025 at 04:09:58PM +0300, Mikko Rapeli via lists.openembedded.org wrote:
> > This is not for master branch and subject line should be something
> > like "[branch name][PATCH] testexport.bbclass: always capture ignore files"
> >
> > On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> > > Copy all the parselogs-ignores file so that they are always packed
> > > into the testexport.tar.gz (even when testsuite parselog is not
> > > selected)
> > >
> > > Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> > > CC: randy.macleod@windriver.com
> > > ---
> > >  meta/classes-recipe/testexport.bbclass | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta/classes-recipe/testexport.bbclass
> > > b/meta/classes-recipe/testexport.bbclass
> > > index 843d777e3b..2f473a8811 100644
> > > --- a/meta/classes-recipe/testexport.bbclass
> > > +++ b/meta/classes-recipe/testexport.bbclass
> > > @@ -79,6 +79,7 @@ def testexport_main(d):
> > >  def copy_needed_files(d, tc):
> > >      import shutil
> > >      import oe.path
> > > +    import glob
> > >
> > >      from oeqa.utils.package_manager import _get_json_file
> > >      from oeqa.core.utils.test import getSuiteCasesFiles @@ -120,6
> > > +121,11 @@ def copy_needed_files(d, tc):
> > >                      oe.path.copytree(src, dst)
> > >                  else:
> > >                      shutil.copy2(src, dst)
> > > +
> > > +    # Copy all parselogs-ignores files
> > > +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> > > +    for f in parselogs_ignores:
> > > +         shutil.copy2(f, cases_path)
> >
> > Master branch is quite different. There the tests and their data files
> > are now copied from all enabled layers, not just core.
> > So I would rather port those fixes to relevant branches to avoid
> > duplicating maitenance.
> 
> Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:
> 
> e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
> 2d900c3061e12 oeqa/runtime: set self.runner and handle None
> 
> Cheers,
> 
> -Mikko

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Quentin Schulz]

Hi Barne,

Please always use "Reply all" when answering messages on the mailing 
list. I'm re-adding everybody in this mail :)

It serves for archiving purposes but also offers people the ability to 
correct me (or any other recipient) as well as providing additional 
context, etc...

On 9/17/25 11:12 AM, Barne Carstensen wrote:
> Hi Quentin,
> 
> I guess I was missing the information that the first line of the commit message will be the subject and afterwards follows the "detailed description". Having that in mind I would go with your second or third suggestion:
> 
>> """
>> single-line summary
>>
>> Fixes [YOCTO #bug-id]
>>
>> detailed description of change
>> """
>>
>> or
>>
>> """
>> single-line summary
>>
>> detailed description of change
>>
>> Fixes [YOCTO #bug-id]
>> """
> 
> But that would still not clarify how the subject should look like.
> 

In the same section a few items above in the list we have:

"""
You should prefix this short description with the recipe name (if 
changing a recipe), or else with the short form path to the file being 
changed.
"""

Did you skim over it unknowingly? Is it too verbose? Not clear enough? 
Would some example help?

It's good to try to be in the shoes of someone who's not used to the 
process, hence why I'm asking a bunch of questions so we have some idea 
how to better formulate this section of the docs :)

>> 5.3 is not out yet, so I would say not specifying the branch is fine as that would be master. We're very late in the cycle though, so not guaranteed it'll make it in time for the release (but >may be a candidate for backporting. I'll let Mikko provide background on why they thought it isn't for master (did you (Barne) try pulling master and applying your patch on top of current >master?)
> 
> Yes, the patch was made on top of the latest master commit "ba3bd832e810bfb96bfa6fcd52710de185dbee22 overlayfs: Disable renaming of network interfaces"
> 
> So, is there anything left I am asked to do? Is changing the commit message now enough, to update the subject, or is there more I should do? 😊

You can either send the v2 with a proper commit title already or wait a 
bit for Mikko to provide feedback in the next few days on why they 
thought this would be targeting older releases, up to you!

Please don't forget to have the v2 in the mail subject, see 
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#taking-patch-review-into-account

Again, do not hesitate to provide feedback on how we could improve the 
documentation for the contribution process (or any other part :) ). Feel 
free to contribute to the yocto-docs as well directly 
(https://git.yoctoproject.org/yocto-docs/).

Looking forward to your patch(es)!

Quentin

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli]

Hi,

On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> Copy all the parselogs-ignores file so that they are always packed into the testexport.tar.gz (even when testsuite parselog is not selected)

This hints to the old behavior of testexport which was taking into account
TEST_SUITES variable. This is no longer the case in poky master branch.
All tests and related files like parselogs ignore lists are copied
as is to testexport tar ball, and from all enabled layers.

> Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> CC: randy.macleod@windriver.com
> ---
>  meta/classes-recipe/testexport.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes-recipe/testexport.bbclass b/meta/classes-recipe/testexport.bbclass
> index 843d777e3b..2f473a8811 100644
> --- a/meta/classes-recipe/testexport.bbclass
> +++ b/meta/classes-recipe/testexport.bbclass
> @@ -79,6 +79,7 @@ def testexport_main(d):
>  def copy_needed_files(d, tc):
>      import shutil
>      import oe.path
> +    import glob
>  
>      from oeqa.utils.package_manager import _get_json_file
>      from oeqa.core.utils.test import getSuiteCasesFiles
> @@ -120,6 +121,11 @@ def copy_needed_files(d, tc):
>                      oe.path.copytree(src, dst)
>                  else:
>                      shutil.copy2(src, dst)
> +    
> +    # Copy all parselogs-ignores files
> +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> +    for f in parselogs_ignores:
> +         shutil.copy2(f, cases_path)

This does not seem right. The lines just above should copy
the path "lib/oeqa/runtime" from all enabled layers with
oe.path.copytree(). Thus it should not be necessary to copy
parselogs files separately using a glob.

Can you try again with master branch without your patch?

If the issue still is there and parselogs files are missing
from testexport tar ball, is the layer in question not enabled
for building in BBLAYERS?

Cheers,

-Mikko

RE: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Barne Carstensen]

Hello,
Took me a while but I was able to build master now and yes, the parselogs_ignores_*.txt files are in the testexport.tar.gz Sorry for not checking that before, I only looked into the reported bugs. Lesson learned. I guess the patch can then be rejected 😊
Thanks and sorry again to waist your time with that,

Barne


Classified as Business
-----Original Message-----
From: Mikko Rapeli <mikko.rapeli@linaro.org>
Sent: Mittwoch, 17. September 2025 11:47
To: Barne Carstensen <barne.carstensen@danfoss.com>
Cc: openembedded-core@lists.openembedded.org; randy.macleod@windriver.com
Subject: Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[You don't often get email from mikko.rapeli@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi,

On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> Copy all the parselogs-ignores file so that they are always packed
> into the testexport.tar.gz (even when testsuite parselog is not
> selected)

This hints to the old behavior of testexport which was taking into account TEST_SUITES variable. This is no longer the case in poky master branch.
All tests and related files like parselogs ignore lists are copied as is to testexport tar ball, and from all enabled layers.

> Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> CC: randy.macleod@windriver.com
> ---
>  meta/classes-recipe/testexport.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes-recipe/testexport.bbclass
> b/meta/classes-recipe/testexport.bbclass
> index 843d777e3b..2f473a8811 100644
> --- a/meta/classes-recipe/testexport.bbclass
> +++ b/meta/classes-recipe/testexport.bbclass
> @@ -79,6 +79,7 @@ def testexport_main(d):
>  def copy_needed_files(d, tc):
>      import shutil
>      import oe.path
> +    import glob
>
>      from oeqa.utils.package_manager import _get_json_file
>      from oeqa.core.utils.test import getSuiteCasesFiles @@ -120,6
> +121,11 @@ def copy_needed_files(d, tc):
>                      oe.path.copytree(src, dst)
>                  else:
>                      shutil.copy2(src, dst)
> +
> +    # Copy all parselogs-ignores files
> +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> +    for f in parselogs_ignores:
> +         shutil.copy2(f, cases_path)

This does not seem right. The lines just above should copy the path "lib/oeqa/runtime" from all enabled layers with oe.path.copytree(). Thus it should not be necessary to copy parselogs files separately using a glob.

Can you try again with master branch without your patch?

If the issue still is there and parselogs files are missing from testexport tar ball, is the layer in question not enabled for building in BBLAYERS?

Cheers,

-Mikko

Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli]

Hi,

On Thu, Sep 18, 2025 at 08:05:12AM +0000, Barne Carstensen wrote:
> Hello,
> Took me a while but I was able to build master now and yes, the parselogs_ignores_*.txt files are in the testexport.tar.gz Sorry for not checking that before, I only looked into the reported bugs. Lesson learned. I guess the patch can then be rejected 😊

No problem. This is a good outcome, a bug can be closed
as already fixed.

Cheers,

-Mikko

RE: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Barne Carstensen]

Hello,
Sorry was a miss click with the reply. Yes, I see it also now. I think the last section about the bug confused me, and I interpretated that as an "instead". So, the other suggestion you made for updating the example should be good enough. Because when I follow the Note:
""
Note.:

To find a suitable prefix for the commit summary, a good idea is to look for prefixes used in previous commits touching the same files or directories:

git log --oneline <paths>
""

I should have been able to write a correct short description.

Thanks,

Barne


Classified as Business
-----Original Message-----
From: Quentin Schulz <quentin.schulz@cherry.de>
Sent: Mittwoch, 17. September 2025 11:25
To: Barne Carstensen <barne.carstensen@danfoss.com>
Cc: Mikko Rapeli <mikko.rapeli@linaro.org>; openembedded-core@lists.openembedded.org; Randy MacLeod <randy.macleod@windriver.com>
Subject: Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[You don't often get email from quentin.schulz@cherry.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi Barne,

Please always use "Reply all" when answering messages on the mailing list. I'm re-adding everybody in this mail :)

It serves for archiving purposes but also offers people the ability to correct me (or any other recipient) as well as providing additional context, etc...

On 9/17/25 11:12 AM, Barne Carstensen wrote:
> Hi Quentin,
>
> I guess I was missing the information that the first line of the commit message will be the subject and afterwards follows the "detailed description". Having that in mind I would go with your second or third suggestion:
>
>> """
>> single-line summary
>>
>> Fixes [YOCTO #bug-id]
>>
>> detailed description of change
>> """
>>
>> or
>>
>> """
>> single-line summary
>>
>> detailed description of change
>>
>> Fixes [YOCTO #bug-id]
>> """
>
> But that would still not clarify how the subject should look like.
>

In the same section a few items above in the list we have:

"""
You should prefix this short description with the recipe name (if changing a recipe), or else with the short form path to the file being changed.
"""

Did you skim over it unknowingly? Is it too verbose? Not clear enough?
Would some example help?

It's good to try to be in the shoes of someone who's not used to the process, hence why I'm asking a bunch of questions so we have some idea how to better formulate this section of the docs :)

>> 5.3 is not out yet, so I would say not specifying the branch is fine
>> as that would be master. We're very late in the cycle though, so not
>> guaranteed it'll make it in time for the release (but >may be a
>> candidate for backporting. I'll let Mikko provide background on why
>> they thought it isn't for master (did you (Barne) try pulling master
>> and applying your patch on top of current >master?)
>
> Yes, the patch was made on top of the latest master commit "ba3bd832e810bfb96bfa6fcd52710de185dbee22 overlayfs: Disable renaming of network interfaces"
>
> So, is there anything left I am asked to do? Is changing the commit
> message now enough, to update the subject, or is there more I should
> do? 😊

You can either send the v2 with a proper commit title already or wait a bit for Mikko to provide feedback in the next few days on why they thought this would be targeting older releases, up to you!

Please don't forget to have the v2 in the mail subject, see
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#taking-patch-review-into-account

Again, do not hesitate to provide feedback on how we could improve the documentation for the contribution process (or any other part :) ). Feel free to contribute to the yocto-docs as well directly (https://git.yoctoproject.org/yocto-docs/).

Looking forward to your patch(es)!

Quentin