* [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" @ 2020-04-04 12:00 rpjday 2020-04-04 12:49 ` [OE-core] " Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: rpjday @ 2020-04-04 12:00 UTC (permalink / raw) To: OE Core mailing list Clarify the setting of "S" so there is absolutely no confusion. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- diff --git a/meta/classes/bin_package.bbclass b/meta/classes/bin_package.bbclass index cbc9b1fa13..4e74557967 100644 --- a/meta/classes/bin_package.bbclass +++ b/meta/classes/bin_package.bbclass @@ -14,8 +14,8 @@ # # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" # -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise -# they would be in ${WORKDIR}. +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise +# they would be in S=${WORKDIR}. # # Skip the unwanted steps -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" 2020-04-04 12:00 [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" rpjday @ 2020-04-04 12:49 ` Richard Purdie 2020-04-04 12:52 ` rpjday 2020-04-04 13:01 ` rpjday 0 siblings, 2 replies; 6+ messages in thread From: Richard Purdie @ 2020-04-04 12:49 UTC (permalink / raw) To: rpjday@crashcourse.ca, OE Core mailing list On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > Clarify the setting of "S" so there is absolutely no confusion. > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > --- > > diff --git a/meta/classes/bin_package.bbclass b/meta/classes/bin_package.bbclass > index cbc9b1fa13..4e74557967 100644 > --- a/meta/classes/bin_package.bbclass > +++ b/meta/classes/bin_package.bbclass > @@ -14,8 +14,8 @@ > # > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > # > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise > -# they would be in ${WORKDIR}. > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise > +# they would be in S=${WORKDIR}. > # I strongly disagree actually. Setting subdir in SRC_URI does not change the value of S. What happens is what the comment says, its unpacked to ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever its set to. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" 2020-04-04 12:49 ` [OE-core] " Richard Purdie @ 2020-04-04 12:52 ` rpjday 2020-04-04 13:01 ` rpjday 1 sibling, 0 replies; 6+ messages in thread From: rpjday @ 2020-04-04 12:52 UTC (permalink / raw) To: Richard Purdie; +Cc: OE Core mailing list On Sat, 4 Apr 2020, Richard Purdie wrote: > On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > > Clarify the setting of "S" so there is absolutely no confusion. > > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > > > --- > > > > diff --git a/meta/classes/bin_package.bbclass b/meta/classes/bin_package.bbclass > > index cbc9b1fa13..4e74557967 100644 > > --- a/meta/classes/bin_package.bbclass > > +++ b/meta/classes/bin_package.bbclass > > @@ -14,8 +14,8 @@ > > # > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > > # > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise > > -# they would be in ${WORKDIR}. > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise > > +# they would be in S=${WORKDIR}. > > # > > I strongly disagree actually. Setting subdir in SRC_URI does not change > the value of S. What happens is what the comment says, its unpacked to > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever > its set to. oh, i didn't realize that, my mistake. i could have sworn ... rday ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" 2020-04-04 12:49 ` [OE-core] " Richard Purdie 2020-04-04 12:52 ` rpjday @ 2020-04-04 13:01 ` rpjday 2020-04-04 13:18 ` Richard Purdie 1 sibling, 1 reply; 6+ messages in thread From: rpjday @ 2020-04-04 13:01 UTC (permalink / raw) To: Richard Purdie; +Cc: OE Core mailing list On Sat, 4 Apr 2020, Richard Purdie wrote: > On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > > Clarify the setting of "S" so there is absolutely no confusion. > > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > > > --- > > > > diff --git a/meta/classes/bin_package.bbclass b/meta/classes/bin_package.bbclass > > index cbc9b1fa13..4e74557967 100644 > > --- a/meta/classes/bin_package.bbclass > > +++ b/meta/classes/bin_package.bbclass > > @@ -14,8 +14,8 @@ > > # > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > > # > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, otherwise > > -# they would be in ${WORKDIR}. > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, otherwise > > +# they would be in S=${WORKDIR}. > > # > > I strongly disagree actually. Setting subdir in SRC_URI does not change > the value of S. What happens is what the comment says, its unpacked to > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at whatever > its set to. so if one inherits bin_package and uses a "subdir" option, what is installed (via tar) is the entire subdir directory structure, as in foo-1.0/* unless the recipe explicitly sets S to match it, is that it? that might be worth noting in the comments, then. rday ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" 2020-04-04 13:01 ` rpjday @ 2020-04-04 13:18 ` Richard Purdie 2020-04-04 13:29 ` rpjday 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2020-04-04 13:18 UTC (permalink / raw) To: Robert P. J. Day; +Cc: OE Core mailing list On Sat, 2020-04-04 at 09:01 -0400, Robert P. J. Day wrote: > On Sat, 4 Apr 2020, Richard Purdie wrote: > > > On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > > > Clarify the setting of "S" so there is absolutely no confusion. > > > > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > > > > > --- > > > > > > diff --git a/meta/classes/bin_package.bbclass > > > b/meta/classes/bin_package.bbclass > > > index cbc9b1fa13..4e74557967 100644 > > > --- a/meta/classes/bin_package.bbclass > > > +++ b/meta/classes/bin_package.bbclass > > > @@ -14,8 +14,8 @@ > > > # > > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > > > # > > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, > > > otherwise > > > -# they would be in ${WORKDIR}. > > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, > > > otherwise > > > +# they would be in S=${WORKDIR}. > > > # > > > > I strongly disagree actually. Setting subdir in SRC_URI does not > > change > > the value of S. What happens is what the comment says, its unpacked > > to > > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at > > whatever > > its set to. > > so if one inherits bin_package and uses a "subdir" option, what is > installed (via tar) is the entire subdir directory structure, as in > > foo-1.0/* That sounds more confusing. The source component of SRC_URI that has subdir set against it is extracted to ${WORKDIR}/<subdir> rather than ${WORKDIR}/. Nothing more, nothing less. > unless the recipe explicitly sets S to match it, is that it? that > might be worth noting in the comments, then. S has nothing to do with this so stop trying to include it. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" 2020-04-04 13:18 ` Richard Purdie @ 2020-04-04 13:29 ` rpjday 0 siblings, 0 replies; 6+ messages in thread From: rpjday @ 2020-04-04 13:29 UTC (permalink / raw) To: Richard Purdie; +Cc: OE Core mailing list On Sat, 4 Apr 2020, Richard Purdie wrote: > On Sat, 2020-04-04 at 09:01 -0400, Robert P. J. Day wrote: > > On Sat, 4 Apr 2020, Richard Purdie wrote: > > > > > On Sat, 2020-04-04 at 08:00 -0400, rpjday@crashcourse.ca wrote: > > > > Clarify the setting of "S" so there is absolutely no confusion. > > > > > > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> > > > > > > > > --- > > > > > > > > diff --git a/meta/classes/bin_package.bbclass > > > > b/meta/classes/bin_package.bbclass > > > > index cbc9b1fa13..4e74557967 100644 > > > > --- a/meta/classes/bin_package.bbclass > > > > +++ b/meta/classes/bin_package.bbclass > > > > @@ -14,8 +14,8 @@ > > > > # > > > > # SRC_URI = "http://foo.com/foo-1.0-r1.i586.rpm;subdir=foo-1.0" > > > > # > > > > -# Then the files would be unpacked to ${WORKDIR}/foo-1.0, > > > > otherwise > > > > -# they would be in ${WORKDIR}. > > > > +# Then the files would be unpacked to S=${WORKDIR}/foo-1.0, > > > > otherwise > > > > +# they would be in S=${WORKDIR}. > > > > # > > > > > > I strongly disagree actually. Setting subdir in SRC_URI does not > > > change > > > the value of S. What happens is what the comment says, its unpacked > > > to > > > ${WORKDIR}/foo-1.0, or ${WORKDIR}. The value of S remains at > > > whatever > > > its set to. > > > > so if one inherits bin_package and uses a "subdir" option, what is > > installed (via tar) is the entire subdir directory structure, as in > > > > foo-1.0/* > > That sounds more confusing. > > The source component of SRC_URI that has subdir set against it is > extracted to ${WORKDIR}/<subdir> rather than ${WORKDIR}/. Nothing more, > nothing less. > > > unless the recipe explicitly sets S to match it, is that it? that > > might be worth noting in the comments, then. > > S has nothing to do with this so stop trying to include it. i actually think we're agreeing here, i'm just explaining myself badly. i'll try again later. rday ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-04 13:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-04-04 12:00 [PATCH] bin_package.bbclass: emphasize setting of S with "subdir" rpjday 2020-04-04 12:49 ` [OE-core] " Richard Purdie 2020-04-04 12:52 ` rpjday 2020-04-04 13:01 ` rpjday 2020-04-04 13:18 ` Richard Purdie 2020-04-04 13:29 ` rpjday
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox