Re: [OE-Core][PATCH v2 2/5] testimage: create a list of failed test post actions

["Alexis Lothoré" <alexis.lothore@bootlin.com>]

On 2/23/24 15:42, Richard Purdie wrote:
> On Fri, 2024-02-23 at 15:03 +0100, Alexis Lothoré via lists.openembedded.org wrote:
>> From: Alexis Lothoré <alexis.lothore@bootlin.com>
>>
>> testimage is able to detect whenever a test run leads to some tests
>> failing, and execute some actions in this case. The only action currently
>> defined in such case is to retrieve artifacts from the target under test,
>> as listed in TESTIMAGE_FAILED_QA_ARTIFACTS
>>
>> In order to be able to add multiple actions, define a central function to
>> gather all "post actions" to run whenever a test has failed
>> (run_failed_tests_post_actions). This function contains a table listing all
>> functions to be called whenever a test fails. Any function in this table
>> will be provided with bitbake internal data dictionary ("d") and the
>> current runtime testing context ("tc"). Isolate all this feature in a
>> dedicated postactions.py file inherited by testimage.
>> This patch does not bring any functional change.
>>
>> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
>> ---
>> Changes in v2:
>> - move functions in a lib in oeqa instead of a bbclass
>> - use new shared helper get_json_result_dir()
>> ---
>>  meta/classes-recipe/testimage.bbclass | 42 +----------------
>>  meta/lib/oeqa/utils/postactions.py    | 68 +++++++++++++++++++++++++++
>>  2 files changed, 70 insertions(+), 40 deletions(-)
>>  create mode 100644 meta/lib/oeqa/utils/postactions.py
> 
> This patch doesn't apply in testimage.bbclass (hunk #3). Could you
> check the branch you're basing these off please?

My bad, I was _almost_ on master, but with a small commit adding some logs, and
I forgot about it.
v3 incoming.

Thanks,

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com