public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: alexis.lothore@bootlin.com, Openembedded-core@lists.openembedded.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [OE-Core][PATCH v2 2/5] testimage: create a list of failed test post actions
Date: Fri, 23 Feb 2024 14:42:02 +0000	[thread overview]
Message-ID: <d3714ffadcf0daaa8915c0fcce0de11cc7dc0879.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240223140345.1362972-3-alexis.lothore@bootlin.com>

On Fri, 2024-02-23 at 15:03 +0100, Alexis Lothoré via lists.openembedded.org wrote:
> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> testimage is able to detect whenever a test run leads to some tests
> failing, and execute some actions in this case. The only action currently
> defined in such case is to retrieve artifacts from the target under test,
> as listed in TESTIMAGE_FAILED_QA_ARTIFACTS
> 
> In order to be able to add multiple actions, define a central function to
> gather all "post actions" to run whenever a test has failed
> (run_failed_tests_post_actions). This function contains a table listing all
> functions to be called whenever a test fails. Any function in this table
> will be provided with bitbake internal data dictionary ("d") and the
> current runtime testing context ("tc"). Isolate all this feature in a
> dedicated postactions.py file inherited by testimage.
> This patch does not bring any functional change.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
> Changes in v2:
> - move functions in a lib in oeqa instead of a bbclass
> - use new shared helper get_json_result_dir()
> ---
>  meta/classes-recipe/testimage.bbclass | 42 +----------------
>  meta/lib/oeqa/utils/postactions.py    | 68 +++++++++++++++++++++++++++
>  2 files changed, 70 insertions(+), 40 deletions(-)
>  create mode 100644 meta/lib/oeqa/utils/postactions.py

This patch doesn't apply in testimage.bbclass (hunk #3). Could you
check the branch you're basing these off please?

Thanks,

Richard


  reply	other threads:[~2024-02-23 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 14:03 [OE-Core][PATCH v2 0/5] testimage: add failed test post actions and fetch more data Alexis Lothoré
2024-02-23 14:03 ` [OE-Core][PATCH v2 1/5] lib/oeqa: share get_json_result_dir helper Alexis Lothoré
2024-02-23 14:38   ` Richard Purdie
2024-02-23 14:03 ` [OE-Core][PATCH v2 2/5] testimage: create a list of failed test post actions Alexis Lothoré
2024-02-23 14:42   ` Richard Purdie [this message]
2024-02-23 14:56     ` Alexis Lothoré
2024-02-23 14:03 ` [OE-Core][PATCH v2 3/5] oeqa/utils/postactions: isolate directory creation in dedicated action Alexis Lothoré
2024-02-23 14:03 ` [OE-Core][PATCH v2 4/5] oeqa/utils/postactions: add target disk usage stat as post action Alexis Lothoré
2024-02-23 14:03 ` [OE-Core][PATCH v2 5/5] oeqa/utils/postactions: testimage: add host " Alexis Lothoré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3714ffadcf0daaa8915c0fcce0de11cc7dc0879.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox