Re: [OE-Core][PATCH v2 1/5] lib/oeqa: share get_json_result_dir helper

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2024-02-23 at 15:03 +0100, Alexis Lothoré via lists.openembedded.org wrote:
> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> Multiple places in oeqa need to get the log output path, and redefine a
> small helper to accomplish this
> 
> Define this helper in lib/oeqa/utils/__init__.py and import it wherever
> needed to allow using it.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
> There is one additional place re-definining (slightly) differently this
> helper, which is in selftest/context.py. This one does not check
> OEQA_JSON_RESULT_DIR from the datastore but through test data embedded in
> the test context. Trying to check the origin of this test data, I
> eventually see that it comes from bitbake environment, so I am not sure it
> is 100% compatible with the datastore content. Please let me know if I'm
> wrong, if so I can also replace selftest redefinition with the shared
> helper too.

Some of the test code has the ability to run without a bitbake datastore 
so I suspect that may be the abstraction you're running into. That said,
from memory I think it emulates the getVar calls so I think it could be 
converted too. Perhaps a follow up patch we can test?

Cheers,

Richard