Re: [OE-core] [poky-contrib][RFC PATCH 2/5] package: Remove false positive lic warnings

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Wed, 2021-02-17 at 14:55 +0000, Peter Kjellerstedt wrote:
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> On Wed, 2021-02-17 at 05:00 +0100, Meh Mbeh Ida Delphine wrote:
> 
> > 
> > diff --git a/meta/classes/package.bbclass
> > b/meta/classes/package.bbclass
> > index c3259146b6..14c8475cfa 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -1774,6 +1774,10 @@ fi
> >                      if l.endswith('-or-later'):
> >                          lic_ = l.replace('-or-later', '+')
> >                          computedpkglicsperpkg.add(lic_)
> > +                    elif l.endswith(' WITH Linux-syscall-note'):
> > +                        if d.getVar("IGNOREWITHLINUXSYSCALLNOTE")
> > == "1":
> > +                            lic_ = l.replace(' WITH Linux-syscall-
> > note', '')
> > +                            computedpkglicsperpkg.add(lic_)
> 
> I think this is going to break things and it should be entirely
> removing this license entry.
> 
> Why? Headers under GPLv2 WITH Linux-syscall-note can be used in a
> non-
> GPLv2 application and that application doesn't then become under
> GPLv2.
> 
> What we probably want is a "safe" list of licenses which don't have
> implications and entries matching "* WITH Linux-syscall-note" can be
> ignored, as long as they're only in header files. Perhaps we also
> need
> a check to ensure we only see "* WITH Linux-syscall-note" in header
> files?
> 
> Cheers,
> 
> Richard

Isn't the problem here really the multiple (sometimes contradictory)
use 
cases for the LICENSE variable. 

1) It is used to document the licenses that cover the code.
2) It is used to determine if the recipe can be built.
3) It is used (together with LIC_FILES_CHKSUM) to populate the licenses
that 
   go into, e.g., ${PN}-lic.
4) It is used by archiver.bbclass to determine what code to export.

I guess I have more specific context here since I know Ida is looking
at comparing what we have in LICENSE with what we can learn from
license headers being built into the code, e.g. to find mismatches.

In that context, trimming to "GPLv2" and them comparing with a recipe
saying "APL-2.0" is bad when in fact its fine.

Cheers,

Richard