From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Ida Delphine <idadelm@gmail.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [poky-contrib][RFC PATCH 4/5] license.bbclass: Add functions to split and canonicalise license strings
Date: Sun, 21 Feb 2021 11:21:27 +0000 [thread overview]
Message-ID: <f28ca99de869b3ab09e0f5f0543f11b12cfe67a1.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAN7sTgsLSTjyLvPrtUVjhEBxh1bOVRHkp+9DkO6rEQ4=uJtTNA@mail.gmail.com>
On Sun, 2021-02-21 at 04:04 +0100, Ida Delphine wrote:
> About moving the functions to license.py I have some trouble importing
> a .bbclass file to the python file. In one of the functions I made use
> of a function found in license.bbclass. Just wondering why it's better
> to move the functions to license.py instead of leaving them at
> license.bbclass and how I will deal with this import issue
The functions in license.py will need to be standalone, they can't easily
call code within a bblcass, only other functions within that module. That
suggests you may need to move other functions, or maybe not move them at
all, it depends what the code is doing really.
We also need to be mindful about dependency tracking. Code in bbclass
files is scanned for variable dependencies, so a getVar("XXX") will
automatically add a dependency on XXX for the generation of task hashes.
Once the code moves to license.py, this does not happen so we have to
account for it manually if needed.
Cheers,
Richard
next prev parent reply other threads:[~2021-02-21 11:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 4:00 [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Meh Mbeh Ida Delphine
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 1/5] package: Remove false positive lic warnings Meh Mbeh Ida Delphine
2021-02-17 10:42 ` [OE-core] " Richard Purdie
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 2/5] " Meh Mbeh Ida Delphine
2021-02-17 10:39 ` [OE-core] " Richard Purdie
2021-02-17 14:55 ` Peter Kjellerstedt
2021-02-17 15:04 ` Richard Purdie
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 3/5] " Meh Mbeh Ida Delphine
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 4/5] license.bbclass: Add functions to split and canonicalise license strings Meh Mbeh Ida Delphine
2021-02-17 10:45 ` [OE-core] " Richard Purdie
2021-02-17 15:04 ` Peter Kjellerstedt
2021-02-17 16:36 ` Richard Purdie
2021-02-17 16:55 ` Meh Mbeh Ida Delphine
2021-02-17 20:51 ` Richard Purdie
2021-02-21 3:04 ` Meh Mbeh Ida Delphine
2021-02-21 11:21 ` Richard Purdie [this message]
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 5/5] package.bbclass: Remove false positive license warnings Meh Mbeh Ida Delphine
2021-02-17 15:50 ` [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Peter Kjellerstedt
2021-02-17 16:58 ` Meh Mbeh Ida Delphine
2021-02-18 11:17 ` Peter Kjellerstedt
2021-02-18 12:21 ` Meh Mbeh Ida Delphine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f28ca99de869b3ab09e0f5f0543f11b12cfe67a1.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=idadelm@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox