public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Meh Mbeh Ida Delphine <idadelm@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for improvements?
Date: Wed, 17 Feb 2021 15:50:03 +0000	[thread overview]
Message-ID: <d2c6bc1c604946f799ea00ec68ee6209@XBOX03.axis.com> (raw)
In-Reply-To: <20210217040033.21541-1-idadelm@gmail.com>

I tried to apply these patches, but the context does not match. Are 
there other patches I need to apply before these can be applied?

//Peter

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Meh Mbeh Ida Delphine
> Sent: den 17 februari 2021 05:00
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for
> improvements?
> 
> Hello everyone,
> 
> The following patchset is aimed at improving the Yocto Project license
> tracing.
> 
> Initially, after a build I will come across 130 license warnings with some
> false positives. I got rid of these by replacing "or-later" with "+" for
> source licenses (computedpkglics) and also passing the recipe license
> through canonical_license of license.py(). As a result, some of the
> licenses will match during comparism hence some warnings eliminate.
> 
> Though some false positive warnings were eliminated, lots of warnings were
> ouputed as a result of several source licenses having "WITH Linux-syscall-
> note". With the help of a variable being set in local.conf, one can
> chooses whether or not to get lid of the "WITH Linux-syscall-note" string
> from the source licenses. Just by doing this, several warnings are dropped
> and now left with 118.
> 
> I later on added some logic depending on "source_spdx_license" variable
> whether or not for the user to allow the warnings being outputed during
> the build. It reduces the extra processing and reduces time if the user
> chooses not to display warnings. It uses bb.utils.contains() to find out
> if that particular vaiable is present. Also, I added
> package_qa_handle_error() to allow the user decide whether they want the
> issues treated as warnings, errors or not at all.
> 
> Some of the license-related logic I added to take care of splitting recipe
> licences before canonicalizing, getting rid of "or-later" warnings, I
> moved it to license.bbclass and put it in functions. I also plan on fixing
> the variable naming since some have underscores whereas others do not
> have. However, I will love to move more license logic in package.bbclass
> to license.bbclass but I need help with the right way to go about it.
> Also, general suggestions on any improvements to this are highly welcomed.
> 
> Cheers,
> Ida.
> 
> Ida Delphine (5):
>   package: Remove false positive lic warnings
>   package: Remove false positive lic warnings
>   package: Remove false positive lic warnings
>   license.bbclass: Add functions to split and canonicalise license
>     strings
>   package.bbclass: Remove false positive license warnings
> 
>  meta/classes/license.bbclass |  27 ++++++++
>  meta/classes/package.bbclass | 127 +++++++++++++++++++----------------
>  2 files changed, 96 insertions(+), 58 deletions(-)
> 
> --
> 2.25.1


  parent reply	other threads:[~2021-02-17 15:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17  4:00 [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Meh Mbeh Ida Delphine
2021-02-17  4:00 ` [poky-contrib][RFC PATCH 1/5] package: Remove false positive lic warnings Meh Mbeh Ida Delphine
2021-02-17 10:42   ` [OE-core] " Richard Purdie
2021-02-17  4:00 ` [poky-contrib][RFC PATCH 2/5] " Meh Mbeh Ida Delphine
2021-02-17 10:39   ` [OE-core] " Richard Purdie
2021-02-17 14:55     ` Peter Kjellerstedt
2021-02-17 15:04       ` Richard Purdie
2021-02-17  4:00 ` [poky-contrib][RFC PATCH 3/5] " Meh Mbeh Ida Delphine
2021-02-17  4:00 ` [poky-contrib][RFC PATCH 4/5] license.bbclass: Add functions to split and canonicalise license strings Meh Mbeh Ida Delphine
2021-02-17 10:45   ` [OE-core] " Richard Purdie
2021-02-17 15:04   ` Peter Kjellerstedt
2021-02-17 16:36     ` Richard Purdie
2021-02-17 16:55       ` Meh Mbeh Ida Delphine
2021-02-17 20:51         ` Richard Purdie
2021-02-21  3:04           ` Meh Mbeh Ida Delphine
2021-02-21 11:21             ` Richard Purdie
2021-02-17  4:00 ` [poky-contrib][RFC PATCH 5/5] package.bbclass: Remove false positive license warnings Meh Mbeh Ida Delphine
2021-02-17 15:50 ` Peter Kjellerstedt [this message]
2021-02-17 16:58   ` [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Meh Mbeh Ida Delphine
2021-02-18 11:17     ` Peter Kjellerstedt
2021-02-18 12:21       ` Meh Mbeh Ida Delphine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2c6bc1c604946f799ea00ec68ee6209@XBOX03.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=idadelm@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox