[PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

[PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

[jay.shen.teoh]

From: Teoh Jay Shen <jay.shen.teoh@intel.com>

removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test

Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
---
 meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
index 75b8975..790c0c0 100644
--- a/meta/lib/oeqa/manual/bsp-hw.json
+++ b/meta/lib/oeqa/manual/bsp-hw.json
@@ -365,28 +365,6 @@
     },
     {
         "test": {
-            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
-            "author": [
-                {
-                    "email": "alexandru.c.georgescu@intel.com",
-                    "name": "alexandru.c.georgescu@intel.com"
-                }
-            ],
-            "execution": {
-                "1": {
-                    "action": "After system launch and X start up, click terminal icon on desktop",
-                    "expected_results": ""
-                },
-                "2": {
-                    "action": "Check if only one terminal window launched and no other problem met",
-                    "expected_results": "There should be no problem after launching terminal . "
-                }
-            },
-            "summary": "click_terminal_icon_on_X_desktop"
-        }
-    },
-    {
-        "test": {
             "@alias": "bsps-hw.bsps-hw.Add_multiple_files_in_media_player",
             "author": [
                 {
-- 
2.7.4

[PATCH 2/2] oeqa/manual/bsp-hw.json : removal of Check_if_RTC_(Real_Time_Clock)_can_work_correctly manual test because of automated

[jay.shen.teoh]

From: Teoh Jay Shen <jay.shen.teoh@intel.com>

removing Check_if_RTC_(Real_Time_Clock)_can_work_correctly manual test as this function is now tested by rtc.py automated runtime test

Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
---
 meta/lib/oeqa/manual/bsp-hw.json | 34 ----------------------------------
 1 file changed, 34 deletions(-)

diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
index 790c0c0..b50b4c2 100644
--- a/meta/lib/oeqa/manual/bsp-hw.json
+++ b/meta/lib/oeqa/manual/bsp-hw.json
@@ -817,40 +817,6 @@
     },
     {
         "test": {
-            "@alias": "bsps-hw.bsps-hw.Check_if_RTC_(Real_Time_Clock)_can_work_correctly",
-            "author": [
-                {
-                    "email": "yi.zhao@windriver.com",
-                    "name": "yi.zhao@windriver.com"
-                }
-            ],
-            "execution": {
-                "1": {
-                    "action": "Read time from RTC registers.  root@localhost:/root> hwclock -r  Sun Mar 22 04:05:47 1970 -0.001948 seconds ",
-                    "expected_results": "Can read and set the time from RTC.\n"
-                },
-                "2": {
-                    "action": "Set system current time  root@localhost:/root> date 062309452008 ",
-                    "expected_results": ""
-                },
-                "3": {
-                    "action": "Synchronize the system current time to RTC registers  root@localhost:/root> hwclock -w ",
-                    "expected_results": ""
-                },
-                "4": {
-                    "action": "Read time from RTC registers  root@localhost:/root> hwclock -r ",
-                    "expected_results": ""
-                },
-                "5": {
-                    "action": "Reboot target and read time from RTC again\n",
-                    "expected_results": ""
-                }
-            },
-            "summary": "Check_if_RTC_(Real_Time_Clock)_can_work_correctly"
-        }
-    },
-    {
-        "test": {
             "@alias": "bsps-hw.bsps-hw.System_can_boot_up_via_NFS",
             "author": [
                 {
-- 
2.7.4

Re: [OE-core] [PATCH 2/2] oeqa/manual/bsp-hw.json : removal of Check_if_RTC_(Real_Time_Clock)_can_work_correctly manual test because of automated

[Richard Purdie]

On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> 
> removing Check_if_RTC_(Real_Time_Clock)_can_work_correctly manual test as this function is now tested by rtc.py automated runtime test
> 
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/manual/bsp-hw.json | 34 ----------------------------------
>  1 file changed, 34 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
> index 790c0c0..b50b4c2 100644
> --- a/meta/lib/oeqa/manual/bsp-hw.json
> +++ b/meta/lib/oeqa/manual/bsp-hw.json
> @@ -817,40 +817,6 @@
>      },
>      {
>          "test": {
> -            "@alias": "bsps-hw.bsps-hw.Check_if_RTC_(Real_Time_Clock)_can_work_correctly",
> -            "author": [
> -                {
> -                    "email": "yi.zhao@windriver.com",
> -                    "name": "yi.zhao@windriver.com"
> -                }
> -            ],
> -            "execution": {
> -                "1": {
> -                    "action": "Read time from RTC registers.  root@localhost:/root> hwclock -r  Sun Mar 22 04:05:47 1970 -0.001948 seconds ",
> -                    "expected_results": "Can read and set the time from RTC.\n"
> -                },
> -                "2": {
> -                    "action": "Set system current time  root@localhost:/root> date 062309452008 ",
> -                    "expected_results": ""
> -                },
> -                "3": {
> -                    "action": "Synchronize the system current time to RTC registers  root@localhost:/root> hwclock -w ",
> -                    "expected_results": ""
> -                },
> -                "4": {
> -                    "action": "Read time from RTC registers  root@localhost:/root> hwclock -r ",
> -                    "expected_results": ""
> -                },
> -                "5": {
> -                    "action": "Reboot target and read time from RTC again\n",
> -                    "expected_results": ""
> -                }
> -            },
> -            "summary": "Check_if_RTC_(Real_Time_Clock)_can_work_correctly"
> -        }
> -    },
> -    {

The test in rtc.py does not include step 5 as there is no system reboot
to check the rtc changes took effect?

Cheers,

Richard

Re: [OE-core] [PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

[Richard Purdie]

On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> 
> removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test
> 
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
> index 75b8975..790c0c0 100644
> --- a/meta/lib/oeqa/manual/bsp-hw.json
> +++ b/meta/lib/oeqa/manual/bsp-hw.json
> @@ -365,28 +365,6 @@
>      },
>      {
>          "test": {
> -            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
> -            "author": [
> -                {
> -                    "email": "alexandru.c.georgescu@intel.com",
> -                    "name": "alexandru.c.georgescu@intel.com"
> -                }
> -            ],
> -            "execution": {
> -                "1": {
> -                    "action": "After system launch and X start up, click terminal icon on desktop",
> -                    "expected_results": ""
> -                },
> -                "2": {
> -                    "action": "Check if only one terminal window launched and no other problem met",
> -                    "expected_results": "There should be no problem after launching terminal . "
> -                }
> -            },
> -            "summary": "click_terminal_icon_on_X_desktop"
> -        }
> -    },
> -    {
> -        "test": {

I'm afraid this testcase does not match what terminal.py is testing.
The test here is to:

a) check it launches
b) check there is only one terminal

and the test in terminal.py does neither of these things.

Cheers,

Richard

Re: [OE-core] [PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

[jay.shen.teoh]

Hi Richard,

Noted with thanks. I will rework on the test case.

Thanks,
Teoh Jay Shen

-----Original Message-----
From: Richard Purdie <richard.purdie@linuxfoundation.org> 
Sent: Wednesday, 28 October, 2020 9:40 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com>; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] oeqa/manual/bsp-hw.json : removal of click_terminal_icon_on_X_desktop manual test because of automated

On Wed, 2020-10-28 at 11:40 +0800, jay.shen.teoh@intel.com wrote:
> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> 
> removing click_terminal_icon_on_X_desktop manual test as this function is now tested by terminal.py automated runtime test
> 
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/manual/bsp-hw.json | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/meta/lib/oeqa/manual/bsp-hw.json b/meta/lib/oeqa/manual/bsp-hw.json
> index 75b8975..790c0c0 100644
> --- a/meta/lib/oeqa/manual/bsp-hw.json
> +++ b/meta/lib/oeqa/manual/bsp-hw.json
> @@ -365,28 +365,6 @@
>      },
>      {
>          "test": {
> -            "@alias": "bsps-hw.bsps-hw.click_terminal_icon_on_X_desktop",
> -            "author": [
> -                {
> -                    "email": "alexandru.c.georgescu@intel.com",
> -                    "name": "alexandru.c.georgescu@intel.com"
> -                }
> -            ],
> -            "execution": {
> -                "1": {
> -                    "action": "After system launch and X start up, click terminal icon on desktop",
> -                    "expected_results": ""
> -                },
> -                "2": {
> -                    "action": "Check if only one terminal window launched and no other problem met",
> -                    "expected_results": "There should be no problem after launching terminal . "
> -                }
> -            },
> -            "summary": "click_terminal_icon_on_X_desktop"
> -        }
> -    },
> -    {
> -        "test": {

I'm afraid this testcase does not match what terminal.py is testing.
The test here is to:

a) check it launches
b) check there is only one terminal

and the test in terminal.py does neither of these things.

Cheers,

Richard