Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv
@ 2011-05-28  2:44 Khem Raj
  2011-05-28  2:44 ` [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations Khem Raj
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Khem Raj @ 2011-05-28  2:44 UTC (permalink / raw)
  To: OE core

The following changes since commit ae1ba18f70c0dac5bed376f6677258c33290ce30:

  uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations (2011-05-27 19:41:33 -0700)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib kraj/misc-fixes
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/misc-fixes

Khem Raj (2):
  uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all
    ARM configurations
  package.bbclass,prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

 meta/classes/package.bbclass                       |    2 +-
 meta/classes/prserv.bbclass                        |    2 +-
 .../uclibc/uclibc-git/arm/uClibc.machine           |    1 +
 .../uclibc/uclibc-git/armv5te/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/nslu2be/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/qemuarm/uClibc.machine       |    1 +
 6 files changed, 6 insertions(+), 2 deletions(-)

-- 
1.7.4.1




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations
  2011-05-28  2:44 [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Khem Raj
@ 2011-05-28  2:44 ` Khem Raj
  2011-05-28  2:44 ` [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0" Khem Raj
  2011-05-29  8:40 ` [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Richard Purdie
  2 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2011-05-28  2:44 UTC (permalink / raw)
  To: OE core

This entry need to exist so that it can be manipulated later
to decide if uclibc is to be compiled in thumb mode or arm mode

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../uclibc/uclibc-git/arm/uClibc.machine           |    1 +
 .../uclibc/uclibc-git/armv5te/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/nslu2be/uClibc.machine       |    1 +
 .../uclibc/uclibc-git/qemuarm/uClibc.machine       |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/meta/recipes-core/uclibc/uclibc-git/arm/uClibc.machine b/meta/recipes-core/uclibc/uclibc-git/arm/uClibc.machine
index 293f384..92ee868 100644
--- a/meta/recipes-core/uclibc/uclibc-git/arm/uClibc.machine
+++ b/meta/recipes-core/uclibc/uclibc-git/arm/uClibc.machine
@@ -33,6 +33,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 CONFIG_GENERIC_ARM=y
 # CONFIG_ARM610 is not set
diff --git a/meta/recipes-core/uclibc/uclibc-git/armv5te/uClibc.machine b/meta/recipes-core/uclibc/uclibc-git/armv5te/uClibc.machine
index eb76f34..b012a38 100644
--- a/meta/recipes-core/uclibc/uclibc-git/armv5te/uClibc.machine
+++ b/meta/recipes-core/uclibc/uclibc-git/armv5te/uClibc.machine
@@ -36,6 +36,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 CONFIG_GENERIC_ARM=y
 # CONFIG_ARM610 is not set
diff --git a/meta/recipes-core/uclibc/uclibc-git/nslu2be/uClibc.machine b/meta/recipes-core/uclibc/uclibc-git/nslu2be/uClibc.machine
index f5aa134..6b07dd5 100644
--- a/meta/recipes-core/uclibc/uclibc-git/nslu2be/uClibc.machine
+++ b/meta/recipes-core/uclibc/uclibc-git/nslu2be/uClibc.machine
@@ -33,6 +33,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 # CONFIG_GENERIC_ARM is not set
 # CONFIG_ARM610 is not set
diff --git a/meta/recipes-core/uclibc/uclibc-git/qemuarm/uClibc.machine b/meta/recipes-core/uclibc/uclibc-git/qemuarm/uClibc.machine
index 7154278..2242dc9 100644
--- a/meta/recipes-core/uclibc/uclibc-git/qemuarm/uClibc.machine
+++ b/meta/recipes-core/uclibc/uclibc-git/qemuarm/uClibc.machine
@@ -36,6 +36,7 @@ TARGET_ARCH="arm"
 FORCE_OPTIONS_FOR_ARCH=y
 # CONFIG_ARM_OABI is not set
 CONFIG_ARM_EABI=y
+# COMPILE_IN_THUMB_MODE is not set
 USE_BX=y
 # CONFIG_GENERIC_ARM is not set
 # CONFIG_ARM610 is not set
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"
  2011-05-28  2:44 [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Khem Raj
  2011-05-28  2:44 ` [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations Khem Raj
@ 2011-05-28  2:44 ` Khem Raj
  2011-05-28  7:50   ` Koen Kooi
  2011-05-29  8:40 ` [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Richard Purdie
  2 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2011-05-28  2:44 UTC (permalink / raw)
  To: OE core

Value of USE_PR_SERV is either "1" or "0" looking at
settings in bitbake.conf
USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}"
So we compare the strings

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/classes/package.bbclass |    2 +-
 meta/classes/prserv.bbclass  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index a1b9482..1e6a872 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
 #
 
 python package_get_auto_pr() {
-	if d.getVar('USE_PR_SERV', True):
+	if d.getVar('USE_PR_SERV', True) != "0":
 		auto_pr=prserv_get_pr_auto(d)
 		if auto_pr is None:
 			bb.fatal("Can NOT get auto PR revision from remote PR service")
diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass
index de46ff6..18b8589 100644
--- a/meta/classes/prserv.bbclass
+++ b/meta/classes/prserv.bbclass
@@ -12,7 +12,7 @@ def prserv_make_conn(d):
     return conn
 
 def prserv_get_pr_auto(d):
-    if not d.getVar('USE_PR_SERV', True):
+    if d.getVar('USE_PR_SERV', True) != "0":
         bb.warn("Not using network based PR service")
         return None
 
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"
  2011-05-28  2:44 ` [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0" Khem Raj
@ 2011-05-28  7:50   ` Koen Kooi
  2011-05-28  8:08     ` Martin Jansa
  0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2011-05-28  7:50 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer


Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven:

> Value of USE_PR_SERV is either "1" or "0" looking at
> settings in bitbake.conf
> USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}"
> So we compare the strings
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Fixes the problem for me:

Tested-by: Koen Kooi <koen@dominion.thruhere.net>

> ---
> meta/classes/package.bbclass |    2 +-
> meta/classes/prserv.bbclass  |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index a1b9482..1e6a872 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
> #
> 
> python package_get_auto_pr() {
> -	if d.getVar('USE_PR_SERV', True):
> +	if d.getVar('USE_PR_SERV', True) != "0":
> 		auto_pr=prserv_get_pr_auto(d)
> 		if auto_pr is None:
> 			bb.fatal("Can NOT get auto PR revision from remote PR service")
> diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass
> index de46ff6..18b8589 100644
> --- a/meta/classes/prserv.bbclass
> +++ b/meta/classes/prserv.bbclass
> @@ -12,7 +12,7 @@ def prserv_make_conn(d):
>     return conn
> 
> def prserv_get_pr_auto(d):
> -    if not d.getVar('USE_PR_SERV', True):
> +    if d.getVar('USE_PR_SERV', True) != "0":
>         bb.warn("Not using network based PR service")
>         return None
> 
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"
  2011-05-28  7:50   ` Koen Kooi
@ 2011-05-28  8:08     ` Martin Jansa
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2011-05-28  8:08 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]

On Sat, May 28, 2011 at 09:50:09AM +0200, Koen Kooi wrote:
> 
> Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven:
> 
> > Value of USE_PR_SERV is either "1" or "0" looking at
> > settings in bitbake.conf
> > USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}"
> > So we compare the strings
> > 
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> Fixes the problem for me:
> 
> Tested-by: Koen Kooi <koen@dominion.thruhere.net>

For me too:
Tested-by: Martin Jansa <Martin.Jansa@gmail.com>

> > ---
> > meta/classes/package.bbclass |    2 +-
> > meta/classes/prserv.bbclass  |    2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> > index a1b9482..1e6a872 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
> > #
> > 
> > python package_get_auto_pr() {
> > -	if d.getVar('USE_PR_SERV', True):
> > +	if d.getVar('USE_PR_SERV', True) != "0":
> > 		auto_pr=prserv_get_pr_auto(d)
> > 		if auto_pr is None:
> > 			bb.fatal("Can NOT get auto PR revision from remote PR service")
> > diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass
> > index de46ff6..18b8589 100644
> > --- a/meta/classes/prserv.bbclass
> > +++ b/meta/classes/prserv.bbclass
> > @@ -12,7 +12,7 @@ def prserv_make_conn(d):
> >     return conn
> > 
> > def prserv_get_pr_auto(d):
> > -    if not d.getVar('USE_PR_SERV', True):
> > +    if d.getVar('USE_PR_SERV', True) != "0":
> >         bb.warn("Not using network based PR service")
> >         return None
> > 
> > -- 
> > 1.7.4.1
> > 
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv
  2011-05-28  2:44 [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Khem Raj
  2011-05-28  2:44 ` [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations Khem Raj
  2011-05-28  2:44 ` [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0" Khem Raj
@ 2011-05-29  8:40 ` Richard Purdie
  2 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2011-05-29  8:40 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Fri, 2011-05-27 at 19:44 -0700, Khem Raj wrote:
> The following changes since commit ae1ba18f70c0dac5bed376f6677258c33290ce30:
> 
>   uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations (2011-05-27 19:41:33 -0700)
> 
> are available in the git repository at:
>   git://git.openembedded.org/openembedded-core-contrib kraj/misc-fixes
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/misc-fixes
> 
> Khem Raj (2):
>   uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all
>     ARM configurations
>   package.bbclass,prserv.bbclass: Compare USE_PR_SERV with "1" or "0"

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-05-29  8:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-28  2:44 [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Khem Raj
2011-05-28  2:44 ` [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations Khem Raj
2011-05-28  2:44 ` [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0" Khem Raj
2011-05-28  7:50   ` Koen Kooi
2011-05-28  8:08     ` Martin Jansa
2011-05-29  8:40 ` [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox