Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] busybox: bump PR to enable largefile support
@ 2011-07-01  9:53 Dexuan Cui
  2011-07-01  9:53 ` [PATCH 1/1] " Dexuan Cui
  2011-07-01  9:56 ` [PATCH 0/1] " Cui, Dexuan
  0 siblings, 2 replies; 5+ messages in thread
From: Dexuan Cui @ 2011-07-01  9:53 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 4d60d32a60ae0fae1002b27cd7d20c28532f4932:

  poky.conf: add largefile support into DISTRO_FEATURES (2011-07-01 17:35:26 +0800)

Dexuan Cui (1):
  busybox: bump PR to enable largefile support

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib dcui/mkswap
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/mkswap

 meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.6




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] busybox: bump PR to enable largefile support
  2011-07-01  9:53 [PATCH 0/1] busybox: bump PR to enable largefile support Dexuan Cui
@ 2011-07-01  9:53 ` Dexuan Cui
  2011-07-01  9:59   ` Phil Blundell
  2011-07-01  9:56 ` [PATCH 0/1] " Cui, Dexuan
  1 sibling, 1 reply; 5+ messages in thread
From: Dexuan Cui @ 2011-07-01  9:53 UTC (permalink / raw)
  To: openembedded-core

[YOCTO #1205 ]

In the previous commit we enable largefile setting in
meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to
actually enable it.

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
 meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox_1.18.4.bb b/meta/recipes-core/busybox/busybox_1.18.4.bb
index cb41ac6..5883cc6 100644
--- a/meta/recipes-core/busybox/busybox_1.18.4.bb
+++ b/meta/recipes-core/busybox/busybox_1.18.4.bb
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
-- 
1.7.6




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] busybox: bump PR to enable largefile support
  2011-07-01  9:53 [PATCH 0/1] busybox: bump PR to enable largefile support Dexuan Cui
  2011-07-01  9:53 ` [PATCH 1/1] " Dexuan Cui
@ 2011-07-01  9:56 ` Cui, Dexuan
  1 sibling, 0 replies; 5+ messages in thread
From: Cui, Dexuan @ 2011-07-01  9:56 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org

Cui, Dexuan wrote:
> The following changes since commit
> 4d60d32a60ae0fae1002b27cd7d20c28532f4932: 
> 
>   poky.conf: add largefile support into DISTRO_FEATURES (2011-07-01
> 17:35:26 +0800) 
> 
> Dexuan Cui (1):
>   busybox: bump PR to enable largefile support
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib dcui/mkswap
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/mkswap
> 
>  meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

BTW: please see my first commit in poky@yoctoproject.org.

Thanks,
-- Dexuan


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] busybox: bump PR to enable largefile support
  2011-07-01  9:53 ` [PATCH 1/1] " Dexuan Cui
@ 2011-07-01  9:59   ` Phil Blundell
  2011-07-01 14:10     ` Cui, Dexuan
  0 siblings, 1 reply; 5+ messages in thread
From: Phil Blundell @ 2011-07-01  9:59 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote:
> In the previous commit we enable largefile setting in
> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to
> actually enable it.

I guess this would be a good case for using something like OE .dev's
DISTRO_PR.  It would be a bit sad if we end up having to bump PRs all
over the place in oe-core whenever some random layer changes its
DISTRO_FEATURES or whatever.

Also, just on a stylistic issue, it's a bit confusing to talk about "the
previous commit" if the commit in question was to a different file and
in a different repo.  If you want to refer to a specific commit it's
best to mention the actual hash and, if necessary, the repo where it can
be found.

p.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] busybox: bump PR to enable largefile support
  2011-07-01  9:59   ` Phil Blundell
@ 2011-07-01 14:10     ` Cui, Dexuan
  0 siblings, 0 replies; 5+ messages in thread
From: Cui, Dexuan @ 2011-07-01 14:10 UTC (permalink / raw)
  To: 'Patches and discussions about the oe-core layer'

Phil Blundell wrote:
> On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote:
>> In the previous commit we enable largefile setting in
>> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to
>> actually enable it.
> 
> I guess this would be a good case for using something like OE .dev's
> DISTRO_PR.  It would be a bit sad if we end up having to bump PRs all
> over the place in oe-core whenever some random layer changes its
> DISTRO_FEATURES or whatever.
Thanks for the info! 
I didn't know OE.dev's DISTRO_PR before. I'm going to look at that.

> Also, just on a stylistic issue, it's a bit confusing to talk about
> "the previous commit" if the commit in question was to a different
> file and in a different repo.  If you want to refer to a specific
> commit it's best to mention the actual hash and, if necessary, the
> repo where it can be found.
Thanks for the suggestion!
I'll pay special attention to this and avoid confusion in future.

Thanks,
-- Dexuan


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-07-01 14:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-01  9:53 [PATCH 0/1] busybox: bump PR to enable largefile support Dexuan Cui
2011-07-01  9:53 ` [PATCH 1/1] " Dexuan Cui
2011-07-01  9:59   ` Phil Blundell
2011-07-01 14:10     ` Cui, Dexuan
2011-07-01  9:56 ` [PATCH 0/1] " Cui, Dexuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox