[PATCH 0/1] fix: Traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (bug 4486)

[PATCH 0/1] fix: Traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (bug 4486)

[Ionut Radu]

bb.build.FuncFailed was replaced with bb.fatal

The following changes since commit 74e403705e25afec656b5e40921771a9c29bdc40:

  yocto-kernel: make BBLAYERS parsing more robust (2013-07-13 18:23:39 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ionutx/work
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ionutx/work

Ionut Radu (1):
  fix traceback when inheriting useradd but not setting USERADD_PARAM
    or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH 1/1] fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

[Ionut Radu]

Signed-off-by: Ionut Radu <ionutx.radu@intel.com>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 3fe011d..a68b6fd 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -219,7 +219,7 @@ def update_useradd_after_parse(d):
 
     for pkg in useradd_packages.split():
         if not d.getVar('USERADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPMEMS_PARAM_%s' % pkg, True):
-            raise bb.build.FuncFailed("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
+            bb.fatal("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
 
 python __anonymous() {
     update_useradd_after_parse(d)
-- 
1.7.10.4

Re: [PATCH 1/1] fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)

[Saul Wold]

Please fix the commit message to follow the guildlines:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
	Sau!

On 07/18/2013 05:54 AM, Ionut Radu wrote:
> Signed-off-by: Ionut Radu <ionutx.radu@intel.com>
> ---
>   meta/classes/useradd.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index 3fe011d..a68b6fd 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -219,7 +219,7 @@ def update_useradd_after_parse(d):
>
>       for pkg in useradd_packages.split():
>           if not d.getVar('USERADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPMEMS_PARAM_%s' % pkg, True):
> -            raise bb.build.FuncFailed("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
> +            bb.fatal("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
>
>   python __anonymous() {
>       update_useradd_after_parse(d)
>