* [PATCH v2 0/1] flex: fix m4 issue on target @ 2013-11-06 13:07 Laurentiu Palcu 2013-11-06 13:07 ` [PATCH v2 1/1] " Laurentiu Palcu 0 siblings, 1 reply; 5+ messages in thread From: Laurentiu Palcu @ 2013-11-06 13:07 UTC (permalink / raw) To: openembedded-core v2: * changed the implementation as per Enrico Scholz's suggestion (thanks); Laurentiu The following changes since commit d6cc7c8ed76c8b1117cf03c7bd4b0742f98f79b3: toolchain-scripts/meta-environment: Further cleanup code duplication (2013-11-06 11:02:27 +0000) are available in the git repository at: git://git.yoctoproject.org/poky-contrib lpalcu/b5329_flex_issue_target http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=lpalcu/b5329_flex_issue_target Laurentiu Palcu (1): flex: fix m4 issue on target meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/1] flex: fix m4 issue on target 2013-11-06 13:07 [PATCH v2 0/1] flex: fix m4 issue on target Laurentiu Palcu @ 2013-11-06 13:07 ` Laurentiu Palcu 2013-11-14 12:43 ` Laurentiu Palcu 0 siblings, 1 reply; 5+ messages in thread From: Laurentiu Palcu @ 2013-11-06 13:07 UTC (permalink / raw) To: openembedded-core Flex needs m4 to run (see below) and, since the create_wrapper introduces a bash dependency on target, give the path to m4 binary in the configure command line. Snippet from the flex documentation: "The macro processor m4 must be installed wherever flex is installed. <...> m4 is only required at the time you run flex." [YOCTO #5329] Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> --- meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc index 43f1dda..96d5de5 100644 --- a/meta/recipes-devtools/flex/flex.inc +++ b/meta/recipes-devtools/flex/flex.inc @@ -13,6 +13,9 @@ inherit autotools gettext M4 = "${bindir}/m4" M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" +EXTRA_OECONF += "ac_cv_path_M4=${M4}" +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" + do_install_append_class-native() { create_wrapper ${D}/${bindir}/flex M4=${M4} } @@ -20,3 +23,5 @@ do_install_append_class-native() { do_install_append_class-nativesdk() { create_wrapper ${D}/${bindir}/flex M4=${M4} } + +RDEPENDS_${PN} += "m4" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] flex: fix m4 issue on target 2013-11-06 13:07 ` [PATCH v2 1/1] " Laurentiu Palcu @ 2013-11-14 12:43 ` Laurentiu Palcu 2013-11-14 13:19 ` Richard Purdie 0 siblings, 1 reply; 5+ messages in thread From: Laurentiu Palcu @ 2013-11-14 12:43 UTC (permalink / raw) To: openembedded-core Even though this was in the last C-pull, for some reason, it didn't end up in master... Didn't see any comments on it either. Or maybe I missed them... Thanks, Laurentiu On Wed, Nov 06, 2013 at 03:07:58PM +0200, Laurentiu Palcu wrote: > Flex needs m4 to run (see below) and, since the create_wrapper > introduces a bash dependency on target, give the path to m4 binary in > the configure command line. > > Snippet from the flex documentation: > "The macro processor m4 must be installed wherever flex is installed. > <...> > m4 is only required at the time you run flex." > > [YOCTO #5329] > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> > --- > meta/recipes-devtools/flex/flex.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc > index 43f1dda..96d5de5 100644 > --- a/meta/recipes-devtools/flex/flex.inc > +++ b/meta/recipes-devtools/flex/flex.inc > @@ -13,6 +13,9 @@ inherit autotools gettext > M4 = "${bindir}/m4" > M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" > > +EXTRA_OECONF += "ac_cv_path_M4=${M4}" > +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" > + > do_install_append_class-native() { > create_wrapper ${D}/${bindir}/flex M4=${M4} > } > @@ -20,3 +23,5 @@ do_install_append_class-native() { > do_install_append_class-nativesdk() { > create_wrapper ${D}/${bindir}/flex M4=${M4} > } > + > +RDEPENDS_${PN} += "m4" > -- > 1.7.9.5 > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] flex: fix m4 issue on target 2013-11-14 12:43 ` Laurentiu Palcu @ 2013-11-14 13:19 ` Richard Purdie 2013-11-14 13:52 ` Laurentiu Palcu 0 siblings, 1 reply; 5+ messages in thread From: Richard Purdie @ 2013-11-14 13:19 UTC (permalink / raw) To: Laurentiu Palcu; +Cc: openembedded-core On Thu, 2013-11-14 at 14:43 +0200, Laurentiu Palcu wrote: > Even though this was in the last C-pull, for some reason, it didn't end > up in master... Didn't see any comments on it either. Or maybe I missed > them... In the target case, M4 should be compiled in as ${bindir}/m4 and there should be no need of a wrapper. Can someone confirm this is the case? Is the OEMAKE command only used for compilation and not built into the target? Cheers, Richard > Thanks, > Laurentiu > > On Wed, Nov 06, 2013 at 03:07:58PM +0200, Laurentiu Palcu wrote: > > Flex needs m4 to run (see below) and, since the create_wrapper > > introduces a bash dependency on target, give the path to m4 binary in > > the configure command line. > > > > Snippet from the flex documentation: > > "The macro processor m4 must be installed wherever flex is installed. > > <...> > > m4 is only required at the time you run flex." > > > > [YOCTO #5329] > > > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> > > --- > > meta/recipes-devtools/flex/flex.inc | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc > > index 43f1dda..96d5de5 100644 > > --- a/meta/recipes-devtools/flex/flex.inc > > +++ b/meta/recipes-devtools/flex/flex.inc > > @@ -13,6 +13,9 @@ inherit autotools gettext > > M4 = "${bindir}/m4" > > M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" > > > > +EXTRA_OECONF += "ac_cv_path_M4=${M4}" > > +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" > > + > > do_install_append_class-native() { > > create_wrapper ${D}/${bindir}/flex M4=${M4} > > } > > @@ -20,3 +23,5 @@ do_install_append_class-native() { > > do_install_append_class-nativesdk() { > > create_wrapper ${D}/${bindir}/flex M4=${M4} > > } > > + > > +RDEPENDS_${PN} += "m4" > > -- > > 1.7.9.5 > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] flex: fix m4 issue on target 2013-11-14 13:19 ` Richard Purdie @ 2013-11-14 13:52 ` Laurentiu Palcu 0 siblings, 0 replies; 5+ messages in thread From: Laurentiu Palcu @ 2013-11-14 13:52 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On Thu, Nov 14, 2013 at 01:19:10PM +0000, Richard Purdie wrote: > On Thu, 2013-11-14 at 14:43 +0200, Laurentiu Palcu wrote: > > Even though this was in the last C-pull, for some reason, it didn't end > > up in master... Didn't see any comments on it either. Or maybe I missed > > them... > > In the target case, M4 should be compiled in as ${bindir}/m4 and there > should be no need of a wrapper. Can someone confirm this is the case? Is > the OEMAKE command only used for compilation and not built into the > target? The m4 variable set in EXTRA_OEMAKE is used to generate skel.c file. And, for that, it needs the native m4. It does not end into the target. The path set with ac_cv_path_M4=${M4} in EXTRA_OECONF ends into the target. Laurentiu > > Cheers, > > Richard > > > > Thanks, > > Laurentiu > > > > On Wed, Nov 06, 2013 at 03:07:58PM +0200, Laurentiu Palcu wrote: > > > Flex needs m4 to run (see below) and, since the create_wrapper > > > introduces a bash dependency on target, give the path to m4 binary in > > > the configure command line. > > > > > > Snippet from the flex documentation: > > > "The macro processor m4 must be installed wherever flex is installed. > > > <...> > > > m4 is only required at the time you run flex." > > > > > > [YOCTO #5329] > > > > > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> > > > --- > > > meta/recipes-devtools/flex/flex.inc | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc > > > index 43f1dda..96d5de5 100644 > > > --- a/meta/recipes-devtools/flex/flex.inc > > > +++ b/meta/recipes-devtools/flex/flex.inc > > > @@ -13,6 +13,9 @@ inherit autotools gettext > > > M4 = "${bindir}/m4" > > > M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" > > > > > > +EXTRA_OECONF += "ac_cv_path_M4=${M4}" > > > +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" > > > + > > > do_install_append_class-native() { > > > create_wrapper ${D}/${bindir}/flex M4=${M4} > > > } > > > @@ -20,3 +23,5 @@ do_install_append_class-native() { > > > do_install_append_class-nativesdk() { > > > create_wrapper ${D}/${bindir}/flex M4=${M4} > > > } > > > + > > > +RDEPENDS_${PN} += "m4" > > > -- > > > 1.7.9.5 > > > > > > _______________________________________________ > > > Openembedded-core mailing list > > > Openembedded-core@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-14 13:52 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-06 13:07 [PATCH v2 0/1] flex: fix m4 issue on target Laurentiu Palcu 2013-11-06 13:07 ` [PATCH v2 1/1] " Laurentiu Palcu 2013-11-14 12:43 ` Laurentiu Palcu 2013-11-14 13:19 ` Richard Purdie 2013-11-14 13:52 ` Laurentiu Palcu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox