* [PATCH] valgrind: MIPS: Make toolchain basename generic
@ 2016-09-08 13:14 Zubair Lutfullah Kakakhel
2016-09-08 15:45 ` André Draszik
2016-09-08 15:45 ` akuster808
0 siblings, 2 replies; 5+ messages in thread
From: Zubair Lutfullah Kakakhel @ 2016-09-08 13:14 UTC (permalink / raw)
To: openembedded-core
For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
since OE can support multiple distro layers, not just poky.
Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
---
Pointed out by Andre McCurdy but patch v1 had already been accepted
and applied.
---
meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
index 3d49131..42fd27f 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
@@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
COMPATIBLE_HOST_armv6 = 'null'
# valgrind doesn't like mips soft float
-COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips-poky-linux", d)}"
-COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel-poky-linux", d)}"
+COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
+COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
inherit autotools ptest
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] valgrind: MIPS: Make toolchain basename generic
2016-09-08 13:14 [PATCH] valgrind: MIPS: Make toolchain basename generic Zubair Lutfullah Kakakhel
@ 2016-09-08 15:45 ` André Draszik
2016-09-08 23:29 ` Andre McCurdy
2016-09-08 15:45 ` akuster808
1 sibling, 1 reply; 5+ messages in thread
From: André Draszik @ 2016-09-08 15:45 UTC (permalink / raw)
To: Zubair Lutfullah Kakakhel, Andre McCurdy; +Cc: openembedded-core
On Do, 2016-09-08 at 14:14 +0100, Zubair Lutfullah Kakakhel wrote:
> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
> since OE can support multiple distro layers, not just poky.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
>
> ---
> Pointed out by Andre McCurdy but patch v1 had already been accepted
> and applied.
> ---
> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> index 3d49131..42fd27f 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
> COMPATIBLE_HOST_armv6 = 'null'
>
> # valgrind doesn't like mips soft float
> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", "mips-poky-linux", d)}"
> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", "mipsel-poky-linux", d)}"
> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", ".*-linux", d)}"
> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", ".*-linux", d)}"
Can it not just be set to mips or mipsel? Why .*-linux?
COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips", d)}"
COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel", d)}"
Cheers,
Andre'
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] valgrind: MIPS: Make toolchain basename generic
2016-09-08 13:14 [PATCH] valgrind: MIPS: Make toolchain basename generic Zubair Lutfullah Kakakhel
2016-09-08 15:45 ` André Draszik
@ 2016-09-08 15:45 ` akuster808
2016-09-12 15:04 ` Zubair Lutfullah Kakakhel
1 sibling, 1 reply; 5+ messages in thread
From: akuster808 @ 2016-09-08 15:45 UTC (permalink / raw)
To: openembedded-core
On 09/08/2016 06:14 AM, Zubair Lutfullah Kakakhel wrote:
> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
> since OE can support multiple distro layers, not just poky.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
is this good for Krogoth too? it has the same version.
- armin
>
> ---
> Pointed out by Andre McCurdy but patch v1 had already been accepted
> and applied.
> ---
> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> index 3d49131..42fd27f 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
> COMPATIBLE_HOST_armv6 = 'null'
>
> # valgrind doesn't like mips soft float
> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips-poky-linux", d)}"
> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel-poky-linux", d)}"
> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>
> inherit autotools ptest
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] valgrind: MIPS: Make toolchain basename generic
2016-09-08 15:45 ` André Draszik
@ 2016-09-08 23:29 ` Andre McCurdy
0 siblings, 0 replies; 5+ messages in thread
From: Andre McCurdy @ 2016-09-08 23:29 UTC (permalink / raw)
To: André Draszik; +Cc: OE Core mailing list
On Thu, Sep 8, 2016 at 8:45 AM, André Draszik <git@andred.net> wrote:
> On Do, 2016-09-08 at 14:14 +0100, Zubair Lutfullah Kakakhel wrote:
>> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
>> since OE can support multiple distro layers, not just poky.
>>
>> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
>>
>> ---
>> Pointed out by Andre McCurdy but patch v1 had already been accepted
>> and applied.
>> ---
>> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> index 3d49131..42fd27f 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
>> COMPATIBLE_HOST_armv6 = 'null'
>>
>> # valgrind doesn't like mips soft float
>> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
>> "null", "mips-poky-linux", d)}"
>> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
>> "null", "mipsel-poky-linux", d)}"
>> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
>> "null", ".*-linux", d)}"
>> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
>> "null", ".*-linux", d)}"
>
> Can it not just be set to mips or mipsel? Why .*-linux?
Yes, any pattern that always matches (e.g. "mips", ".*",
"${HOST_SYS}", ".*-linux", etc) would be OK.
> COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips", d)}"
> COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel", d)}"
>
> Cheers,
> Andre'
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] valgrind: MIPS: Make toolchain basename generic
2016-09-08 15:45 ` akuster808
@ 2016-09-12 15:04 ` Zubair Lutfullah Kakakhel
0 siblings, 0 replies; 5+ messages in thread
From: Zubair Lutfullah Kakakhel @ 2016-09-12 15:04 UTC (permalink / raw)
To: akuster808, openembedded-core@lists.openembedded.org
Hi
On 09/08/2016 04:45 PM, akuster808 wrote:
>
>
> On 09/08/2016 06:14 AM, Zubair Lutfullah Kakakhel wrote:
>> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
>> since OE can support multiple distro layers, not just poky.
>>
>> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
>
> is this good for Krogoth too? it has the same version.
Yes. But we'd also need this commit from master
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb?id=d7268e9bbae93455a591bb4f73bfe4bf76497a1b
They can both be squashed into one commit.
Thanks,
ZubairLK
>
> - armin
>>
>> ---
>> Pointed out by Andre McCurdy but patch v1 had already been accepted
>> and applied.
>> ---
>> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> index 3d49131..42fd27f 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
>> COMPATIBLE_HOST_armv6 = 'null'
>>
>> # valgrind doesn't like mips soft float
>> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips-poky-linux", d)}"
>> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel-poky-linux", d)}"
>> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>>
>> inherit autotools ptest
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-12 15:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08 13:14 [PATCH] valgrind: MIPS: Make toolchain basename generic Zubair Lutfullah Kakakhel
2016-09-08 15:45 ` André Draszik
2016-09-08 23:29 ` Andre McCurdy
2016-09-08 15:45 ` akuster808
2016-09-12 15:04 ` Zubair Lutfullah Kakakhel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox