* [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds
@ 2019-09-27 15:07 Trevor Gamblin
2019-09-27 15:10 ` Trevor Gamblin
2019-10-08 14:04 ` Trevor Gamblin
0 siblings, 2 replies; 3+ messages in thread
From: Trevor Gamblin @ 2019-09-27 15:07 UTC (permalink / raw)
To: openembedded-core
From: Trevor Gamblin <trevor.gamblin@windriver.com>
nativesdk builds such as nativesdk-dnf are installing systemd
service files, leading bitbake to throw installed-vs-shipped
warnings, but these are not needed in nativesdk:
WARNING: nativesdk-dnf-4.2.2-r0 do_package: QA Issue: nativesdk-dnf: Files/directories were installed but not shipped in any package:
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.timer
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.timer
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.service
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.service
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.timer
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.service
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.timer
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.service
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.timer
/usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.service
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
nativesdk-dnf: 13 installed and not shipped files. [installed-vs-shipped]
Rather than have each recipe remove the files, an RMINITDIR case
for nativesdk builds should be added to systemd.bbclass.
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
---
meta/classes/systemd.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
index 747055b8fa..1dca09964b 100644
--- a/meta/classes/systemd.bbclass
+++ b/meta/classes/systemd.bbclass
@@ -231,5 +231,6 @@ python rm_sysvinit_initddir (){
do_install[postfuncs] += "${RMINITDIR} "
RMINITDIR_class-target = " rm_sysvinit_initddir rm_systemd_unitdir "
+RMINITDIR_class-nativesdk = " rm_sysvinit_initddir rm_systemd_unitdir "
RMINITDIR = ""
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds
2019-09-27 15:07 [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds Trevor Gamblin
@ 2019-09-27 15:10 ` Trevor Gamblin
2019-10-08 14:04 ` Trevor Gamblin
1 sibling, 0 replies; 3+ messages in thread
From: Trevor Gamblin @ 2019-09-27 15:10 UTC (permalink / raw)
To: openembedded-core
On 9/27/19 11:07 AM, Trevor Gamblin wrote:
> From: Trevor Gamblin <trevor.gamblin@windriver.com>
>
> nativesdk builds such as nativesdk-dnf are installing systemd
> service files, leading bitbake to throw installed-vs-shipped
> warnings, but these are not needed in nativesdk:
>
> WARNING: nativesdk-dnf-4.2.2-r0 do_package: QA Issue: nativesdk-dnf: Files/directories were installed but not shipped in any package:
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.service
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> nativesdk-dnf: 13 installed and not shipped files. [installed-vs-shipped]
>
> Rather than have each recipe remove the files, an RMINITDIR case
> for nativesdk builds should be added to systemd.bbclass.
>
> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> ---
> meta/classes/systemd.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
> index 747055b8fa..1dca09964b 100644
> --- a/meta/classes/systemd.bbclass
> +++ b/meta/classes/systemd.bbclass
> @@ -231,5 +231,6 @@ python rm_sysvinit_initddir (){
>
> do_install[postfuncs] += "${RMINITDIR} "
> RMINITDIR_class-target = " rm_sysvinit_initddir rm_systemd_unitdir "
> +RMINITDIR_class-nativesdk = " rm_sysvinit_initddir rm_systemd_unitdir "
> RMINITDIR = ""
>
Forgot to put you guys on the original cc list. I tested this out with
systemd and sysvinit in DISTRO_FEATURES with nativesdk-dnf because I was
having issues with nativesdk-clang building. Switching between the two I
did not see a rebuild of anything, so I think we're good to go.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds
2019-09-27 15:07 [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds Trevor Gamblin
2019-09-27 15:10 ` Trevor Gamblin
@ 2019-10-08 14:04 ` Trevor Gamblin
1 sibling, 0 replies; 3+ messages in thread
From: Trevor Gamblin @ 2019-10-08 14:04 UTC (permalink / raw)
To: openembedded-core
On 9/27/19 11:07 AM, Trevor Gamblin wrote:
> From: Trevor Gamblin <trevor.gamblin@windriver.com>
>
> nativesdk builds such as nativesdk-dnf are installing systemd
> service files, leading bitbake to throw installed-vs-shipped
> warnings, but these are not needed in nativesdk:
>
> WARNING: nativesdk-dnf-4.2.2-r0 do_package: QA Issue: nativesdk-dnf: Files/directories were installed but not shipped in any package:
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-makecache.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-download.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-notifyonly.service
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.timer
> /usr/local/oecore-x86_64/sysroots/x86_64-oesdk-linux/lib/systemd/system/dnf-automatic-install.service
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> nativesdk-dnf: 13 installed and not shipped files. [installed-vs-shipped]
>
> Rather than have each recipe remove the files, an RMINITDIR case
> for nativesdk builds should be added to systemd.bbclass.
>
> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> ---
> meta/classes/systemd.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
> index 747055b8fa..1dca09964b 100644
> --- a/meta/classes/systemd.bbclass
> +++ b/meta/classes/systemd.bbclass
> @@ -231,5 +231,6 @@ python rm_sysvinit_initddir (){
>
> do_install[postfuncs] += "${RMINITDIR} "
> RMINITDIR_class-target = " rm_sysvinit_initddir rm_systemd_unitdir "
> +RMINITDIR_class-nativesdk = " rm_sysvinit_initddir rm_systemd_unitdir "
> RMINITDIR = ""
>
Anything holding this one back?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-08 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-27 15:07 [PATCH] systemd.bbclass: add RMINITDIR for nativesdk builds Trevor Gamblin
2019-09-27 15:10 ` Trevor Gamblin
2019-10-08 14:04 ` Trevor Gamblin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox