* Re: [PATCH] kernel-fitimage.bbclass: Check value of UBOOT_SIGN_ENABLE
From: Nathan Rossi @ 2016-11-23 5:29 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <20161021120728.22639-1-nathan@nathanrossi.com>
Just pinging these patches, to see if there were any issues or
comments. I realize I sent them just before a release so it was very
likely they would get lost in the noise.
Thanks,
Nathan
On 21 October 2016 at 22:07, Nathan Rossi <nathan@nathanrossi.com> wrote:
> Check the value of UBOOT_SIGN_ENABLE, as it is defaulted to "0" which
> for matches as True in python due to being a non-empty string.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/classes/kernel-fitimage.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 8580247f82..3bbf91f65a 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -26,7 +26,7 @@ python __anonymous () {
> # Verified boot will sign the fitImage and append the public key to
> # U-boot dtb. We ensure the U-Boot dtb is deployed before assembling
> # the fitImage:
> - if d.getVar('UBOOT_SIGN_ENABLE', True):
> + if d.getVar('UBOOT_SIGN_ENABLE', True) == "1":
> uboot_pn = d.getVar('PREFERRED_PROVIDER_u-boot', True) or 'u-boot'
> d.appendVarFlag('do_assemble_fitimage', 'depends', ' %s:do_deploy' % uboot_pn)
> }
> --
> 2.9.3
^ permalink raw reply
* Re: [PATCH] kernel-fitimage.bbclass: Allow unset load/entry addresses for ramdisks
From: Nathan Rossi @ 2016-11-23 5:29 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <20161021120728.22639-2-nathan@nathanrossi.com>
Just pinging these patches, to see if there were any issues or
comments. I realize I sent them just before a release so it was very
likely they would get lost in the noise.
Thanks,
Nathan
On 21 October 2016 at 22:07, Nathan Rossi <nathan@nathanrossi.com> wrote:
> Allow the load and entry addresses to remain unset if the UBOOT_RD_*
> variables are also unset for ramdisk entries in the image tree. This
> allows for U-Boot to decide dynamically where to load the ramdisk.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/classes/kernel-fitimage.bbclass | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 3bbf91f65a..5c9e76b9ac 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -178,6 +178,15 @@ EOF
> fitimage_emit_section_ramdisk() {
>
> ramdisk_csum="sha1"
> + ramdisk_loadline=""
> + ramdisk_entryline=""
> +
> + if [ -n "${UBOOT_RD_LOADADDRESS}" ]; then
> + ramdisk_loadline="load = <${UBOOT_RD_LOADADDRESS}>;"
> + fi
> + if [ -n "${UBOOT_RD_ENTRYPOINT}" ]; then
> + ramdisk_entryline="entry = <${UBOOT_RD_ENTRYPOINT}>;"
> + fi
>
> cat << EOF >> ${1}
> ramdisk@${2} {
> @@ -187,8 +196,8 @@ fitimage_emit_section_ramdisk() {
> arch = "${UBOOT_ARCH}";
> os = "linux";
> compression = "none";
> - load = <${UBOOT_RD_LOADADDRESS}>;
> - entry = <${UBOOT_RD_ENTRYPOINT}>;
> + ${ramdisk_loadline}
> + ${ramdisk_entryline}
> hash@1 {
> algo = "${ramdisk_csum}";
> };
> --
> 2.9.3
^ permalink raw reply
* Re: [PATCH] kernel-fitimage.bbclass: Don't assume KERNEL_IMAGETYPE == fitImage
From: Nathan Rossi @ 2016-11-23 5:28 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <20161021120728.22639-3-nathan@nathanrossi.com>
Just pinging these patches, to see if there were any issues or
comments. I realize I sent them just before a release so it was very
likely they would get lost in the noise.
Thanks,
Nathan
On 21 October 2016 at 22:07, Nathan Rossi <nathan@nathanrossi.com> wrote:
> The name of the output image for a fitImage that contains a ramdisk
> should match the same as for the fitImage that does not contain a
> ramdisk. As such it should not be assumed that KERNEL_IMAGETYPE is
> "fitImage". This change explicitly sets the name of the output
> ramdisk/initramfs to start with fitImage as does the non-ramdisk output.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/classes/kernel-fitimage.bbclass | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 5c9e76b9ac..55529b161f 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -419,11 +419,11 @@ kernel_do_deploy_append() {
>
> if [ -n "${INITRAMFS_IMAGE}" ]; then
> echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..."
> - its_initramfs_base_name="${KERNEL_IMAGETYPE}-its-${INITRAMFS_IMAGE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> - its_initramfs_symlink_name=${KERNEL_IMAGETYPE}-its-${INITRAMFS_IMAGE}-${MACHINE}
> + its_initramfs_base_name="fitImage-its-${INITRAMFS_IMAGE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> + its_initramfs_symlink_name=fitImage-its-${INITRAMFS_IMAGE}-${MACHINE}
> install -m 0644 fit-image-${INITRAMFS_IMAGE}.its ${DEPLOYDIR}/${its_initramfs_base_name}.its
> - fit_initramfs_base_name="${KERNEL_IMAGETYPE}-${INITRAMFS_IMAGE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> - fit_initramfs_symlink_name=${KERNEL_IMAGETYPE}-${INITRAMFS_IMAGE}-${MACHINE}
> + fit_initramfs_base_name="fitImage-${INITRAMFS_IMAGE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> + fit_initramfs_symlink_name=fitImage-${INITRAMFS_IMAGE}-${MACHINE}
> install -m 0644 arch/${ARCH}/boot/fitImage-${INITRAMFS_IMAGE} ${DEPLOYDIR}/${fit_initramfs_base_name}.bin
> fi
>
> --
> 2.9.3
^ permalink raw reply
* Re: [PATCH 1/1] gdb-cross: depends on flex-native and bison-native
From: Khem Raj @ 2016-11-23 3:38 UTC (permalink / raw)
To: Yuanjie Huang; +Cc: openembedded-core
In-Reply-To: <0bb2fa3a-66ee-4fd7-100c-e990dd507a1d@windriver.com>
are they regenerating code during configure ?
> On Nov 22, 2016, at 7:22 PM, Yuanjie Huang <yuanjie.huang@windriver.com> wrote:
>
> Hi Raj,
>
> We observed gdb/ada-lex.l is processed by flex while gdb/c-exp.y, gdb/f-exp.y, gdb/go-exp.y and many others are handled by bison. Basically, all language-specific codes in gdb are generated.
>
> Best,
> Yuanjie
>
> On 11/23/2016 11:05 AM, Khem Raj wrote:
>>> On Nov 22, 2016, at 6:00 PM, Yuanjie Huang <Yuanjie.Huang@windriver.com> wrote:
>>>
>>> From: Yuanjie Huang <yuanjie.huang@windriver.com>
>>>
>>> Some source code of gdb is generated with flex or bison. Make both
>>> dependencies, to avoid compilation failure on host without them.
>>
>> can you find out which parts those are ? what is it trying to do to need flex/yacc
>>> Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com>
>>> ---
>>> meta/recipes-devtools/gdb/gdb-cross.inc | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
>>> index 5fa7c33..a34223e 100644
>>> --- a/meta/recipes-devtools/gdb/gdb-cross.inc
>>> +++ b/meta/recipes-devtools/gdb/gdb-cross.inc
>>> @@ -1,6 +1,6 @@
>>> require gdb-common.inc
>>>
>>> -DEPENDS = "expat-native ncurses-native"
>>> +DEPENDS = "expat-native ncurses-native flex-native bison-native"
>>>
>>> inherit python3native
>>>
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply
* Re: [PATCH 1/1] gdb-cross: depends on flex-native and bison-native
From: Yuanjie Huang @ 2016-11-23 3:22 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
In-Reply-To: <7CEAD313-1930-44C6-92A5-29E922A3485A@gmail.com>
Hi Raj,
We observed gdb/ada-lex.l is processed by flex while gdb/c-exp.y,
gdb/f-exp.y, gdb/go-exp.y and many others are handled by bison.
Basically, all language-specific codes in gdb are generated.
Best,
Yuanjie
On 11/23/2016 11:05 AM, Khem Raj wrote:
>> On Nov 22, 2016, at 6:00 PM, Yuanjie Huang <Yuanjie.Huang@windriver.com> wrote:
>>
>> From: Yuanjie Huang <yuanjie.huang@windriver.com>
>>
>> Some source code of gdb is generated with flex or bison. Make both
>> dependencies, to avoid compilation failure on host without them.
>
> can you find out which parts those are ? what is it trying to do to need flex/yacc
>> Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com>
>> ---
>> meta/recipes-devtools/gdb/gdb-cross.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
>> index 5fa7c33..a34223e 100644
>> --- a/meta/recipes-devtools/gdb/gdb-cross.inc
>> +++ b/meta/recipes-devtools/gdb/gdb-cross.inc
>> @@ -1,6 +1,6 @@
>> require gdb-common.inc
>>
>> -DEPENDS = "expat-native ncurses-native"
>> +DEPENDS = "expat-native ncurses-native flex-native bison-native"
>>
>> inherit python3native
>>
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply
* [PATCH 1/1] grub/grub-efi: fix conflict
From: Hongxu Jia @ 2016-11-23 3:17 UTC (permalink / raw)
To: openembedded-core, ross.burton
In-Reply-To: <cover.1479871002.git.hongxu.jia@windriver.com>
While installing grub and grub-efi, there are conflict files
in ${sysconfdir} ${datadir} ${bindir} ${sbindir}.
Debian use a common package grub-common for both of pc bios and efi,
and use package grub-pc-bin for pc bios, grub-efi-amd64-bin for efi.
Both of grub-pc-bin and grub-efi-amd64-bin requires grub-common.
https://packages.debian.org/sid/grub-common
https://packages.debian.org/jessie/grub-pc-bin
https://packages.debian.org/jessie/grub-efi-amd64-bin
Fedora use a common package grub2-tools for both of pc bios and efi,
and use package grub2 for pc bios, grub2-efi-modules for efi.
Both of grub2 and grub2-efi-modules requires grub2-tools.
https://www.rpmfind.net/linux/RPM/fedora/devel/rawhide/x86_64/g/grub2-tools-2.02-0.34.fc24.x86_64.html
https://www.rpmfind.net/linux/RPM/fedora/devel/rawhide/x86_64/g/grub2-2.02-0.34.fc24.x86_64.html
https://www.rpmfind.net/linux/RPM/fedora/devel/rawhide/x86_64/g/grub2-efi-modules-2.02-0.34.fc24.x86_64.html
For OE, we use a common package grub-common for both of pc bios and efi,
and use package grub for pc bios, grub-efi for efi.
Both of grubc and grub-efi runtime depends grub-common.
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
meta/recipes-bsp/grub/grub-efi_2.00.bb | 12 +++++++++---
meta/recipes-bsp/grub/grub2.inc | 4 ----
meta/recipes-bsp/grub/grub_2.00.bb | 18 +++++++++++-------
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb b/meta/recipes-bsp/grub/grub-efi_2.00.bb
index 5a0dc95..72983da 100644
--- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
+++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
@@ -1,7 +1,7 @@
require grub2.inc
DEPENDS_class-target = "grub-efi-native"
-RDEPENDS_${PN}_class-target = "diffutils freetype"
+RDEPENDS_${PN}_class-target = "diffutils freetype grub-common"
PR = "r3"
SRC_URI += " \
@@ -44,6 +44,13 @@ do_install_class-native() {
install -m 755 grub-mkimage ${D}${bindir}
}
+do_install_append_class-target(){
+ # Remove duplicated
+ for dir in ${sysconfdir} ${datadir} ${bindir} ${sbindir}; do
+ rm -rf ${D}$dir
+ done
+}
+
GRUB_BUILDIN ?= "boot linux ext2 fat serial part_msdos part_gpt normal efi_gop iso9660 search"
do_deploy() {
@@ -61,8 +68,7 @@ do_deploy_class-native() {
addtask deploy after do_install before do_build
-FILES_${PN} += "${libdir}/grub/${GRUB_TARGET}-efi \
- ${datadir}/grub \
+FILES_${PN} = "${libdir}/grub/${GRUB_TARGET}-efi \
"
BBCLASSEXTEND = "native"
diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc
index b10f633..1bb7b84 100644
--- a/meta/recipes-bsp/grub/grub2.inc
+++ b/meta/recipes-bsp/grub/grub2.inc
@@ -64,7 +64,3 @@ do_configure_prepend() {
( cd ${S}
${S}/autogen.sh )
}
-
-# grub and grub-efi's sysroot/${datadir}/grub/grub-mkconfig_lib are
-# conflicted, remove it since no one uses it.
-SYSROOT_DIRS_BLACKLIST += "${datadir}/grub/grub-mkconfig_lib"
diff --git a/meta/recipes-bsp/grub/grub_2.00.bb b/meta/recipes-bsp/grub/grub_2.00.bb
index 07e1d10..7bfece0 100644
--- a/meta/recipes-bsp/grub/grub_2.00.bb
+++ b/meta/recipes-bsp/grub/grub_2.00.bb
@@ -1,6 +1,8 @@
require grub2.inc
-RDEPENDS_${PN} = "diffutils freetype grub-editenv"
+RDEPENDS_${PN} = "diffutils freetype ${PN}-common"
+RDEPENDS_${PN}-common = "${PN}-editenv"
+
PR = "r1"
EXTRA_OECONF = "--with-platform=pc --disable-grub-mkfont --program-prefix="" \
@@ -8,13 +10,15 @@ EXTRA_OECONF = "--with-platform=pc --disable-grub-mkfont --program-prefix="" \
EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '--enable-largefile', '--disable-largefile', d)}"
-PACKAGES =+ "grub-editenv"
-
-FILES_grub-editenv = "${bindir}/grub-editenv"
+PACKAGES =+ "${PN}-editenv ${PN}-common"
-do_install_append () {
- install -d ${D}${sysconfdir}/grub.d
-}
+FILES_${PN}-editenv = "${bindir}/grub-editenv"
+FILES_${PN}-common = " \
+ ${bindir} \
+ ${sysconfdir} \
+ ${sbindir} \
+ ${datadir}/grub \
+"
INSANE_SKIP_${PN} = "arch"
INSANE_SKIP_${PN}-dbg = "arch"
--
2.8.1
^ permalink raw reply related
* [PATCH 0/1] grub/grub-efi: fix conflict
From: Hongxu Jia @ 2016-11-23 3:17 UTC (permalink / raw)
To: openembedded-core, ross.burton
The following changes since commit 43e652f3d1fee5ce7fad67e6400315eab1b34270:
devtool: add "rename" subcommand (2016-11-07 11:04:22 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib hongxu/fix-grub
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=hongxu/fix-grub
Hongxu Jia (1):
grub/grub-efi: fix conflict
meta/recipes-bsp/grub/grub-efi_2.00.bb | 12 +++++++++---
meta/recipes-bsp/grub/grub2.inc | 4 ----
meta/recipes-bsp/grub/grub_2.00.bb | 18 +++++++++++-------
3 files changed, 20 insertions(+), 14 deletions(-)
--
2.8.1
^ permalink raw reply
* Re: [PATCH 1/1] gdb-cross: depends on flex-native and bison-native
From: Khem Raj @ 2016-11-23 3:05 UTC (permalink / raw)
To: Yuanjie Huang; +Cc: openembedded-core
In-Reply-To: <20161123020049.22482-1-Yuanjie.Huang@windriver.com>
> On Nov 22, 2016, at 6:00 PM, Yuanjie Huang <Yuanjie.Huang@windriver.com> wrote:
>
> From: Yuanjie Huang <yuanjie.huang@windriver.com>
>
> Some source code of gdb is generated with flex or bison. Make both
> dependencies, to avoid compilation failure on host without them.
can you find out which parts those are ? what is it trying to do to need flex/yacc
>
> Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com>
> ---
> meta/recipes-devtools/gdb/gdb-cross.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
> index 5fa7c33..a34223e 100644
> --- a/meta/recipes-devtools/gdb/gdb-cross.inc
> +++ b/meta/recipes-devtools/gdb/gdb-cross.inc
> @@ -1,6 +1,6 @@
> require gdb-common.inc
>
> -DEPENDS = "expat-native ncurses-native"
> +DEPENDS = "expat-native ncurses-native flex-native bison-native"
>
> inherit python3native
>
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply
* [PATCH 1/1] gdb-cross: depends on flex-native and bison-native
From: Yuanjie Huang @ 2016-11-23 2:00 UTC (permalink / raw)
To: openembedded-core
From: Yuanjie Huang <yuanjie.huang@windriver.com>
Some source code of gdb is generated with flex or bison. Make both
dependencies, to avoid compilation failure on host without them.
Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com>
---
meta/recipes-devtools/gdb/gdb-cross.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
index 5fa7c33..a34223e 100644
--- a/meta/recipes-devtools/gdb/gdb-cross.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross.inc
@@ -1,6 +1,6 @@
require gdb-common.inc
-DEPENDS = "expat-native ncurses-native"
+DEPENDS = "expat-native ncurses-native flex-native bison-native"
inherit python3native
--
2.7.4
^ permalink raw reply related
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
From: Manjukumar Harthikote Matha @ 2016-11-22 23:36 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
In-Reply-To: <6c654497-ceec-07d6-7e6e-2e7d06486880@gmail.com>
On 11/22/2016 03:36 PM, Khem Raj wrote:
>
>
> On 11/22/16 3:08 PM, Manjukumar Harthikote Matha wrote:
>> Hi Khem,
>>
>> On 11/22/2016 02:03 PM, Khem Raj wrote:
>>> This is ok for master
>> Is there a particular reason not have in Morty? We have arm-trusted-firmware
>> failing to build due to this issue. I have submitted a patch to master as well
>
> Once its in master, it should get into morty subsequently.
Ok thanks for clarification :)
>
>>
>> Thanks
>> Manju
>>
>>>
>>>
>>> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>>>
>>> There was bug with alignment frags for aarch64 in binutils. This is
>>> fixed in master of binutils. This patch backports the fix to binutils
>>> 2.27 version.
>>>
>>> Signed-off-by: Manjukumar Matha
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
>>> <mailto:nathan@nathanrossi.com>>
>>> ---
>>> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
>>> ...eration-of-alignment-frags-in-code-sectio.patch | 139
>>> +++++++++++++++++++++
>>> 2 files changed, 140 insertions(+)
>>> create mode 100644
>>>
>>> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>>
>>> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> b/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> index fc81721..90518bf 100644
>>> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
>>> @@ -37,6 +37,7 @@ SRC_URI = "\
>>> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>>>
>>> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>>>
>>> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
>>> +
>>> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>> \
>>> "
>>> S = "${WORKDIR}/git"
>>>
>>> diff --git
>>>
>>> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>>
>>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>> new file mode 100644
>>> index 0000000..f8b46be
>>> --- /dev/null
>>> +++
>>>
>>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>>
>>> @@ -0,0 +1,139 @@
>>> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
>>> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>>> +Date: Fri, 18 Nov 2016 11:42:48 -0800
>>> +Subject: [PATCH] Fix the generation of alignment frags in code
>>> sections for AArch64.
>>> +
>>> +PR gas/20364
>>> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
>>> +aligning the frag.
>>> +(aarch64_init): Treat rs_align frags in code sections as
>>> +containing code, not data.
>>> +* testsuite/gas/aarch64/pr20364.s: New test.
>>> +* testsuite/gas/aarch64/pr20364.d: New test driver.
>>> +
>>> +Backporting the patch from binutils mainline
>>>
>>> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
>>>
>>>
>>> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
>>>
>>> +
>>> +Upstream-Status: Backport
>>> +
>>> +Signed-off-by: Manjukumar Matha
>>> <manjukumar.harthikote-matha@xilinx.com
>>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>>> +---
>>> + gas/ChangeLog | 10 ++++++++++
>>> + gas/config/tc-aarch64.c | 10 +++++++---
>>> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
>>> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
>>> + 4 files changed, 58 insertions(+), 3 deletions(-)
>>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
>>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
>>> +
>>> +diff --git a/gas/ChangeLog b/gas/ChangeLog
>>> +index a39895a..fad06dc 100644
>>> +--- a/gas/ChangeLog
>>> ++++ b/gas/ChangeLog
>>> +@@ -1,3 +1,13 @@
>>> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>>> ++
>>> ++ PR gas/20364
>>> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
>>> ++ aligning the frag.
>>> ++ (aarch64_init): Treat rs_align frags in code sections as
>>> ++ containing code, not data.
>>> ++ * testsuite/gas/aarch64/pr20364.s: New test.
>>> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
>>> ++
>>> + 2016-08-03 Tristan Gingold <gingold@adacore.com
>>> <mailto:gingold@adacore.com>>
>>> +
>>> + * configure: Regenerate.
>>> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
>>> +index ddc40f2..74933cb 100644
>>> +--- a/gas/config/tc-aarch64.c
>>> ++++ b/gas/config/tc-aarch64.c
>>> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
>>> + if (pool == NULL || pool->symbol == NULL ||
>>> pool->next_free_entry == 0)
>>> + continue;
>>> +
>>> +- mapping_state (MAP_DATA);
>>> +-
>>> + /* Align pool as you have word accesses.
>>> + Only make a frag if we have to. */
>>> + if (!need_pass_2)
>>> + frag_align (align, 0, 0);
>>> +
>>> ++ mapping_state (MAP_DATA);
>>> ++
>>> + record_alignment (now_seg, align);
>>> +
>>> + sprintf (sym_name, "$$lit_\002%x", pool->id);
>>> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
>>> max_chars)
>>> +
>>> + switch (fragP->fr_type)
>>> + {
>>> +- case rs_align:
>>> + case rs_align_test:
>>> + case rs_fill:
>>> + mapping_state_2 (MAP_DATA, max_chars);
>>> + break;
>>> ++ case rs_align:
>>> ++ /* PR 20364: We can get alignment frags in code sections,
>>> ++ so do not just assume that we should use the MAP_DATA
>>> state. */
>>> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
>>> MAP_DATA, max_chars);
>>> ++ break;
>>> + case rs_align_code:
>>> + mapping_state_2 (MAP_INSN, max_chars);
>>> + break;
>>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
>>> b/gas/testsuite/gas/aarch64/pr20364.d
>>> +new file mode 100644
>>> +index 0000000..babcff1
>>> +--- /dev/null
>>> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
>>> +@@ -0,0 +1,13 @@
>>> ++# Check that ".align <size>, <fill>" does not set the mapping
>>> state to DATA, causing unnecessary frag generation.
>>> ++#name: PR20364
>>> ++#objdump: -d
>>> ++
>>> ++.*: file format .*
>>> ++
>>> ++Disassembly of section \.vectors:
>>> ++
>>> ++0+000 <.*>:
>>> ++ 0: d2800000 mov x0, #0x0 // #0
>>> ++ 4: 94000000 bl 0 <plat_report_exception>
>>> ++ 8: 17fffffe b 0 <bl1_exceptions>
>>> ++
>>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
>>> b/gas/testsuite/gas/aarch64/pr20364.s
>>> +new file mode 100644
>>> +index 0000000..594ad7c
>>> +--- /dev/null
>>> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
>>> +@@ -0,0 +1,28 @@
>>> ++ .macro vector_base label
>>> ++ .section .vectors, "ax"
>>> ++ .align 11, 0
>>> ++ \label:
>>> ++ .endm
>>> ++
>>> ++ .macro vector_entry label
>>> ++ .section .vectors, "ax"
>>> ++ .align 7, 0
>>> ++ \label:
>>> ++ .endm
>>> ++
>>> ++ .macro check_vector_size since
>>> ++ .if (. - \since) > (32 * 4)
>>> ++ .error "Vector exceeds 32 instructions"
>>> ++ .endif
>>> ++ .endm
>>> ++
>>> ++ .globl bl1_exceptions
>>> ++
>>> ++vector_base bl1_exceptions
>>> ++
>>> ++vector_entry SynchronousExceptionSP0
>>> ++ mov x0, #0x0
>>> ++ bl plat_report_exception
>>> ++ b SynchronousExceptionSP0
>>> ++ check_vector_size SynchronousExceptionSP0
>>> ++
>>> +--
>>> +2.7.4
>>> +
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> <mailto:Openembedded-core@lists.openembedded.org>
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>>
>
^ permalink raw reply
* Re: Contents of non-rootfs partitions
From: Khem Raj @ 2016-11-22 23:45 UTC (permalink / raw)
To: Kristian Amlie, openembedded-core
In-Reply-To: <a90e8685-f087-5ee2-888b-aa537ebd94c4@mender.io>
[-- Attachment #1.1: Type: text/plain, Size: 1842 bytes --]
On 11/22/16 1:05 AM, Kristian Amlie wrote:
> Hey
>
> In Mender we are using a dual rootfs partition layout (A/B layout) with a persistent data partition on the side. We're using wic to do the actual image building.
>
> However, putting files into this data partition is not a straightforward operation ATM. All recipes in OE put files into the rootfs only, and we'd like there to be a way to specify that files should go into the data partition.
>
> I haven't seen any straightforward way to do this in OE. Some suggestions for how it could be done:
>
> * A "DATA_FILES" variable (like "IMAGE_BOOT_FILES"), where you can list files you'd like to be included. This is very straightforward, but has the disadvantage of being a bit hairy when paths are involved, and it doesn't allow for much logic.
>
> * Keep a special "data" directory, something similar to sysroot, where recipes could install files into in order to have it included on the data partition. We could potentially have a bbclass for use in recipes to make this more streamlined.
>
Firstly, it needs to be defined what the data partition is about.
1. is it some pre-initialized/seeded data that can then be modified during
subsequent boots ?
2. Is it read-only data which is then used to populate r/w data segments in
RAM during boot
3. is it data that does not change over the course of install and reboots of
the device
> * Have a special recipe that users can bbappend, which specifically install to the data partition (this might also need a "data" directory, like above).
>
> It's also possible that this should be generalized further so that it doesn't only apply to a data partition, but to any non-rootfs partition.
>
> I'm willing to invest some time in this, but I thought I'd gather some opinions first.
>
> Thoughts?
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
From: Khem Raj @ 2016-11-22 23:36 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
In-Reply-To: <220ac38a-b960-6a9a-84f1-f9a58c936537@xilinx.com>
[-- Attachment #1.1: Type: text/plain, Size: 8864 bytes --]
On 11/22/16 3:08 PM, Manjukumar Harthikote Matha wrote:
> Hi Khem,
>
> On 11/22/2016 02:03 PM, Khem Raj wrote:
>> This is ok for master
> Is there a particular reason not have in Morty? We have arm-trusted-firmware
> failing to build due to this issue. I have submitted a patch to master as well
Once its in master, it should get into morty subsequently.
>
> Thanks
> Manju
>
>>
>>
>> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>>
>> There was bug with alignment frags for aarch64 in binutils. This is
>> fixed in master of binutils. This patch backports the fix to binutils
>> 2.27 version.
>>
>> Signed-off-by: Manjukumar Matha
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
>> <mailto:nathan@nathanrossi.com>>
>> ---
>> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
>> ...eration-of-alignment-frags-in-code-sectio.patch | 139
>> +++++++++++++++++++++
>> 2 files changed, 140 insertions(+)
>> create mode 100644
>>
>> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
>> b/meta/recipes-devtools/binutils/binutils-2.27.inc
>> index fc81721..90518bf 100644
>> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
>> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
>> @@ -37,6 +37,7 @@ SRC_URI = "\
>> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>>
>> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>>
>> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
>> +
>> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>> \
>> "
>> S = "${WORKDIR}/git"
>>
>> diff --git
>>
>> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>>
>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>> new file mode 100644
>> index 0000000..f8b46be
>> --- /dev/null
>> +++
>>
>> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>>
>> @@ -0,0 +1,139 @@
>> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
>> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>> +Date: Fri, 18 Nov 2016 11:42:48 -0800
>> +Subject: [PATCH] Fix the generation of alignment frags in code
>> sections for AArch64.
>> +
>> +PR gas/20364
>> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> +aligning the frag.
>> +(aarch64_init): Treat rs_align frags in code sections as
>> +containing code, not data.
>> +* testsuite/gas/aarch64/pr20364.s: New test.
>> +* testsuite/gas/aarch64/pr20364.d: New test driver.
>> +
>> +Backporting the patch from binutils mainline
>>
>> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
>>
>>
>> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
>>
>> +
>> +Upstream-Status: Backport
>> +
>> +Signed-off-by: Manjukumar Matha
>> <manjukumar.harthikote-matha@xilinx.com
>> <mailto:manjukumar.harthikote-matha@xilinx.com>>
>> +---
>> + gas/ChangeLog | 10 ++++++++++
>> + gas/config/tc-aarch64.c | 10 +++++++---
>> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
>> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
>> + 4 files changed, 58 insertions(+), 3 deletions(-)
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
>> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
>> +
>> +diff --git a/gas/ChangeLog b/gas/ChangeLog
>> +index a39895a..fad06dc 100644
>> +--- a/gas/ChangeLog
>> ++++ b/gas/ChangeLog
>> +@@ -1,3 +1,13 @@
>> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
>> ++
>> ++ PR gas/20364
>> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
>> ++ aligning the frag.
>> ++ (aarch64_init): Treat rs_align frags in code sections as
>> ++ containing code, not data.
>> ++ * testsuite/gas/aarch64/pr20364.s: New test.
>> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
>> ++
>> + 2016-08-03 Tristan Gingold <gingold@adacore.com
>> <mailto:gingold@adacore.com>>
>> +
>> + * configure: Regenerate.
>> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
>> +index ddc40f2..74933cb 100644
>> +--- a/gas/config/tc-aarch64.c
>> ++++ b/gas/config/tc-aarch64.c
>> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
>> + if (pool == NULL || pool->symbol == NULL ||
>> pool->next_free_entry == 0)
>> + continue;
>> +
>> +- mapping_state (MAP_DATA);
>> +-
>> + /* Align pool as you have word accesses.
>> + Only make a frag if we have to. */
>> + if (!need_pass_2)
>> + frag_align (align, 0, 0);
>> +
>> ++ mapping_state (MAP_DATA);
>> ++
>> + record_alignment (now_seg, align);
>> +
>> + sprintf (sym_name, "$$lit_\002%x", pool->id);
>> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
>> max_chars)
>> +
>> + switch (fragP->fr_type)
>> + {
>> +- case rs_align:
>> + case rs_align_test:
>> + case rs_fill:
>> + mapping_state_2 (MAP_DATA, max_chars);
>> + break;
>> ++ case rs_align:
>> ++ /* PR 20364: We can get alignment frags in code sections,
>> ++ so do not just assume that we should use the MAP_DATA
>> state. */
>> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
>> MAP_DATA, max_chars);
>> ++ break;
>> + case rs_align_code:
>> + mapping_state_2 (MAP_INSN, max_chars);
>> + break;
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
>> b/gas/testsuite/gas/aarch64/pr20364.d
>> +new file mode 100644
>> +index 0000000..babcff1
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
>> +@@ -0,0 +1,13 @@
>> ++# Check that ".align <size>, <fill>" does not set the mapping
>> state to DATA, causing unnecessary frag generation.
>> ++#name: PR20364
>> ++#objdump: -d
>> ++
>> ++.*: file format .*
>> ++
>> ++Disassembly of section \.vectors:
>> ++
>> ++0+000 <.*>:
>> ++ 0: d2800000 mov x0, #0x0 // #0
>> ++ 4: 94000000 bl 0 <plat_report_exception>
>> ++ 8: 17fffffe b 0 <bl1_exceptions>
>> ++
>> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
>> b/gas/testsuite/gas/aarch64/pr20364.s
>> +new file mode 100644
>> +index 0000000..594ad7c
>> +--- /dev/null
>> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
>> +@@ -0,0 +1,28 @@
>> ++ .macro vector_base label
>> ++ .section .vectors, "ax"
>> ++ .align 11, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro vector_entry label
>> ++ .section .vectors, "ax"
>> ++ .align 7, 0
>> ++ \label:
>> ++ .endm
>> ++
>> ++ .macro check_vector_size since
>> ++ .if (. - \since) > (32 * 4)
>> ++ .error "Vector exceeds 32 instructions"
>> ++ .endif
>> ++ .endm
>> ++
>> ++ .globl bl1_exceptions
>> ++
>> ++vector_base bl1_exceptions
>> ++
>> ++vector_entry SynchronousExceptionSP0
>> ++ mov x0, #0x0
>> ++ bl plat_report_exception
>> ++ b SynchronousExceptionSP0
>> ++ check_vector_size SynchronousExceptionSP0
>> ++
>> +--
>> +2.7.4
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> <mailto:Openembedded-core@lists.openembedded.org>
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
From: Manjukumar Harthikote Matha @ 2016-11-22 23:08 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
In-Reply-To: <CAMKF1spiS9_qTRf2_01rVRTfwKLoZ+WDYm7Hy4_Dr5On7eDLXw@mail.gmail.com>
Hi Khem,
On 11/22/2016 02:03 PM, Khem Raj wrote:
> This is ok for master
Is there a particular reason not have in Morty? We have
arm-trusted-firmware failing to build due to this issue. I have
submitted a patch to master as well
Thanks
Manju
>
>
> On Nov 22, 2016 1:31 PM, "Manjukumar Matha"
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
>
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com
> <mailto:nathan@nathanrossi.com>>
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644
> meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
> b/meta/recipes-devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
>
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
>
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
> +
> file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git
> a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code
> sections for AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
> <https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca>
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha
> <manjukumar.harthikote-matha@xilinx.com
> <mailto:manjukumar.harthikote-matha@xilinx.com>>
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com <mailto:nickc@redhat.com>>
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com
> <mailto:gingold@adacore.com>>
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL ||
> pool->next_free_entry == 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int
> max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA
> state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN :
> MAP_DATA, max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping
> state to DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
^ permalink raw reply
* Re: [PATCH] module.bbclass: allow to override location of Module.symvers
From: Denys Dmytriyenko @ 2016-11-22 22:33 UTC (permalink / raw)
To: André Draszik; +Cc: openembedded-core
In-Reply-To: <20161121093713.7220-1-git@andred.net>
On Mon, Nov 21, 2016 at 09:37:13AM +0000, André Draszik wrote:
> From: André Draszik <adraszik@tycoint.com>
>
> Requiring all build systems for external kernel modules to
> place Module.symvers directly into ${B}/. is quite an
> artificial assumption/requirement. It doesn't have to end
> up there, but could easily end up somewhere below ${B}.
>
> Allow to override the location below ${B}
>
> Note that we still don't make use of multiple
> Module.symvers in case there are any generated by one
> single kernel module build, but this is no change in
> behaviour from before and could be added if there really
> is a demand for that.
>
> Reported-by: Denys Dmytriyenko <denis@denix.org>
> Signed-off-by: André Draszik <adraszik@tycoint.com>
Looks good to me, thanks.
Acked-by: Denys Dmytriyenko <denys@ti.com>
> ---
> meta/classes/module.bbclass | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
[...]
> - install -d -m0755 ${D}${includedir}/${BPN}
> - cp -a --no-preserve=ownership ${B}/Module.symvers ${D}${includedir}/${BPN}
> - # it doesn't actually seem to matter which path is specified here
> - sed -e 's:${B}/::g' -i ${D}${includedir}/${BPN}/Module.symvers
> + if [ ! -e "${B}/${MODULES_MODULE_SYMVERS_LOCATION}/Module.symvers" ] ; then
> + bbwarn "Module.symvers not found in ${B}/${MODULES_MODULE_SYMVERS_LOCATION}"
> + bbwarn "Please consider setting MODULES_MODULE_SYMVERS_LOCATION to a"
> + bbwarn "directory below B to get correct inter-module dependencies"
> + else
> + install -Dm0644 "${B}/${MODULES_MODULE_SYMVERS_LOCATION}"/Module.symvers ${D}${includedir}/${BPN}/Module.symvers
BTW, is "-Dm0644" portable?
> + # Module.symvers contains absolute path to the build directory.
> + # While it doesn't actually seem to matter which path is specified,
> + # clear them out to avoid confusion
> + sed -e 's:${B}/::g' -i ${D}${includedir}/${BPN}/Module.symvers
> + fi
^ permalink raw reply
* Re: [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
From: Khem Raj @ 2016-11-22 22:03 UTC (permalink / raw)
To: Manjukumar Harthikote Matha
Cc: Patches and discussions about the oe-core layer
In-Reply-To: <1479848501-5451-1-git-send-email-manjukumar.harthikote-matha@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 6938 bytes --]
This is ok for master
On Nov 22, 2016 1:31 PM, "Manjukumar Matha" <
manjukumar.harthikote-matha@xilinx.com> wrote:
> There was bug with alignment frags for aarch64 in binutils. This is
> fixed in master of binutils. This patch backports the fix to binutils
> 2.27 version.
>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
> ...eration-of-alignment-frags-in-code-sectio.patch | 139
> +++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc
> b/meta/recipes-devtools/binutils/binutils-2.27.inc
> index fc81721..90518bf 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.27.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
> @@ -37,6 +37,7 @@ SRC_URI = "\
> file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
> file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch
> \
> file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch
> \
> + file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
> \
> "
> S = "${WORKDIR}/git"
>
> diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> b/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> new file mode 100644
> index 0000000..f8b46be
> --- /dev/null
> +++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-
> the-generation-of-alignment-frags-in-code-sectio.patch
> @@ -0,0 +1,139 @@
> +From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
> +From: Nick Clifton <nickc@redhat.com>
> +Date: Fri, 18 Nov 2016 11:42:48 -0800
> +Subject: [PATCH] Fix the generation of alignment frags in code sections
> for AArch64.
> +
> +PR gas/20364
> +* config/tc-aarch64.c (s_ltorg): Change the mapping state after
> +aligning the frag.
> +(aarch64_init): Treat rs_align frags in code sections as
> +containing code, not data.
> +* testsuite/gas/aarch64/pr20364.s: New test.
> +* testsuite/gas/aarch64/pr20364.d: New test driver.
> +
> +Backporting the patch from binutils mainline
> +https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=
> 7ea12e5c3ad54da440c08f32da09534e63e515ca
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> +---
> + gas/ChangeLog | 10 ++++++++++
> + gas/config/tc-aarch64.c | 10 +++++++---
> + gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
> + gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
> + 4 files changed, 58 insertions(+), 3 deletions(-)
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
> + create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
> +
> +diff --git a/gas/ChangeLog b/gas/ChangeLog
> +index a39895a..fad06dc 100644
> +--- a/gas/ChangeLog
> ++++ b/gas/ChangeLog
> +@@ -1,3 +1,13 @@
> ++2016-08-05 Nick Clifton <nickc@redhat.com>
> ++
> ++ PR gas/20364
> ++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
> ++ aligning the frag.
> ++ (aarch64_init): Treat rs_align frags in code sections as
> ++ containing code, not data.
> ++ * testsuite/gas/aarch64/pr20364.s: New test.
> ++ * testsuite/gas/aarch64/pr20364.d: New test driver.
> ++
> + 2016-08-03 Tristan Gingold <gingold@adacore.com>
> +
> + * configure: Regenerate.
> +diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> +index ddc40f2..74933cb 100644
> +--- a/gas/config/tc-aarch64.c
> ++++ b/gas/config/tc-aarch64.c
> +@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
> + if (pool == NULL || pool->symbol == NULL || pool->next_free_entry
> == 0)
> + continue;
> +
> +- mapping_state (MAP_DATA);
> +-
> + /* Align pool as you have word accesses.
> + Only make a frag if we have to. */
> + if (!need_pass_2)
> + frag_align (align, 0, 0);
> +
> ++ mapping_state (MAP_DATA);
> ++
> + record_alignment (now_seg, align);
> +
> + sprintf (sym_name, "$$lit_\002%x", pool->id);
> +@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int max_chars)
> +
> + switch (fragP->fr_type)
> + {
> +- case rs_align:
> + case rs_align_test:
> + case rs_fill:
> + mapping_state_2 (MAP_DATA, max_chars);
> + break;
> ++ case rs_align:
> ++ /* PR 20364: We can get alignment frags in code sections,
> ++ so do not just assume that we should use the MAP_DATA state. */
> ++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN : MAP_DATA,
> max_chars);
> ++ break;
> + case rs_align_code:
> + mapping_state_2 (MAP_INSN, max_chars);
> + break;
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.d
> b/gas/testsuite/gas/aarch64/pr20364.d
> +new file mode 100644
> +index 0000000..babcff1
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.d
> +@@ -0,0 +1,13 @@
> ++# Check that ".align <size>, <fill>" does not set the mapping state to
> DATA, causing unnecessary frag generation.
> ++#name: PR20364
> ++#objdump: -d
> ++
> ++.*: file format .*
> ++
> ++Disassembly of section \.vectors:
> ++
> ++0+000 <.*>:
> ++ 0: d2800000 mov x0, #0x0 // #0
> ++ 4: 94000000 bl 0 <plat_report_exception>
> ++ 8: 17fffffe b 0 <bl1_exceptions>
> ++
> +diff --git a/gas/testsuite/gas/aarch64/pr20364.s
> b/gas/testsuite/gas/aarch64/pr20364.s
> +new file mode 100644
> +index 0000000..594ad7c
> +--- /dev/null
> ++++ b/gas/testsuite/gas/aarch64/pr20364.s
> +@@ -0,0 +1,28 @@
> ++ .macro vector_base label
> ++ .section .vectors, "ax"
> ++ .align 11, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro vector_entry label
> ++ .section .vectors, "ax"
> ++ .align 7, 0
> ++ \label:
> ++ .endm
> ++
> ++ .macro check_vector_size since
> ++ .if (. - \since) > (32 * 4)
> ++ .error "Vector exceeds 32 instructions"
> ++ .endif
> ++ .endm
> ++
> ++ .globl bl1_exceptions
> ++
> ++vector_base bl1_exceptions
> ++
> ++vector_entry SynchronousExceptionSP0
> ++ mov x0, #0x0
> ++ bl plat_report_exception
> ++ b SynchronousExceptionSP0
> ++ check_vector_size SynchronousExceptionSP0
> ++
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 8740 bytes --]
^ permalink raw reply
* [PATCH] binutils-2.27.inc: Fix alignment frags for aarch64
From: Manjukumar Matha @ 2016-11-22 21:00 UTC (permalink / raw)
To: openembedded-core
There was bug with alignment frags for aarch64 in binutils. This is
fixed in master of binutils. This patch backports the fix to binutils
2.27 version.
Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
...eration-of-alignment-frags-in-code-sectio.patch | 139 +++++++++++++++++++++
2 files changed, 140 insertions(+)
create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-devtools/binutils/binutils-2.27.inc
index fc81721..90518bf 100644
--- a/meta/recipes-devtools/binutils/binutils-2.27.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
@@ -37,6 +37,7 @@ SRC_URI = "\
file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
+ file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch \
"
S = "${WORKDIR}/git"
diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
new file mode 100644
index 0000000..f8b46be
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
@@ -0,0 +1,139 @@
+From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
+From: Nick Clifton <nickc@redhat.com>
+Date: Fri, 18 Nov 2016 11:42:48 -0800
+Subject: [PATCH] Fix the generation of alignment frags in code sections for AArch64.
+
+PR gas/20364
+* config/tc-aarch64.c (s_ltorg): Change the mapping state after
+aligning the frag.
+(aarch64_init): Treat rs_align frags in code sections as
+containing code, not data.
+* testsuite/gas/aarch64/pr20364.s: New test.
+* testsuite/gas/aarch64/pr20364.d: New test driver.
+
+Backporting the patch from binutils mainline
+https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
+
+Upstream-Status: Backport
+
+Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
+---
+ gas/ChangeLog | 10 ++++++++++
+ gas/config/tc-aarch64.c | 10 +++++++---
+ gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
+ gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
+ 4 files changed, 58 insertions(+), 3 deletions(-)
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
+
+diff --git a/gas/ChangeLog b/gas/ChangeLog
+index a39895a..fad06dc 100644
+--- a/gas/ChangeLog
++++ b/gas/ChangeLog
+@@ -1,3 +1,13 @@
++2016-08-05 Nick Clifton <nickc@redhat.com>
++
++ PR gas/20364
++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
++ aligning the frag.
++ (aarch64_init): Treat rs_align frags in code sections as
++ containing code, not data.
++ * testsuite/gas/aarch64/pr20364.s: New test.
++ * testsuite/gas/aarch64/pr20364.d: New test driver.
++
+ 2016-08-03 Tristan Gingold <gingold@adacore.com>
+
+ * configure: Regenerate.
+diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
+index ddc40f2..74933cb 100644
+--- a/gas/config/tc-aarch64.c
++++ b/gas/config/tc-aarch64.c
+@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
+ if (pool == NULL || pool->symbol == NULL || pool->next_free_entry == 0)
+ continue;
+
+- mapping_state (MAP_DATA);
+-
+ /* Align pool as you have word accesses.
+ Only make a frag if we have to. */
+ if (!need_pass_2)
+ frag_align (align, 0, 0);
+
++ mapping_state (MAP_DATA);
++
+ record_alignment (now_seg, align);
+
+ sprintf (sym_name, "$$lit_\002%x", pool->id);
+@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int max_chars)
+
+ switch (fragP->fr_type)
+ {
+- case rs_align:
+ case rs_align_test:
+ case rs_fill:
+ mapping_state_2 (MAP_DATA, max_chars);
+ break;
++ case rs_align:
++ /* PR 20364: We can get alignment frags in code sections,
++ so do not just assume that we should use the MAP_DATA state. */
++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN : MAP_DATA, max_chars);
++ break;
+ case rs_align_code:
+ mapping_state_2 (MAP_INSN, max_chars);
+ break;
+diff --git a/gas/testsuite/gas/aarch64/pr20364.d b/gas/testsuite/gas/aarch64/pr20364.d
+new file mode 100644
+index 0000000..babcff1
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.d
+@@ -0,0 +1,13 @@
++# Check that ".align <size>, <fill>" does not set the mapping state to DATA, causing unnecessary frag generation.
++#name: PR20364
++#objdump: -d
++
++.*: file format .*
++
++Disassembly of section \.vectors:
++
++0+000 <.*>:
++ 0: d2800000 mov x0, #0x0 // #0
++ 4: 94000000 bl 0 <plat_report_exception>
++ 8: 17fffffe b 0 <bl1_exceptions>
++
+diff --git a/gas/testsuite/gas/aarch64/pr20364.s b/gas/testsuite/gas/aarch64/pr20364.s
+new file mode 100644
+index 0000000..594ad7c
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.s
+@@ -0,0 +1,28 @@
++ .macro vector_base label
++ .section .vectors, "ax"
++ .align 11, 0
++ \label:
++ .endm
++
++ .macro vector_entry label
++ .section .vectors, "ax"
++ .align 7, 0
++ \label:
++ .endm
++
++ .macro check_vector_size since
++ .if (. - \since) > (32 * 4)
++ .error "Vector exceeds 32 instructions"
++ .endif
++ .endm
++
++ .globl bl1_exceptions
++
++vector_base bl1_exceptions
++
++vector_entry SynchronousExceptionSP0
++ mov x0, #0x0
++ bl plat_report_exception
++ b SynchronousExceptionSP0
++ check_vector_size SynchronousExceptionSP0
++
+--
+2.7.4
+
--
2.7.4
^ permalink raw reply related
* Re: [PATCH v3 09/11] wic: selftest: add tests for --fixed-size partition flags
From: Maciej Borzęcki @ 2016-11-22 21:31 UTC (permalink / raw)
To: Burton, Ross; +Cc: Paul Eggleton, Maciej Borzecki, OE-core
In-Reply-To: <CAD4b0_JOLmdGF+ufTkn2V_ANiLUkxZHzWqvACT4ptUEtKGZUnQ@mail.gmail.com>
On Tue, Nov 22, 2016 at 4:02 PM, Maciej Borzęcki
<maciej.borzecki@rndity.com> wrote:
> On Tue, Nov 22, 2016 at 3:47 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> On 15 November 2016 at 09:52, Maciej Borzecki <maciej.borzecki@rndity.com>
>> wrote:
>>>
>>> wic has a new flag for setting a fixed parition size --fixed-size. Add
>>> tests that verify if partition is indeed sized properly and that errors
>>> are signaled when there is not enough space to fit partition data.
>>
>>
>> Just failed on the AB:
>>
>> FAIL: test_fixed_size (oeqa.selftest.wic.Wic)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>> File
>> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/wic.py",
>> line 418, in test_fixed_size
>> self.assertEqual(0, res.status)
>> AssertionError: 0 != 127
>>
>> Might be useful to print res.output in the failure. :)
>>
>
> A bit weird. The test failed on this:
>
> # verify partition size with wic
> res = runCmd("parted -m %s unit mib p 2>/dev/null" % wicimg,
> ignore_status=True)
> self.assertEqual(0, res.status)
>
> So the image is there. It was listed by glob(), which is a directly
> before runing parted. Also wic has built it (because the test would have
> failed even earlier). However, when parted gets there, it either fails
> to understand `unit mib p` (unlikely), or the disk image is just not
> there anymore.
>
> Is there a chance these tests are run in parallel?
>
Nevermind. I have incorrectly assumed that runCmd() sets up PATH in a
way that enables running *-native tools. However, the tests ended up
host parted binary rather than the one built by parted-native. Worked
fine on my Fedora based build systems where parted is installed by
default.
I will post a v4 of the series (just the patches that are not in master
yet).
Cheers,
--
Maciej Borzecki
RnDity
^ permalink raw reply
* [PATCH][Morty] binutils-2.27.inc: Fix alignment frags for aarch64
From: Manjukumar Matha @ 2016-11-22 21:01 UTC (permalink / raw)
To: openembedded-core
There was bug with alignment frags for aarch64 in binutils. This is
fixed in master of binutils. This patch backports the fix to binutils
2.27 version.
Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
meta/recipes-devtools/binutils/binutils-2.27.inc | 1 +
...eration-of-alignment-frags-in-code-sectio.patch | 139 +++++++++++++++++++++
2 files changed, 140 insertions(+)
create mode 100644 meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
diff --git a/meta/recipes-devtools/binutils/binutils-2.27.inc b/meta/recipes-devtools/binutils/binutils-2.27.inc
index fc81721..90518bf 100644
--- a/meta/recipes-devtools/binutils/binutils-2.27.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.27.inc
@@ -37,6 +37,7 @@ SRC_URI = "\
file://0015-binutils-mips-gas-pic-relax-linkonce.diff \
file://0015-Refine-.cfi_sections-check-to-only-consider-compact-.patch \
file://0016-Fix-seg-fault-in-ARM-linker-when-trying-to-parse-a-b.patch \
+ file://0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch \
"
S = "${WORKDIR}/git"
diff --git a/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
new file mode 100644
index 0000000..f8b46be
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils/0017-Fix-the-generation-of-alignment-frags-in-code-sectio.patch
@@ -0,0 +1,139 @@
+From 4a4286465b5d6c28968bc2b29ae08daca7f219a3 Mon Sep 17 00:00:00 2001
+From: Nick Clifton <nickc@redhat.com>
+Date: Fri, 18 Nov 2016 11:42:48 -0800
+Subject: [PATCH] Fix the generation of alignment frags in code sections for AArch64.
+
+PR gas/20364
+* config/tc-aarch64.c (s_ltorg): Change the mapping state after
+aligning the frag.
+(aarch64_init): Treat rs_align frags in code sections as
+containing code, not data.
+* testsuite/gas/aarch64/pr20364.s: New test.
+* testsuite/gas/aarch64/pr20364.d: New test driver.
+
+Backporting the patch from binutils mainline
+https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ea12e5c3ad54da440c08f32da09534e63e515ca
+
+Upstream-Status: Backport
+
+Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
+---
+ gas/ChangeLog | 10 ++++++++++
+ gas/config/tc-aarch64.c | 10 +++++++---
+ gas/testsuite/gas/aarch64/pr20364.d | 13 +++++++++++++
+ gas/testsuite/gas/aarch64/pr20364.s | 28 ++++++++++++++++++++++++++++
+ 4 files changed, 58 insertions(+), 3 deletions(-)
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.d
+ create mode 100644 gas/testsuite/gas/aarch64/pr20364.s
+
+diff --git a/gas/ChangeLog b/gas/ChangeLog
+index a39895a..fad06dc 100644
+--- a/gas/ChangeLog
++++ b/gas/ChangeLog
+@@ -1,3 +1,13 @@
++2016-08-05 Nick Clifton <nickc@redhat.com>
++
++ PR gas/20364
++ * config/tc-aarch64.c (s_ltorg): Change the mapping state after
++ aligning the frag.
++ (aarch64_init): Treat rs_align frags in code sections as
++ containing code, not data.
++ * testsuite/gas/aarch64/pr20364.s: New test.
++ * testsuite/gas/aarch64/pr20364.d: New test driver.
++
+ 2016-08-03 Tristan Gingold <gingold@adacore.com>
+
+ * configure: Regenerate.
+diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
+index ddc40f2..74933cb 100644
+--- a/gas/config/tc-aarch64.c
++++ b/gas/config/tc-aarch64.c
+@@ -1736,13 +1736,13 @@ s_ltorg (int ignored ATTRIBUTE_UNUSED)
+ if (pool == NULL || pool->symbol == NULL || pool->next_free_entry == 0)
+ continue;
+
+- mapping_state (MAP_DATA);
+-
+ /* Align pool as you have word accesses.
+ Only make a frag if we have to. */
+ if (!need_pass_2)
+ frag_align (align, 0, 0);
+
++ mapping_state (MAP_DATA);
++
+ record_alignment (now_seg, align);
+
+ sprintf (sym_name, "$$lit_\002%x", pool->id);
+@@ -6373,11 +6373,15 @@ aarch64_init_frag (fragS * fragP, int max_chars)
+
+ switch (fragP->fr_type)
+ {
+- case rs_align:
+ case rs_align_test:
+ case rs_fill:
+ mapping_state_2 (MAP_DATA, max_chars);
+ break;
++ case rs_align:
++ /* PR 20364: We can get alignment frags in code sections,
++ so do not just assume that we should use the MAP_DATA state. */
++ mapping_state_2 (subseg_text_p (now_seg) ? MAP_INSN : MAP_DATA, max_chars);
++ break;
+ case rs_align_code:
+ mapping_state_2 (MAP_INSN, max_chars);
+ break;
+diff --git a/gas/testsuite/gas/aarch64/pr20364.d b/gas/testsuite/gas/aarch64/pr20364.d
+new file mode 100644
+index 0000000..babcff1
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.d
+@@ -0,0 +1,13 @@
++# Check that ".align <size>, <fill>" does not set the mapping state to DATA, causing unnecessary frag generation.
++#name: PR20364
++#objdump: -d
++
++.*: file format .*
++
++Disassembly of section \.vectors:
++
++0+000 <.*>:
++ 0: d2800000 mov x0, #0x0 // #0
++ 4: 94000000 bl 0 <plat_report_exception>
++ 8: 17fffffe b 0 <bl1_exceptions>
++
+diff --git a/gas/testsuite/gas/aarch64/pr20364.s b/gas/testsuite/gas/aarch64/pr20364.s
+new file mode 100644
+index 0000000..594ad7c
+--- /dev/null
++++ b/gas/testsuite/gas/aarch64/pr20364.s
+@@ -0,0 +1,28 @@
++ .macro vector_base label
++ .section .vectors, "ax"
++ .align 11, 0
++ \label:
++ .endm
++
++ .macro vector_entry label
++ .section .vectors, "ax"
++ .align 7, 0
++ \label:
++ .endm
++
++ .macro check_vector_size since
++ .if (. - \since) > (32 * 4)
++ .error "Vector exceeds 32 instructions"
++ .endif
++ .endm
++
++ .globl bl1_exceptions
++
++vector_base bl1_exceptions
++
++vector_entry SynchronousExceptionSP0
++ mov x0, #0x0
++ bl plat_report_exception
++ b SynchronousExceptionSP0
++ check_vector_size SynchronousExceptionSP0
++
+--
+2.7.4
+
--
2.7.4
^ permalink raw reply related
* Re: [PATCH] sanity: removed broken compiler check
From: Andre McCurdy @ 2016-11-22 20:33 UTC (permalink / raw)
To: Enrico Scholz
Cc: Christopher Larson,
Patches and discussions about the oe-core layer
In-Reply-To: <lyk2bvn1za.fsf@ensc-virt.intern.sigma-chemnitz.de>
On Tue, Nov 22, 2016 at 4:16 AM, Enrico Scholz
<enrico.scholz@sigma-chemnitz.de> wrote:
> "Burton, Ross" <ross.burton@intel.com> writes:
>
>>> Is this check really so useful? gcc + g++ are elementary tools which can
>>> be expected.
>>
>> But they're not if BUILD_CC is overridden. For example if the host gcc is
>> actually too old/new for OE to work and BUILD_CC has been set to point at a
>> different compiler.
>
> then, you will see a '<your-gcc>: command not found' very early in the
> build and every developer knows that '<your-gcc>' could not be found.
>
> When a misconfiguration is difficulty to detect or causes hidden breakage,
> sanity checks are important.
>
> But in this case, the check causes much more harm than it tries to solve
> (it will trigger e.g. for 'gcc -m32' too).
The existing check_gcc_march() sanity test can already do a much
better job of verifying BUILD_CC than check_app_exists(). If
check_gcc_march() could be generalised (e.g. renamed check_gcc() and
updated to always confirm that BUILD_CC can successfully compile
something) then the check_app_exists() test could be safely removed.
> Enrico
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply
* Re: [PATCHv2] apt-package: Include maintenance scripts
From: Aníbal Limón @ 2016-11-22 20:26 UTC (permalink / raw)
To: Linus Wallgren, openembedded-core
In-Reply-To: <20161121205749.3306-1-linus.wallgren@scypho.com>
[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]
On 11/21/2016 02:57 PM, Linus Wallgren wrote:
> Apt can run multiple tasks daily, such as for example clean, update,
> autoclean, unattended-upgrades etc.
>
> [YOCTO #10669]
>
> Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
> index a553aa2..c17048a 100644
> --- a/meta/recipes-devtools/apt/apt-package.inc
> +++ b/meta/recipes-devtools/apt/apt-package.inc
> @@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
> ${bindir}/apt-config ${bindir}/apt-cache \
> ${libdir}/apt ${libdir}/libapt*.so.* \
> ${localstatedir} ${sysconfdir} \
> - ${libdir}/dpkg"
> + ${libdir}/dpkg \
> + ${systemd_unitdir}/system \
> + "
> FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
> FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
> ${docdir}/apt"
> FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
> FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
>
> +inherit systemd
> +
> +SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
> +
> do_install () {
> set -x
> install -d ${D}${bindir}
> @@ -75,4 +81,11 @@ do_install () {
>
> install -d ${D}${includedir}/apt-pkg/
> install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
> +
> + install -d ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
> + install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
> + install -d ${D}${sysconfdir}/cron.daily/
> + install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
> }
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* [PATCH] libpcap: Disable exposed bits of WinPCAP remote capture support
From: Fabio Berton @ 2016-11-22 18:15 UTC (permalink / raw)
To: openembedded-core
Disable bits of remote capture support inherited from the WinPCAP merge
which cause applications to fails to build if they define HAVE_REMOTE.
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
.../libpcap/libpcap/disable-remote.patch | 36 ++++++++++++++++++++++
meta/recipes-connectivity/libpcap/libpcap_1.8.1.bb | 1 +
2 files changed, 37 insertions(+)
create mode 100644 meta/recipes-connectivity/libpcap/libpcap/disable-remote.patch
diff --git a/meta/recipes-connectivity/libpcap/libpcap/disable-remote.patch b/meta/recipes-connectivity/libpcap/libpcap/disable-remote.patch
new file mode 100644
index 0000000..7e1eea6
--- /dev/null
+++ b/meta/recipes-connectivity/libpcap/libpcap/disable-remote.patch
@@ -0,0 +1,36 @@
+Disable bits of remote capture support inherited from the WinPCAP merge
+which cause applications to FTBFS if they define HAVE_REMOTE.
+
+Patch from:
+https://anonscm.debian.org/cgit/users/rfrancoise/libpcap.git/commit/?
+id=f35949969269dfdcc3549b12fade604755e1e326
+
+Upstream-Status: Pending
+
+--- a/pcap/pcap.h
++++ b/pcap/pcap.h
+@@ -506,6 +506,11 @@
+ #define MODE_STAT 1
+ #define MODE_MON 2
+
++#ifdef HAVE_REMOTE
++ /* Includes most of the public stuff that is needed for the remote capture */
++ #include <remote-ext.h>
++#endif /* HAVE_REMOTE */
++
+ #elif defined(MSDOS)
+
+ /*
+@@ -526,11 +531,6 @@
+
+ #endif /* _WIN32/MSDOS/UN*X */
+
+-#ifdef HAVE_REMOTE
+- /* Includes most of the public stuff that is needed for the remote capture */
+- #include <remote-ext.h>
+-#endif /* HAVE_REMOTE */
+-
+ #ifdef __cplusplus
+ }
+ #endif
+
diff --git a/meta/recipes-connectivity/libpcap/libpcap_1.8.1.bb b/meta/recipes-connectivity/libpcap/libpcap_1.8.1.bb
index 9072fe0..8ce18e5 100644
--- a/meta/recipes-connectivity/libpcap/libpcap_1.8.1.bb
+++ b/meta/recipes-connectivity/libpcap/libpcap_1.8.1.bb
@@ -2,6 +2,7 @@ require libpcap.inc
SRC_URI += " \
file://libpcap-pkgconfig-support.patch \
+ file://disable-remote.patch \
"
SRC_URI[md5sum] = "3d48f9cd171ff12b0efd9134b52f1447"
--
2.1.4
^ permalink raw reply related
* [PATCH][morty 2/2] Revert "epiphany: remove unnecessary libwnck3 dependency"
From: Ross Burton @ 2016-11-22 17:55 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <1479837333-18054-1-git-send-email-ross.burton@intel.com>
This version of epiphany still needs libwnck3.
This reverts commit fb5c4f181176710a4cfb3c875b5edb4e5aa5df73.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-gnome/epiphany/epiphany_3.20.3.bb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-gnome/epiphany/epiphany_3.20.3.bb b/meta/recipes-gnome/epiphany/epiphany_3.20.3.bb
index 9115892..eba480b 100644
--- a/meta/recipes-gnome/epiphany/epiphany_3.20.3.bb
+++ b/meta/recipes-gnome/epiphany/epiphany_3.20.3.bb
@@ -2,10 +2,11 @@ SUMMARY = "WebKit based web browser for GNOME"
LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes ca-certificates avahi libnotify gcr \
+DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes ca-certificates avahi libnotify gcr libwnck3 \
gsettings-desktop-schemas gnome-desktop3 libxml2-native intltool-native"
inherit gnomebase gsettings distro_features_check upstream-version-is-even
+# libwnck3 is x11 only
REQUIRED_DISTRO_FEATURES = "x11"
SRC_URI += "file://0001-yelp.m4-drop-the-check-for-itstool.patch"
@@ -21,3 +22,4 @@ do_configure_prepend() {
FILES_${PN} += "${datadir}/appdata ${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers"
RDEPENDS_${PN} = "iso-codes adwaita-icon-theme"
RRECOMMENDS_${PN} = "ca-certificates"
+
--
2.8.1
^ permalink raw reply related
* [PATCH][morty 1/2] Revert "libwnck3: remove the recipe"
From: Ross Burton @ 2016-11-22 17:55 UTC (permalink / raw)
To: openembedded-core
The epiphany in morty still needs libwnck3, so bring it back.
This reverts commit 129281e8557ec8d29ecf863675884713a3050f4b.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-gnome/libwnck/libwnck3_3.20.1.bb | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 meta/recipes-gnome/libwnck/libwnck3_3.20.1.bb
diff --git a/meta/recipes-gnome/libwnck/libwnck3_3.20.1.bb b/meta/recipes-gnome/libwnck/libwnck3_3.20.1.bb
new file mode 100644
index 0000000..fd4ef69
--- /dev/null
+++ b/meta/recipes-gnome/libwnck/libwnck3_3.20.1.bb
@@ -0,0 +1,19 @@
+SUMMARY = "Window navigation construction toolkit"
+LICENSE = "LGPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=5f30f0716dfdd0d91eb439ebec522ec2"
+
+BPN = "libwnck"
+
+SECTION = "x11/libs"
+DEPENDS = "intltool-native gtk+3 gdk-pixbuf-native libxres"
+
+PACKAGECONFIG ??= "startup-notification"
+PACKAGECONFIG[startup-notification] = "--enable-startup-notification,--disable-startup-notification,startup-notification"
+
+inherit gnomebase gobject-introspection gtk-doc
+SRC_URI[archive.md5sum] = "487938d65d4bfae1f2501052b1bd7492"
+SRC_URI[archive.sha256sum] = "1cb03716bc477058dfdf3ebfa4f534de3b13b1aa067fcd064d0b7813291cba72"
+
+inherit distro_features_check
+# libxres means x11 only
+REQUIRED_DISTRO_FEATURES = "x11"
--
2.8.1
^ permalink raw reply related
* [PATCH 1/1] scripst/runqemu: Allow to use qemu from host.
From: mariano.lopez @ 2016-11-22 17:31 UTC (permalink / raw)
To: openembedded-core
In-Reply-To: <cover.1479835741.git.mariano.lopez@linux.intel.com>
From: Mariano Lopez <mariano.lopez@linux.intel.com>
This will add support to use qemu from the running host,
with this is possible to put qemu-native in ASSUME_PROVIDED
variable.
By default it will try to get qemu from the build sysroot,
and only if it fails will try to use the host's qemu.
Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
---
scripts/runqemu | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/scripts/runqemu b/scripts/runqemu
index af25423..0a9cb94 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -906,6 +906,21 @@ class BaseConfig(object):
raise Exception("Failed to boot, QB_SYSTEM_NAME is NULL!")
qemu_bin = '%s/%s' % (self.get('STAGING_BINDIR_NATIVE'), qemu_system)
+
+ # It is possible to have qemu-native in ASSUME_PROVIDED, and it won't
+ # find QEMU in sysroot, it needs to use host's qemu.
+ if not os.path.exists(qemu_bin):
+ logger.info("QEMU binary not found in %s, trying host's QEMU" % qemu_bin)
+ for path in (os.environ['PATH'] or '').split(':'):
+ qemu_bin_tmp = os.path.join(path, qemu_system)
+ logger.info("Trying: %s" % qemu_bin_tmp)
+ if os.path.exists(qemu_bin_tmp):
+ qemu_bin = qemu_bin_tmp
+ if not os.path.isabs(qemu_bin):
+ qemu_bin = os.path.abspath(qemu_bin)
+ logger.info("Using host's QEMU: %s" % qemu_bin)
+ break
+
if not os.access(qemu_bin, os.X_OK):
raise OEPathError("No QEMU binary '%s' could be found" % qemu_bin)
--
2.7.3
^ permalink raw reply related
* Re: Loss of a wayland socket by a systemd user session
From: Tomas Novotny @ 2016-11-22 17:27 UTC (permalink / raw)
To: Daniel Díaz; +Cc: openembedded-core
In-Reply-To: <f03bba38-3ac8-ee96-b272-4db2ccdae28e@linaro.org>
Hi Daniel,
On Fri, 18 Nov 2016 20:47:05 -0600
Daniel Díaz <daniel.diaz@linaro.org> wrote:
> Hello!
>
>
> On 11/18/2016 12:12 PM, Tomas Novotny wrote:
> > I'm using weston and its 'weston-start' script shipped with oe-core (morty).
> > It works perfectly until root is logged in. The problematic path is:
> [...]
>
> We've seen that [1]. If you have PAM, you can modify weston-start to
> pass `-u root' to weston-launch [2].
>
> You can also try this systemd service unit and launch Weston directly:
> https://github.com/mrchapp/meta-96boards/commit/ac3e11e
thanks a lot, this patch works for me. It is nice that it also removes the
weston-launch. Were you thinking about upstreaming your patch?
By the way, the first fix [2] didn't work for me (although I checked it
briefly).
Thanks again,
Tomas
> Greetings!
>
> Daniel Díaz
> daniel.diaz@linaro.org
>
>
> [1] https://bugs.linaro.org/show_bug.cgi?id=2576
> [2] https://github.com/mrchapp/meta-96boards/commit/ee71b7e
>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox