Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Anders Darander <anders@chargestorm.se>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: `PR = "r0"`: Add or not to add?
Date: Wed, 31 Aug 2011 14:43:40 +0200	[thread overview]
Message-ID: <20110831124339.GA19917@chargestorm.se> (raw)
In-Reply-To: <62BBB5B2-363D-49EA-AD5D-B67123C0F908@dominion.thruhere.net>

* Koen Kooi <koen@dominion.thruhere.net> [110831 14:36]:
> Op 31 aug. 2011, om 14:27 heeft Paul Eggleton het volgende geschreven:

> > On Wednesday 31 August 2011 13:16:50 Koen Kooi wrote:
> >> Op 31-08-11 13:55, Anders Darander schreef:
> >>> To sad. It's a lot easier to remember to bump the PR, when PR actually is
> >>> in the recipe. Thus, including PR=0 will often remove one issue with
> >>> patches.
> >> 
> >> That's what review is for, no?
> > 
> > Surely you'd rather people have a better chance of getting it right the first 
> > time rather than you having to remind them for every patch? The almost 
> > insignificant burden of a PR = "r0" in each recipe seems worthwhile to me if it 
> > even helps a single person remember.

> I've found that in .dev having PR = r0 in recipes is a bigger burden
> than not having them, especially when using shared .inc files like
> xorg. And there have been enough patches where people don't get PR
> bumps right even if there's a PR already in the recipe. So I'm
> unconvinced that it makes a real difference in "getting it right".

> Even in the extreme case that every packaging patch is missing a PR
> bump that, for me,  is less annoying than issues I faced in .dev with
> PR = r0 sprinkled throughout the metadata.

Just curious (and it might convince me and others) what issues have PR =
"r0" caused in .dev?

/Anders

-- 
Anders Darander
ChargeStorm AB



  reply	other threads:[~2011-08-31 12:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 23:06 [meta-xfce] thunar-volman: Add initial recipe with version 0.6.0 Andreas Müller
2011-08-31  7:15 ` Koen Kooi
2011-08-31 10:06   ` `PR = "r0"`: Add or not to add? (was: thunar-volman: Add initial recipe with version 0.6.0) Paul Menzel
2011-08-31 10:23     ` `PR = "r0"`: Add or not to add? Koen Kooi
2011-08-31 11:45       ` Frans Meulenbroeks
2011-08-31 11:55       ` Anders Darander
2011-08-31 12:16         ` Koen Kooi
2011-08-31 12:27           ` Paul Eggleton
2011-08-31 12:33             ` Frans Meulenbroeks
2011-08-31 12:36             ` Koen Kooi
2011-08-31 12:43               ` Anders Darander [this message]
2011-08-31 13:00                 ` Koen Kooi
2011-08-31 13:19                   ` Anders Darander
2011-08-31 14:10                   ` Frans Meulenbroeks
2011-08-31 12:29           ` Anders Darander
2011-08-31 12:34           ` Otavio Salvador
2011-08-31 12:45             ` Koen Kooi
2011-08-31 13:02               ` Otavio Salvador
2011-08-31 13:30                 ` Koen Kooi
2011-08-31 13:43                   ` Otavio Salvador
2011-08-31 22:35                     ` Philip Balister
2011-09-01 10:06                       ` Frans Meulenbroeks
2011-09-05 10:22                         ` Ahsan, Noor
2011-08-31 13:49                   ` Paul Menzel
2011-08-31 14:07                     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110831124339.GA19917@chargestorm.se \
    --to=anders@chargestorm.se \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox