From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: `PR = "r0"`: Add or not to add?
Date: Wed, 31 Aug 2011 15:30:26 +0200 [thread overview]
Message-ID: <j3ld1i$l0g$1@dough.gmane.org> (raw)
In-Reply-To: <CAP9ODKrOqJ12xba98J=2PAdk7p+pK=gGO0e01wuy_xTMZjsRcg@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 31-08-11 15:02, Otavio Salvador schreef:
> On Wed, Aug 31, 2011 at 09:45, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>>> Please accept PR = "r0" on new recipes since it makes it more
>>> consistent and easy to new users.
>>
>> Consistent in what way? If you want to be consistent you need to add
>> *all* variables to the recipe and set it to their default.
>
> Not really; consistency has nothing to do with verboseness. PR is
> something we will need to change ofthen so makes sense to be in recipes.
>
> Besides, this is also on the policy
The OE classic policy maybe, not on the meta-oe policy[1].
> so or you change the policy or you follow it. Otherwise makes no sense to
> have a policy if the person who merge the patches do not follow it.
- From http://wiki.openembedded.org/index.php/Category:Policy I read:
http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
http://wiki.openembedded.org/index.php/Commit_Policy
http://wiki.openembedded.org/index.php/Commit_log_example
http://wiki.openembedded.org/index.php/Styleguide
http://wiki.openembedded.org/index.php/Versioning_Policy
And none of those say PR = r0 is wanted behaviour. OTOH it doesn't say it's
unwanted either.
regards,
Koen
[1] There is no such thing yet, what I'm doing now is following the OE-core
policies where it makes sense. If someone wants to make a draft policy for
the meta-oe layers, please do so.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOXjdyMkyGM64RGpERAoitAJ98GgMcmfgZqg0va9wQ7zMksseSsgCfS76f
f3oPFRWC3aD+EuB6AO+C1QQ=
=ahhZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-08-31 13:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 23:06 [meta-xfce] thunar-volman: Add initial recipe with version 0.6.0 Andreas Müller
2011-08-31 7:15 ` Koen Kooi
2011-08-31 10:06 ` `PR = "r0"`: Add or not to add? (was: thunar-volman: Add initial recipe with version 0.6.0) Paul Menzel
2011-08-31 10:23 ` `PR = "r0"`: Add or not to add? Koen Kooi
2011-08-31 11:45 ` Frans Meulenbroeks
2011-08-31 11:55 ` Anders Darander
2011-08-31 12:16 ` Koen Kooi
2011-08-31 12:27 ` Paul Eggleton
2011-08-31 12:33 ` Frans Meulenbroeks
2011-08-31 12:36 ` Koen Kooi
2011-08-31 12:43 ` Anders Darander
2011-08-31 13:00 ` Koen Kooi
2011-08-31 13:19 ` Anders Darander
2011-08-31 14:10 ` Frans Meulenbroeks
2011-08-31 12:29 ` Anders Darander
2011-08-31 12:34 ` Otavio Salvador
2011-08-31 12:45 ` Koen Kooi
2011-08-31 13:02 ` Otavio Salvador
2011-08-31 13:30 ` Koen Kooi [this message]
2011-08-31 13:43 ` Otavio Salvador
2011-08-31 22:35 ` Philip Balister
2011-09-01 10:06 ` Frans Meulenbroeks
2011-09-05 10:22 ` Ahsan, Noor
2011-08-31 13:49 ` Paul Menzel
2011-08-31 14:07 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j3ld1i$l0g$1@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox