Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Pascal Ouyang <xin.ouyang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0
Date: Tue, 6 Nov 2012 16:22:34 +0800	[thread overview]
Message-ID: <5098C8CA.2000103@windriver.com> (raw)
In-Reply-To: <96557201.USfTQflqlK@helios>

于 2012年11月01日 18:04, Paul Eggleton 写道:
> On Thursday 01 November 2012 09:42:46 Xin Ouyang wrote:
>> Also fix license, summary and patches.
>>
>> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
>
> These two patches should really be squashed into one - this is the convention
> we've established for importing recipes from OE-Classic (as long as "Import
> from OE-Classic" or similar is mentioned somewhere in the commit message).
>
>> --- a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
>> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
>> @@ -1,14 +1,19 @@
>> -DESCRIPTION="Network performance benchmark including tests for TCP, UDP,
>> sockets, ATM and more."
>> +SUMMARY = "A networking benchmarking tool"
>> +DESCRIPTION = "Network performance benchmark including tests for TCP, UDP,
>> sockets, ATM and more."
>> SECTION = "console/network"
>>   HOMEPAGE = "http://www.netperf.org/"
>> -LICENSE = "netperf"
>> -PR = "r3"
>> +LICENSE = "HP"
>
> There's no standard license known as "HP" so "netperf" for LICENSE is correct
> - it means it's a license specific to the netperf software package.
>
>> +LICENSE_FLAGS = "commercial"
>
> Good point - I think many would miss the non-commercial use only clause in the
> license otherwise.
>
>> +SRC_URI[md5sum] = "9654ffdfd4c4f2c93ce3733cd9ed9236"
>> +SRC_URI[sha256sum] =
>> "cd8dac710d4273d29f70e8dbd09353a6362ac58a11926e0822233c0cb230323a"
>
> I think we prefer to put these next to SRC_URI these days (or at least I do).

OK, a V2 will be sent with these fixes.

Thanks.

- Pascal

>
> Cheers,
> Paul
>


-- 
- Pascal



  reply	other threads:[~2012-11-06  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  1:42 [PATCH][meta-networking 1/2] netperf: import recipe Xin Ouyang
2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
2012-11-01 10:04   ` Paul Eggleton
2012-11-06  8:22     ` Pascal Ouyang [this message]
2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
2012-11-06  8:25   ` Pascal Ouyang
2012-11-06 15:27     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5098C8CA.2000103@windriver.com \
    --to=xin.ouyang@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox