Re: [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 01 November 2012 09:42:46 Xin Ouyang wrote:
> Also fix license, summary and patches.
> 
> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>

These two patches should really be squashed into one - this is the convention 
we've established for importing recipes from OE-Classic (as long as "Import 
from OE-Classic" or similar is mentioned somewhere in the commit message).

> --- a/meta-networking/recipes-support/netperf/netperf_2.4.4.bb
> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> @@ -1,14 +1,19 @@
> -DESCRIPTION="Network performance benchmark including tests for TCP, UDP,
> sockets, ATM and more."
> +SUMMARY = "A networking benchmarking tool"
> +DESCRIPTION = "Network performance benchmark including tests for TCP, UDP,
> sockets, ATM and more."
> SECTION = "console/network"
>  HOMEPAGE = "http://www.netperf.org/"
> -LICENSE = "netperf"
> -PR = "r3"
> +LICENSE = "HP"

There's no standard license known as "HP" so "netperf" for LICENSE is correct 
- it means it's a license specific to the netperf software package.

> +LICENSE_FLAGS = "commercial"

Good point - I think many would miss the non-commercial use only clause in the 
license otherwise.

> +SRC_URI[md5sum] = "9654ffdfd4c4f2c93ce3733cd9ed9236"
> +SRC_URI[sha256sum] =
> "cd8dac710d4273d29f70e8dbd09353a6362ac58a11926e0822233c0cb230323a"

I think we prefer to put these next to SRC_URI these days (or at least I do).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre