Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Pascal Ouyang <xin.ouyang@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH][meta-networking 1/2] netperf: import recipe
Date: Tue, 6 Nov 2012 16:25:06 +0800	[thread overview]
Message-ID: <5098C962.8000504@windriver.com> (raw)
In-Reply-To: <k708l4$3tt$2@ger.gmane.org>

于 2012年11月02日 18:52, Koen Kooi 写道:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 01-11-12 02:42, Xin Ouyang schreef:
>> Git-Url: -
>> http://git.openembedded.org/openembedded/tree/recipes/netperf/
>>
>> Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> ---
>> .../recipes-support/netperf/files/cpu_set.patch    |   24 +++++++++
>> meta-networking/recipes-support/netperf/files/init |   51
>> ++++++++++++++++++++
>
> The initscript is missing LSB headers and hardcodes $sbindir to /usr/sbin.

The hardcodes would be fixed in V2.

But I think we do not need lsb headers, since no lsb init function used 
in the initscript.

Thanks.

- Pascal

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFQk6XuMkyGM64RGpERApMQAJ0f0YMb53j54pjbXUpl7b6RCjWm7gCgrbd/
> 8Ainle5y7zDc8tFdcr9gCsQ=
> =K3FI
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


-- 
- Pascal



  reply	other threads:[~2012-11-06  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  1:42 [PATCH][meta-networking 1/2] netperf: import recipe Xin Ouyang
2012-11-01  1:42 ` [PATCH][meta-networking 2/2] netperf: uprev to 2.6.0 Xin Ouyang
2012-11-01 10:04   ` Paul Eggleton
2012-11-06  8:22     ` Pascal Ouyang
2012-11-02 10:52 ` [PATCH][meta-networking 1/2] netperf: import recipe Koen Kooi
2012-11-06  8:25   ` Pascal Ouyang [this message]
2012-11-06 15:27     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5098C962.8000504@windriver.com \
    --to=xin.ouyang@windriver.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox