* is it "addtask do_X ..." or "addtask X ..." or does it matter?
@ 2014-07-12 11:22 Robert P. J. Day
2014-07-12 20:08 ` Christopher Larson
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2014-07-12 11:22 UTC (permalink / raw)
To: OpenEmbedded Development mailing list
want to clarify the two different ways to use addtask. for example:
classes/kernel.bbclass:addtask savedefconfig after do_configure
classes/kernel.bbclass:addtask do_strip before do_sizecheck after do_kernel_link_vmlinux
classes/kernel.bbclass:addtask sizecheck before do_install after do_strip
so what is the preferred form? are they equivalent?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: is it "addtask do_X ..." or "addtask X ..." or does it matter? 2014-07-12 11:22 is it "addtask do_X ..." or "addtask X ..." or does it matter? Robert P. J. Day @ 2014-07-12 20:08 ` Christopher Larson 2014-07-12 20:25 ` Robert P. J. Day 2014-07-14 10:11 ` Robert P. J. Day 0 siblings, 2 replies; 6+ messages in thread From: Christopher Larson @ 2014-07-12 20:08 UTC (permalink / raw) To: Openembedded Discussion On Sat, Jul 12, 2014 at 4:22 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote: > want to clarify the two different ways to use addtask. for example: > > classes/kernel.bbclass:addtask savedefconfig after do_configure > classes/kernel.bbclass:addtask do_strip before do_sizecheck after > do_kernel_link_vmlinux > classes/kernel.bbclass:addtask sizecheck before do_install after do_strip > > so what is the preferred form? are they equivalent? > addtask do_strip will add a task named 'do_do_strip', afaik. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: is it "addtask do_X ..." or "addtask X ..." or does it matter? 2014-07-12 20:08 ` Christopher Larson @ 2014-07-12 20:25 ` Robert P. J. Day 2014-07-14 10:11 ` Robert P. J. Day 1 sibling, 0 replies; 6+ messages in thread From: Robert P. J. Day @ 2014-07-12 20:25 UTC (permalink / raw) To: Openembedded Discussion On Sat, 12 Jul 2014, Christopher Larson wrote: > On Sat, Jul 12, 2014 at 4:22 AM, Robert P. J. Day <rpjday@crashcourse.ca> > wrote: > > > want to clarify the two different ways to use addtask. for example: > > > > classes/kernel.bbclass:addtask savedefconfig after do_configure > > classes/kernel.bbclass:addtask do_strip before do_sizecheck after > > do_kernel_link_vmlinux > > classes/kernel.bbclass:addtask sizecheck before do_install after do_strip > > > > so what is the preferred form? are they equivalent? > > > > addtask do_strip will add a task named 'do_do_strip', afaik. well, there is definitely some of that happening in the oe-core codebase, feel free to: $ grep -r "addtask do_" * so i'm not sure what to make of that. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: is it "addtask do_X ..." or "addtask X ..." or does it matter? 2014-07-12 20:08 ` Christopher Larson 2014-07-12 20:25 ` Robert P. J. Day @ 2014-07-14 10:11 ` Robert P. J. Day 2014-07-15 0:41 ` Christopher Larson 1 sibling, 1 reply; 6+ messages in thread From: Robert P. J. Day @ 2014-07-14 10:11 UTC (permalink / raw) To: Openembedded Discussion On Sat, 12 Jul 2014, Christopher Larson wrote: > On Sat, Jul 12, 2014 at 4:22 AM, Robert P. J. Day <rpjday@crashcourse.ca> > wrote: > > > want to clarify the two different ways to use addtask. for example: > > > > classes/kernel.bbclass:addtask savedefconfig after do_configure > > classes/kernel.bbclass:addtask do_strip before do_sizecheck after > > do_kernel_link_vmlinux > > classes/kernel.bbclass:addtask sizecheck before do_install after do_strip > > > > so what is the preferred form? are they equivalent? > > > > addtask do_strip will add a task named 'do_do_strip', afaik. so is there a final opinion on the validity of doing addtask do_X ... rather than addtask X ... if what chris writes is accurate, there are some broken class and recipe files in oe-core: classes/kernel.bbclass:addtask do_strip before do_sizecheck after do_kernel_link_vmlinux classes/staging.bbclass:addtask do_populate_sysroot_setscene classes/insane.bbclass:addtask do_package_qa after do_packagedata do_package before do_build classes/insane.bbclass:addtask do_package_qa_setscene classes/package_rpm.bbclass:addtask do_package_write_rpm_setscene classes/license.bbclass:addtask do_populate_lic_setscene classes/archiver.bbclass:addtask do_ar_original after do_unpack classes/archiver.bbclass:addtask do_unpack_and_patch after do_patch classes/archiver.bbclass:addtask do_ar_patched after do_unpack_and_patch classes/archiver.bbclass:addtask do_ar_configured after do_unpack_and_patch classes/archiver.bbclass:addtask do_dumpdata classes/archiver.bbclass:addtask do_ar_recipe classes/archiver.bbclass:addtask do_deploy_archives before do_build classes/deploy.bbclass:addtask do_deploy_setscene classes/package_deb.bbclass:addtask do_package_write_deb_setscene classes/package.bbclass:addtask do_package_setscene classes/package.bbclass:addtask do_packagedata_setscene classes/package_ipk.bbclass:addtask do_package_write_ipk_setscene recipes-core/eglibc/eglibc-package.inc:addtask do_install_locale after do_install before do_populate_sysroot do_package recipes-core/base-passwd/base-passwd_3.5.29.bb:addtask do_package after do_populate_sysroot recipes-core/meta/package-index.bb:addtask do_package_index before do_build recipes-devtools/gcc/gcc-configure-common.inc:addtask do_preconfigure after do_patch before do_configure recipes-support/boost/boost.inc:addtask do_boostconfig after do_patch before do_configure surely all of the above can't be broken, can they? rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: is it "addtask do_X ..." or "addtask X ..." or does it matter? 2014-07-14 10:11 ` Robert P. J. Day @ 2014-07-15 0:41 ` Christopher Larson 2014-07-15 0:47 ` Robert P. J. Day 0 siblings, 1 reply; 6+ messages in thread From: Christopher Larson @ 2014-07-15 0:41 UTC (permalink / raw) To: Openembedded Discussion On Mon, Jul 14, 2014 at 3:11 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote: > if what chris writes is accurate, there are some broken class and > recipe files in oe-core: > > classes/kernel.bbclass:addtask do_strip before do_sizecheck after > do_kernel_link_vmlinux > classes/staging.bbclass:addtask do_populate_sysroot_setscene > classes/insane.bbclass:addtask do_package_qa after do_packagedata > do_package before do_build > classes/insane.bbclass:addtask do_package_qa_setscene > classes/package_rpm.bbclass:addtask do_package_write_rpm_setscene > classes/license.bbclass:addtask do_populate_lic_setscene > classes/archiver.bbclass:addtask do_ar_original after do_unpack > classes/archiver.bbclass:addtask do_unpack_and_patch after do_patch > classes/archiver.bbclass:addtask do_ar_patched after do_unpack_and_patch > classes/archiver.bbclass:addtask do_ar_configured after do_unpack_and_patch > classes/archiver.bbclass:addtask do_dumpdata > classes/archiver.bbclass:addtask do_ar_recipe > classes/archiver.bbclass:addtask do_deploy_archives before do_build > classes/deploy.bbclass:addtask do_deploy_setscene > classes/package_deb.bbclass:addtask do_package_write_deb_setscene > classes/package.bbclass:addtask do_package_setscene > classes/package.bbclass:addtask do_packagedata_setscene > classes/package_ipk.bbclass:addtask do_package_write_ipk_setscene > recipes-core/eglibc/eglibc-package.inc:addtask do_install_locale after > do_install before do_populate_sysroot do_package > recipes-core/base-passwd/base-passwd_3.5.29.bb:addtask do_package after > do_populate_sysroot > recipes-core/meta/package-index.bb:addtask do_package_index before > do_build > recipes-devtools/gcc/gcc-configure-common.inc:addtask do_preconfigure > after do_patch before do_configure > recipes-support/boost/boost.inc:addtask do_boostconfig after do_patch > before do_configure > > surely all of the above can't be broken, can they? > I stand corrected, looks like code in bb.build.addtask automatically adds do_ if it isn't present. We probably should pick one and fix the metadata to be consistent, however :) -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: is it "addtask do_X ..." or "addtask X ..." or does it matter? 2014-07-15 0:41 ` Christopher Larson @ 2014-07-15 0:47 ` Robert P. J. Day 0 siblings, 0 replies; 6+ messages in thread From: Robert P. J. Day @ 2014-07-15 0:47 UTC (permalink / raw) To: Openembedded Discussion On Mon, 14 Jul 2014, Christopher Larson wrote: > On Mon, Jul 14, 2014 at 3:11 AM, Robert P. J. Day <rpjday@crashcourse.ca> > wrote: > > > if what chris writes is accurate, there are some broken class and > > recipe files in oe-core: > > > > classes/kernel.bbclass:addtask do_strip before do_sizecheck after > > do_kernel_link_vmlinux > > classes/staging.bbclass:addtask do_populate_sysroot_setscene > > classes/insane.bbclass:addtask do_package_qa after do_packagedata > > do_package before do_build > > classes/insane.bbclass:addtask do_package_qa_setscene > > classes/package_rpm.bbclass:addtask do_package_write_rpm_setscene > > classes/license.bbclass:addtask do_populate_lic_setscene > > classes/archiver.bbclass:addtask do_ar_original after do_unpack > > classes/archiver.bbclass:addtask do_unpack_and_patch after do_patch > > classes/archiver.bbclass:addtask do_ar_patched after do_unpack_and_patch > > classes/archiver.bbclass:addtask do_ar_configured after do_unpack_and_patch > > classes/archiver.bbclass:addtask do_dumpdata > > classes/archiver.bbclass:addtask do_ar_recipe > > classes/archiver.bbclass:addtask do_deploy_archives before do_build > > classes/deploy.bbclass:addtask do_deploy_setscene > > classes/package_deb.bbclass:addtask do_package_write_deb_setscene > > classes/package.bbclass:addtask do_package_setscene > > classes/package.bbclass:addtask do_packagedata_setscene > > classes/package_ipk.bbclass:addtask do_package_write_ipk_setscene > > recipes-core/eglibc/eglibc-package.inc:addtask do_install_locale after > > do_install before do_populate_sysroot do_package > > recipes-core/base-passwd/base-passwd_3.5.29.bb:addtask do_package after > > do_populate_sysroot > > recipes-core/meta/package-index.bb:addtask do_package_index before > > do_build > > recipes-devtools/gcc/gcc-configure-common.inc:addtask do_preconfigure > > after do_patch before do_configure > > recipes-support/boost/boost.inc:addtask do_boostconfig after do_patch > > before do_configure > > > > surely all of the above can't be broken, can they? > > > > I stand corrected, looks like code in bb.build.addtask automatically > adds do_ if it isn't present. We probably should pick one and fix > the metadata to be consistent, however :) ah, yes, there it is: def addtask(task, before, after, d): if task[:3] != "do_": task = "do_" + task that just invites abuse, doesn't it? :-) rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-15 0:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-12 11:22 is it "addtask do_X ..." or "addtask X ..." or does it matter? Robert P. J. Day 2014-07-12 20:08 ` Christopher Larson 2014-07-12 20:25 ` Robert P. J. Day 2014-07-14 10:11 ` Robert P. J. Day 2014-07-15 0:41 ` Christopher Larson 2014-07-15 0:47 ` Robert P. J. Day
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox