From: Nikita Shubin <nikita.shubin@maquefel.me>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 4/5] lib: utils/i2c: Add minimal SiFive I2C driver
Date: Wed, 20 Oct 2021 09:51:00 +0300 [thread overview]
Message-ID: <20211020095100.6796dfff@redslave.neermore.group> (raw)
In-Reply-To: <CA+zEjCuy4vCv4UJeacXgXx1r23oDRj5E8rXK+c=LxVW+j-sSeg@mail.gmail.com>
Hello Alexandre!
On Tue, 19 Oct 2021 14:34:30 +0200
Alexandre Ghiti <alexandre.ghiti@canonical.com> wrote:
> > +static inline void sifive_i2c_setreg(struct sifive_i2c_adapter
> > *adap,
> > + int reg, u8 value)
> > +{
> > + writel(value, (volatile void *)adap->addr + reg);
> > +}
> > +
> > +static inline u8 sifive_i2c_getreg(struct sifive_i2c_adapter
> > *adap, int reg) +{
> > + return readl((volatile void *)adap->addr + reg);
> > +}
> > +
>
> reg is defined as a uint8_t in calling functions and here as an int.
Agreed.
next prev parent reply other threads:[~2021-10-20 6:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 13:19 [PATCH v2 0/5] I2C framework, reboot Unmatched via PMIC Nikita Shubin
2021-10-15 13:19 ` [PATCH v2 1/5] lib: utils/reset: add priority to gpio reset Nikita Shubin
2021-10-15 13:19 ` [PATCH v2 2/5] lib: utils/i2c: Add generic I2C configuration library Nikita Shubin
2021-10-19 12:04 ` Alexandre Ghiti
2021-10-20 6:41 ` Nikita Shubin
2021-10-20 8:19 ` Alexandre Ghiti
2021-10-15 13:19 ` [PATCH v2 3/5] lib: utils/i2c: Add simple FDT based I2C framework Nikita Shubin
2021-10-19 12:05 ` Alexandre Ghiti
2021-10-20 6:49 ` Nikita Shubin
2021-10-15 13:19 ` [PATCH v2 4/5] lib: utils/i2c: Add minimal SiFive I2C driver Nikita Shubin
2021-10-19 12:34 ` Alexandre Ghiti
2021-10-20 6:51 ` Nikita Shubin [this message]
2021-10-15 13:19 ` [PATCH v2 5/5] lib: utils/reset: Add generic da9063 reset driver Nikita Shubin
2021-10-19 12:39 ` Alexandre Ghiti
2021-10-20 7:00 ` Nikita Shubin
2021-10-20 8:33 ` Alexandre Ghiti
2021-10-20 9:00 ` Nikita Shubin
2021-10-21 4:40 ` Alexandre Ghiti
2021-10-26 8:04 ` Heinrich Schuchardt
2021-10-26 9:40 ` Heinrich Schuchardt
2021-10-26 14:17 ` Nikita Shubin
2021-11-03 7:59 ` Nikita Shubin
2021-11-03 12:07 ` Heinrich Schuchardt
2021-11-03 12:13 ` Nikita Shubin
2021-11-04 13:06 ` Anup Patel
2021-10-15 13:44 ` [PATCH v2 0/5] I2C framework, reboot Unmatched via PMIC Jessica Clarke
[not found] ` <1372921634305615@mail.yandex.ru>
[not found] ` <32095245-4C98-4C9E-9DAF-68167106A968@jrtc27.com>
2021-10-15 14:05 ` Nikita Shubin
2021-10-15 14:21 ` Jessica Clarke
2021-10-15 15:05 ` Alexandre Ghiti
2021-10-19 11:57 ` Alexandre Ghiti
2021-10-20 7:26 ` Nikita Shubin
2021-10-20 8:11 ` Alexandre Ghiti
2021-10-20 8:42 ` Nikita Shubin
2021-10-21 4:34 ` Alexandre Ghiti
2021-10-20 4:59 ` Alexandre Ghiti
2021-10-20 6:17 ` Nikita Shubin
2021-10-26 6:34 ` Alexandre Ghiti
2021-10-26 14:30 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020095100.6796dfff@redslave.neermore.group \
--to=nikita.shubin@maquefel.me \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox