[PATCH v2 5/5] lib: utils/reset: Add generic da9063 reset driver

[Nikita Shubin <nikita.shubin@maquefel.me>]

Hello Alexandre!

On Tue, 19 Oct 2021 14:39:16 +0200
Alexandre Ghiti <alexandre.ghiti@canonical.com> wrote:

> > +
> > +static const struct fdt_match da9063_reset_match[] = {
> > +       { .compatible = "da9063-reset", .data = (void *)TRUE },
> > +       { },
> > +};  
> 
> Agree with Jessica here, as per Adam, the reset as we implement it
> here should remain a board specific thing, so we should not rely on
> this device tree node. I was hoping to make something that would work
> in general for da9063 users, but no luck.
> 
> And finally I think we should listen to Adam and go for a full reset
> using the RTC, instead of the partial reset we implemented here. We
> sacrifice the RTC but anyway, it was not even exposed in the device
> tree, we should add a comment there so that people don't get surprised
> if they enable it. I will post the right sequence adapted to your
> sources soon.

Well the RTC is much more valuable than reset actually and used for
many tests.

Indeed da9063 reset can be moved totally to "platform" code, but do you
think that leaving users with hard-coded reset cutting them off from RTC
and no other possibility, other than fixing OpenSBI code in-place is
really a good option ?

With DTS approuch it can be as simple as removing the da9063-reset from
DTS file.

> 
> Thanks,
> 
> Alex
> 
> 
> > +
> > +struct fdt_reset fdt_reset_da9063 = {
> > +       .match_table = da9063_reset_match,
> > +       .init = da9063_reset_init,
> > +};
> > diff --git a/lib/utils/reset/objects.mk b/lib/utils/reset/objects.mk
> > index 6c95db3..cfe4c09 100644
> > --- a/lib/utils/reset/objects.mk
> > +++ b/lib/utils/reset/objects.mk
> > @@ -14,3 +14,4 @@ libsbiutils-objs-y +=
> > reset/fdt_reset_sifive_test.o libsbiutils-objs-y +=
> > reset/fdt_reset_sunxi_wdt.o libsbiutils-objs-y +=
> > reset/fdt_reset_thead.o libsbiutils-objs-y +=
> > reset/fdt_reset_thead_asm.o +libsbiutils-objs-y +=
> > reset/fdt_reset_da9063.o --
> > 2.31.1
> >
> >
> > --
> > opensbi mailing list
> > opensbi at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/opensbi