From: Xiang W <wxjstz@126.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 7/7] lib: sbi: Make sbi_domain_memregion_initfw() a local function
Date: Sun, 11 Apr 2021 18:07:48 +0800 [thread overview]
Message-ID: <608cf300bfbe938d12fd85598e4f0b65d939f434.camel@126.com> (raw)
In-Reply-To: <20210410071808.759856-8-anup.patel@wdc.com>
? 2021-04-10?? 12:48 +0530?Anup Patel???
> The sbi_domain_memregion_initfw() is no longer used outside
> sbi_domain.c so let's make it a local function.
>
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
looks good to me.
Reviewed-by: Xiang W <wxjstz@126.com>
Regards,
Xiang W
> ---
> include/sbi/sbi_domain.h | 3 ---
> lib/sbi/sbi_domain.c | 4 ++--
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
> index ef53ca5..3de5e46 100644
> --- a/include/sbi/sbi_domain.h
> +++ b/include/sbi/sbi_domain.h
> @@ -127,9 +127,6 @@ bool sbi_domain_is_assigned_hart(const struct
> sbi_domain *dom, u32 hartid);
> ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom,
> ulong hbase);
>
> -/** Initialize a domain memory region as firmware region */
> -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg);
> -
> /**
> * Initialize a domain memory region based on it's physical
> * address and size.
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 5e3a30d..069e2a7 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -64,7 +64,7 @@ ulong sbi_domain_get_assigned_hartmask(const struct
> sbi_domain *dom,
> return ret;
> }
>
> -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg)
> +static void domain_memregion_initfw(struct sbi_domain_memregion
> *reg)
> {
> if (!reg)
> return;
> @@ -577,7 +577,7 @@ int sbi_domain_init(struct sbi_scratch *scratch,
> u32 cold_hartid)
> /* Root domain firmware memory region */
> sbi_domain_memregion_init(scratch->fw_start, scratch->fw_size,
> 0,
> &root_fw_region);
> - sbi_domain_memregion_initfw(&root_memregs[root_memregs_count++]
> );
> + domain_memregion_initfw(&root_memregs[root_memregs_count++]);
>
> /* Root domain allow everything memory region */
> sbi_domain_memregion_init(0, ~0UL,
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-04-11 10:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 7:18 [PATCH 0/7] Protect M-mode only MMIO devices Anup Patel
2021-04-10 7:18 ` [PATCH 1/7] lib: sbi: Domains can be registered only before finalizing domains Anup Patel
2021-04-11 7:49 ` Xiang W
2021-04-11 21:19 ` Alistair Francis
2021-04-10 7:18 ` [PATCH 2/7] lib: sbi: Add sbi_domain_memregion_init() API Anup Patel
2021-04-11 7:50 ` Xiang W
2021-04-11 21:22 ` Alistair Francis
2021-04-10 7:18 ` [PATCH 3/7] lib: sbi: Add sbi_domain_root_add_memregion() API Anup Patel
2021-04-11 8:43 ` Xiang W
2021-04-11 21:27 ` Alistair Francis
2021-04-10 7:18 ` [PATCH 4/7] lib: utils/sys: Add CLINT memregion in the root domain Anup Patel
2021-04-11 9:05 ` Xiang W
2021-04-12 5:23 ` Anup Patel
2021-04-12 5:42 ` Xiang W
2021-04-12 6:24 ` Anup Patel
2021-04-10 7:18 ` [PATCH 5/7] lib: sbi: Make the root domain instance global variable Anup Patel
2021-04-11 10:07 ` Xiang W
2021-04-11 21:29 ` Alistair Francis
2021-04-10 7:18 ` [PATCH 6/7] lib: utils: Copy over restricted root domain memregions to FDT domains Anup Patel
2021-04-11 10:07 ` Xiang W
2021-04-11 21:30 ` Alistair Francis
2021-04-10 7:18 ` [PATCH 7/7] lib: sbi: Make sbi_domain_memregion_initfw() a local function Anup Patel
2021-04-11 10:07 ` Xiang W [this message]
2021-04-11 21:32 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608cf300bfbe938d12fd85598e4f0b65d939f434.camel@126.com \
--to=wxjstz@126.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox