Re: [PATCH v4 0/6] platform: generic: spacemit: add K3 platform support

From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "E Shattow" <e@freeshell.de>, <opensbi@lists.infradead.org>
Cc: "Xianbin Zhu" <xianbin.zhu@linux.spacemit.com>,
	"Anup Patel" <anup@brainfault.org>, "Bo Gan" <ganboing@gmail.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>,
	"Kevin Zhang" <zhangmeng.kevin@linux.spacemit.com>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Alvin Chang" <alvinga@andestech.com>,
	"Valentin Haudiquet" <valentin.haudiquet@canonical.com>
Subject: Re: [PATCH v4 0/6] platform: generic: spacemit: add K3 platform support
Date: Fri, 23 Oct 2026 10:42:00 +0800	[thread overview]
Message-ID: <DMBVDO4HXQW4.667LHQKG8GJ1@linux.spacemit.com> (raw)
In-Reply-To: <c4480699-3a81-4530-be59-064b8642343a@freeshell.de>

[-- Attachment #1.1: Type: text/plain, Size: 1674 bytes --]

On Wed, Oct 07, 2026 at 05:28:31PM -0700, E Shattow wrote:
> I did suggest the change to be included by the vendor as a pull request:
>
> https://github.com/spacemit-com/uboot-2022.10/pull/5
>
> However I do not expect this to be considered, as the vendor uses their
> own fork of OpenSBI.

I've already passed your PR to the team responsible for our U-Boot tree
for review.

> [...]
>
> Although I was unable boot a Linux userland from vendor 'FSBL.bin' plus
> the mainline in-development 'u-boot.itb' the Linux kernel appears mostly
> functional and does output some messages up to the point of 'init'.
> There is no dependency on any SPI NOR flash content at all, it can be
> fully erased and the 'esos' 'FSBL' 'opensbi' 'uboot' NOR flash regions
> are not involved in testing when loading in-development for mainline
> U-Boot (including mainline OpenSBI fw_dynamic.bin) 'u-boot.itb' and
> whatever SPL (currently the vendor SDK/BSP 'FSBL.bin' SPL) is required
> by that.

My COM260 test reached a shell with the SDK U-Boot and a minimal
initramfs. Could you share the full boot log, U-Boot and kernel
revisions, and the DT and kernel command line you used?

> [...]
>
> I did read through all the patches in this series for any obvious style
> problems. For the series with no endorsement of suitability for what the
> code does or how it does so, okay to apply my R-by tag (and/or
> Tested-by) and with or without any trivial style corrections as requested.

I've dropped the redundant cache-flush comment in patch 2 and used BIT()
in the K1 nascent hook in patch 3.

Thanks for the review, testing and tags.

-- 
Troy Mitchell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 105 bytes --]

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi