Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] tooloftrade: add missing subject of sentence
Date: Sun, 11 Nov 2018 09:34:17 -0800	[thread overview]
Message-ID: <20181111173417.GV4170@linux.ibm.com> (raw)
In-Reply-To: <1541854198-4649-1-git-send-email-junchangwang@gmail.com>

On Sat, Nov 10, 2018 at 08:49:58PM +0800, Junchang Wang wrote:
> 
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> ---
> Hi Paul,
> 
> This is the only patch for Chapter Tools of Trade. Please take a look.

Good catch!  I took this with Akira's suggested update as shown below,
thank you both!!!

							Thanx, Paul

-------------------------------------------------------------------------

commit 59d25618814ae5333e243f536f1295ff49a035ff
Author: Junchang Wang <junchangwang@gmail.com>
Date:   Sat Nov 10 20:49:58 2018 +0800

    tooloftrade: add missing subject of sentence
    
    Signed-off-by: Junchang Wang <junchangwang@gmail.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
    [ paulmck: Apply change suggested by Akira Yokosawa. ]

diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 0844b4c74c05..20171872e906 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -2043,8 +2043,8 @@ machine-sized and properly aligned.
 It can also prevent load fusing, store fusing, invented loads, and
 invented stores.
 However, although it does prevent the compiler from reordering \co{volatile}
-accesses with each other, does nothing to prevent the CPU from reordering
-these accesses.
+accesses with each other, it does nothing to prevent the
+CPU from reordering these accesses.
 Furthermore, it does nothing to prevent either compiler or CPU from
 reordering non-\co{volatile} accesses with each other or with
 \co{volatile} accesses.


      parent reply	other threads:[~2018-11-12  3:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 12:49 [PATCH] tooloftrade: add missing subject of sentence Junchang Wang
2018-11-10 23:55 ` Akira Yokosawa
2018-11-12  2:35   ` Junchang Wang
2018-11-11 17:34 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111173417.GV4170@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=junchangwang@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox