[PATCH] tooloftrade: add missing subject of sentence

[PATCH] tooloftrade: add missing subject of sentence

[Junchang Wang]

Signed-off-by: Junchang Wang <junchangwang@gmail.com>
---
Hi Paul,

This is the only patch for Chapter Tools of Trade. Please take a look.


Thanks,
--Junchang

--
 toolsoftrade/toolsoftrade.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 0844b4c..b4bc46a 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -2043,8 +2043,8 @@ machine-sized and properly aligned.
 It can also prevent load fusing, store fusing, invented loads, and
 invented stores.
 However, although it does prevent the compiler from reordering \co{volatile}
-accesses with each other, does nothing to prevent the CPU from reordering
-these accesses.
+accesses with each other, \co{volatile} keyword does nothing to prevent the
+CPU from reordering these accesses.
 Furthermore, it does nothing to prevent either compiler or CPU from
 reordering non-\co{volatile} accesses with each other or with
 \co{volatile} accesses.
-- 
2.7.4

Re: [PATCH] tooloftrade: add missing subject of sentence

[Akira Yokosawa]

On 2018/11/10 20:49:58 +0800, Junchang Wang wrote:
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> ---
> Hi Paul,
> 
> This is the only patch for Chapter Tools of Trade. Please take a look.
> 
> 
> Thanks,
> --Junchang
> 
> --
>  toolsoftrade/toolsoftrade.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
> index 0844b4c..b4bc46a 100644
> --- a/toolsoftrade/toolsoftrade.tex
> +++ b/toolsoftrade/toolsoftrade.tex
> @@ -2043,8 +2043,8 @@ machine-sized and properly aligned.
>  It can also prevent load fusing, store fusing, invented loads, and
>  invented stores.
>  However, although it does prevent the compiler from reordering \co{volatile}
> -accesses with each other, does nothing to prevent the CPU from reordering
> -these accesses.
> +accesses with each other, \co{volatile} keyword does nothing to prevent the
> +CPU from reordering these accesses.

In this context, I think

+accesses with each other, it does nothing to prevent the CPU from reordering
 these accesses.

should be good enough.

        Thanks, Akira

>  Furthermore, it does nothing to prevent either compiler or CPU from
>  reordering non-\co{volatile} accesses with each other or with
>  \co{volatile} accesses.
> 

Re: [PATCH] tooloftrade: add missing subject of sentence

[Junchang Wang]

On Sun, Nov 11, 2018 at 7:55 AM Akira Yokosawa <akiyks@gmail.com> wrote:
>
> On 2018/11/10 20:49:58 +0800, Junchang Wang wrote:
> > Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> > ---
> > Hi Paul,
> >
> > This is the only patch for Chapter Tools of Trade. Please take a look.
> >
> >
> > Thanks,
> > --Junchang
> >
> > --
> >  toolsoftrade/toolsoftrade.tex | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
> > index 0844b4c..b4bc46a 100644
> > --- a/toolsoftrade/toolsoftrade.tex
> > +++ b/toolsoftrade/toolsoftrade.tex
> > @@ -2043,8 +2043,8 @@ machine-sized and properly aligned.
> >  It can also prevent load fusing, store fusing, invented loads, and
> >  invented stores.
> >  However, although it does prevent the compiler from reordering \co{volatile}
> > -accesses with each other, does nothing to prevent the CPU from reordering
> > -these accesses.
> > +accesses with each other, \co{volatile} keyword does nothing to prevent the
> > +CPU from reordering these accesses.
>
> In this context, I think
>
> +accesses with each other, it does nothing to prevent the CPU from reordering
>  these accesses.
>
> should be good enough.

Hi Akira,

After reading the whole paragraph a few times, I realized you are
right :-). Thanks a lot!

--Junchang

>
>         Thanks, Akira
>
> >  Furthermore, it does nothing to prevent either compiler or CPU from
> >  reordering non-\co{volatile} accesses with each other or with
> >  \co{volatile} accesses.
> >
>

Re: [PATCH] tooloftrade: add missing subject of sentence

[Paul E. McKenney]

On Sat, Nov 10, 2018 at 08:49:58PM +0800, Junchang Wang wrote:
> 
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> ---
> Hi Paul,
> 
> This is the only patch for Chapter Tools of Trade. Please take a look.

Good catch!  I took this with Akira's suggested update as shown below,
thank you both!!!

							Thanx, Paul

-------------------------------------------------------------------------

commit 59d25618814ae5333e243f536f1295ff49a035ff
Author: Junchang Wang <junchangwang@gmail.com>
Date:   Sat Nov 10 20:49:58 2018 +0800

    tooloftrade: add missing subject of sentence
    
    Signed-off-by: Junchang Wang <junchangwang@gmail.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
    [ paulmck: Apply change suggested by Akira Yokosawa. ]

diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 0844b4c74c05..20171872e906 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -2043,8 +2043,8 @@ machine-sized and properly aligned.
 It can also prevent load fusing, store fusing, invented loads, and
 invented stores.
 However, although it does prevent the compiler from reordering \co{volatile}
-accesses with each other, does nothing to prevent the CPU from reordering
-these accesses.
+accesses with each other, it does nothing to prevent the
+CPU from reordering these accesses.
 Furthermore, it does nothing to prevent either compiler or CPU from
 reordering non-\co{volatile} accesses with each other or with
 \co{volatile} accesses.