[PATCH] acer-wmi: add Acer Extensa 5235 to video backlight vendor

[PATCH] acer-wmi: add Acer Extensa 5235 to video backlight vendor

[Lee, Chun-Yi]

From: "Lee, Chun-Yi" <jlee@suse.com>

Acer Extensa 5235 laptop have broken _BCM implemenation, the AML
code wrote value to EC register but firmware didn't change brighenss.

Fortunately, the brightness control works on those machines with vendor mode.
So, add this machine to video backlight vendor mode quirk table.

Reference: bko#42833
	https://bugzilla.kernel.org/show_bug.cgi?id=42833

Cc: Bence Lukacs <lukacs.bence1@gmail.com>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index c1a3fd8..c2a237f 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -523,6 +523,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
 		},
 	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Extensa 5235",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Extensa 5235"),
+		},
+	},
 	{}
 };
 
-- 
1.7.7

Re: [PATCH] acer-wmi: add Acer Extensa 5235 to video backlight vendor

[joeyli]

於 三，2012-04-18 於 17:01 +0800，Lee, Chun-Yi 提到：
> From: "Lee, Chun-Yi" <jlee@suse.com>
> 
> Acer Extensa 5235 laptop have broken _BCM implemenation, the AML
> code wrote value to EC register but firmware didn't change brighenss.
> 
> Fortunately, the brightness control works on those machines with vendor mode.
> So, add this machine to video backlight vendor mode quirk table.
> 
> Reference: bko#42833
> 	https://bugzilla.kernel.org/show_bug.cgi?id=42833
> 
> Cc: Bence Lukacs <lukacs.bence1@gmail.com>
> Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Thomas Renninger <trenn@suse.de>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
>  drivers/platform/x86/acer-wmi.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c1a3fd8..c2a237f 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -523,6 +523,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
>  		},
>  	},
> +	{
> +		.callback = video_set_backlight_video_vendor,
> +		.ident = "Acer Extensa 5235",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Extensa 5235"),
> +		},
> +	},
>  	{}
>  };
>  

Collected more issue machines need add to quirk table.

I just re-sent patch:
[PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk
table


Thanks
Joey Lee