From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
platform-driver-x86@vger.kernel.org,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel_pmc_core: Convert to DEFINE_DEBUGFS_ATTRIBUTE
Date: Sat, 02 Jul 2016 15:10:57 +0300 [thread overview]
Message-ID: <1467461457.30123.446.camel@linux.intel.com> (raw)
In-Reply-To: <20160701212434.GC60048@f23x64.localdomain>
On Fri, 2016-07-01 at 14:24 -0700, Darren Hart wrote:
> > > > +struct dentry;
> > > > +
> > >
> > > Why do we need this ?
> >
> > Since we are using pointer to undefined type.
>
> Erm... why is dentry an undefined type?
In this header it's undefined. Though I can't get any warning using
recent compilers, thus the change is not needed.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-07-02 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 17:56 [PATCH v1 1/1] platform/x86/intel_pmc_core: Convert to DEFINE_DEBUGFS_ATTRIBUTE Andy Shevchenko
2016-06-23 15:26 ` Rajneesh Bhardwaj
2016-06-23 16:22 ` Andy Shevchenko
2016-06-28 9:05 ` Rajneesh Bhardwaj
2016-06-28 10:05 ` Andy Shevchenko
2016-06-29 8:03 ` Rajneesh Bhardwaj
2016-06-29 11:49 ` Andy Shevchenko
2016-06-29 12:16 ` Rajneesh Bhardwaj
2016-06-29 12:48 ` Andy Shevchenko
2016-06-29 13:20 ` Rajneesh Bhardwaj
2016-06-29 13:33 ` Andy Shevchenko
2016-07-01 21:30 ` Darren Hart
2016-07-04 11:35 ` Rajneesh Bhardwaj
2016-07-04 12:01 ` Andy Shevchenko
2016-07-04 12:28 ` Rajneesh Bhardwaj
2016-07-01 21:28 ` Darren Hart
2016-07-01 21:24 ` Darren Hart
2016-07-02 12:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467461457.30123.446.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox