From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Cc: platform-driver-x86@vger.kernel.org,
Darren Hart <dvhart@infradead.org>,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel_pmc_core: Convert to DEFINE_DEBUGFS_ATTRIBUTE
Date: Mon, 04 Jul 2016 15:01:33 +0300 [thread overview]
Message-ID: <1467633693.30123.452.camel@linux.intel.com> (raw)
In-Reply-To: <20160704113518.GC1177@rajaneesh-OptiPlex-9010>
On Mon, 2016-07-04 at 17:05 +0530, Rajneesh Bhardwaj wrote:
> >
> >
> > So, if there is no objections (taking into consideration minors you
> > mentioned) I think the patch can be applied.
> >
>
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -23,6 +23,7 @@
> #include <linux/init.h>
> #include <linux/io.h>
> #include <linux/pci.h>
> +#include <linux/seq_file.h>
What is this for?
>
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
> @@ -88,7 +89,8 @@ static int pmc_core_dev_state_get(void *data, u64
> *val)
> return 0;
> }
>
> -DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get,
> NULL,
> "%llu");
> +DEFINE_DEBUGFS_ATTRIBUTE(pmc_core_dev_state, pmc_core_dev_state_get,
> NULL,
> + "%llu\n");
Okay, since debugfs is actually using them in standard code, we may add
it here as well.
> --- a/drivers/platform/x86/intel_pmc_core.h
> +++ b/drivers/platform/x86/intel_pmc_core.h
> @@ -29,7 +29,6 @@
> #define SPT_PMC_MMIO_REG_LEN 0x100
> #define SPT_PMC_SLP_S0_RES_COUNTER_STEP 0x64
>
> -struct dentry;
Agreed.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-07-04 12:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 17:56 [PATCH v1 1/1] platform/x86/intel_pmc_core: Convert to DEFINE_DEBUGFS_ATTRIBUTE Andy Shevchenko
2016-06-23 15:26 ` Rajneesh Bhardwaj
2016-06-23 16:22 ` Andy Shevchenko
2016-06-28 9:05 ` Rajneesh Bhardwaj
2016-06-28 10:05 ` Andy Shevchenko
2016-06-29 8:03 ` Rajneesh Bhardwaj
2016-06-29 11:49 ` Andy Shevchenko
2016-06-29 12:16 ` Rajneesh Bhardwaj
2016-06-29 12:48 ` Andy Shevchenko
2016-06-29 13:20 ` Rajneesh Bhardwaj
2016-06-29 13:33 ` Andy Shevchenko
2016-07-01 21:30 ` Darren Hart
2016-07-04 11:35 ` Rajneesh Bhardwaj
2016-07-04 12:01 ` Andy Shevchenko [this message]
2016-07-04 12:28 ` Rajneesh Bhardwaj
2016-07-01 21:28 ` Darren Hart
2016-07-01 21:24 ` Darren Hart
2016-07-02 12:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467633693.30123.452.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox