From: Seth Forshee <seth.forshee@canonical.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Chris Bagwell <chris@cnpbagwell.com>,
Matthew Garrett <mjg@redhat.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key
Date: Thu, 24 Mar 2011 15:09:58 -0500 [thread overview]
Message-ID: <20110324200958.GC31713@thinkpad-t410> (raw)
In-Reply-To: <1300997035-14104-2-git-send-email-seth.forshee@canonical.com>
On Thu, Mar 24, 2011 at 03:03:55PM -0500, Seth Forshee wrote:
> @@ -79,6 +94,52 @@ static const struct key_entry eeepc_wmi_keymap[] = {
> { KE_END, 0},
> };
>
> +static void eeepc_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
> + int *value, int *autorelease)
> +{
> + struct eeepc_wmi_driver *eeepc = to_eeepc_wmi_driver(asus_wmi);
> + int is_press;
> +
> + /*
> + * The following behavior is used for T101MT "Home" key:
> + *
> + * On press: No event set
> + * On hold: KEY_PROG2 press sent once w/o autorelease
> + * On release: If key was held, KEY_PROG2 release sent.
> + * Otherwise KEY_HOME press sent w/ autorelease.
Doh, just noticed that this comment is incorrect. I'll fix it, but I'll
wait for comments before sending new patches.
next prev parent reply other threads:[~2011-03-24 20:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 19:39 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24 7:33 ` Corentin Chary
[not found] ` <AANLkTinZpt8qmHzhe4WyteMt-C-nkVNwEGQVvq3Nk9Lx-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-24 13:14 ` Seth Forshee
2011-03-24 13:26 ` Corentin Chary
2011-03-24 13:27 ` Chris Bagwell
2011-03-24 13:32 ` Chris Bagwell
[not found] ` <AANLkTikrX_wypmrd-PbST603jsHqkuwtA6t5X65Lg1+O-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-24 13:37 ` Seth Forshee
2011-03-24 13:40 ` Corentin Chary
2011-03-24 14:00 ` Chris Bagwell
2011-03-24 19:57 ` Seth Forshee
2011-03-24 20:03 ` [PATCH 1/2] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-24 20:03 ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09 ` Seth Forshee [this message]
2011-03-25 13:28 ` Corentin Chary
[not found] ` <AANLkTimF2UR8BVQW-3YJaGFEz39q8ydESAiMOjmdM1X7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 13:53 ` Seth Forshee
2011-03-25 14:05 ` Corentin Chary
[not found] ` <AANLkTin3MDYdL6x1Qs8Q9oMMgDMfsoO2GjWMJO_65GAR@mail.gmail.com>
2011-03-25 14:53 ` Chris Bagwell
2011-03-25 15:13 ` Seth Forshee
2011-03-25 15:43 ` Corentin Chary
[not found] ` <AANLkTinr2FJA2H3CJWx-wZ_g-hCZ3DT7PR6QsXqi5Rkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 16:17 ` Seth Forshee
2011-03-25 16:14 ` Dmitry Torokhov
[not found] ` <20110325161405.GC5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 16:28 ` Seth Forshee
2011-03-25 17:03 ` Dmitry Torokhov
[not found] ` <20110325170333.GD5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 18:58 ` Seth Forshee
2011-03-27 17:13 ` Dmitry Torokhov
[not found] ` <20110327171304.GD30244-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-27 18:32 ` Chris Bagwell
2011-03-27 19:11 ` Dmitry Torokhov
[not found] ` <20110327191116.GB31692-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-28 13:46 ` Seth Forshee
2011-03-28 14:14 ` Corentin Chary
2011-03-25 16:07 ` [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Dmitry Torokhov
[not found] ` <20110325160702.GB5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 16:08 ` Corentin Chary
2011-03-25 16:05 ` Dmitry Torokhov
[not found] <AANLkTi=U2Qkqv7FKfe18f0a=8Xg0QwRX_cxFj-j7ZPC=@mail.gmail.com>
2011-03-28 18:33 ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
[not found] ` <1301337224-3293-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-03-29 6:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324200958.GC31713@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=chris@cnpbagwell.com \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox