X86 platform drivers
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Seth Forshee <seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: Chris Bagwell <chris-ZCD0YumhXB+iMFqZbmIluw@public.gmane.org>,
	acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Corentin Chary
	<corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key
Date: Mon, 28 Mar 2011 23:33:41 -0700	[thread overview]
Message-ID: <20110329063341.GA26490@core.coreip.homeip.net> (raw)
In-Reply-To: <1301337224-3293-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>

On Mon, Mar 28, 2011 at 01:33:41PM -0500, Seth Forshee wrote:
> On Mon, Mar 28, 2011 at 02:14:33PM +0000, Corentin Chary wrote:
> > But since Dmitry and Chris seems to prefer the autorepeat approach
> > with a single key code, if it works then it's ok, we just need to set
> > REP_DELAY, report press and release events, and drop 0xea events.
> 
> New patches follow. I didn't set REP_DELAY (or REP_PERIOD) because the
> input core interprets this to mean that the driver will handle the
> autorepeat itself. There's always EVIOCSREP to change the delay and
> repeat period from userspace.

Just an FYI: it is perfectly fine to set custom REP_DELAY and REP_PERIOD
after registering an input device.

Thanks.

-- 
Dmitry

------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar

  parent reply	other threads:[~2011-03-29  6:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTi=U2Qkqv7FKfe18f0a=8Xg0QwRX_cxFj-j7ZPC=@mail.gmail.com>
2011-03-28 18:33 ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
     [not found]   ` <1301337224-3293-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-03-28 18:33     ` [PATCH v3 1/3] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-28 18:33     ` [PATCH v3 2/3] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-29 12:29       ` Corentin Chary
2011-03-29 13:42         ` Seth Forshee
2011-03-29 13:47         ` Matthew Garrett
2011-03-30  7:46           ` Corentin Chary
2011-03-28 18:33     ` [PATCH v3 3/3] asus-wmi: Enable autorepeat for hotkey input device Seth Forshee
2011-03-29  6:33     ` Dmitry Torokhov [this message]
2011-03-24 19:57 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24 20:03 ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09   ` Seth Forshee
2011-03-25 13:28   ` Corentin Chary
     [not found]     ` <AANLkTimF2UR8BVQW-3YJaGFEz39q8ydESAiMOjmdM1X7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 13:53       ` Seth Forshee
2011-03-25 14:05         ` Corentin Chary
     [not found]         ` <AANLkTin3MDYdL6x1Qs8Q9oMMgDMfsoO2GjWMJO_65GAR@mail.gmail.com>
2011-03-25 14:53           ` Chris Bagwell
2011-03-25 15:13             ` Seth Forshee
2011-03-25 15:43             ` Corentin Chary
     [not found]               ` <AANLkTinr2FJA2H3CJWx-wZ_g-hCZ3DT7PR6QsXqi5Rkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 16:17                 ` Seth Forshee
2011-03-25 16:14           ` Dmitry Torokhov
     [not found]             ` <20110325161405.GC5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 16:28               ` Seth Forshee
2011-03-25 17:03                 ` Dmitry Torokhov
     [not found]                   ` <20110325170333.GD5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 18:58                     ` Seth Forshee
2011-03-27 17:13                       ` Dmitry Torokhov
     [not found]                         ` <20110327171304.GD30244-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-27 18:32                           ` Chris Bagwell
2011-03-27 19:11                             ` Dmitry Torokhov
     [not found]                               ` <20110327191116.GB31692-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-28 13:46                                 ` Seth Forshee
2011-03-28 14:14                                   ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329063341.GA26490@core.coreip.homeip.net \
    --to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=chris-ZCD0YumhXB+iMFqZbmIluw@public.gmane.org \
    --cc=corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox