X86 platform drivers
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Chris Bagwell <chris-ZCD0YumhXB+iMFqZbmIluw@public.gmane.org>,
	acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Corentin Chary
	<corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key
Date: Fri, 25 Mar 2011 11:28:50 -0500	[thread overview]
Message-ID: <20110325162850.GD14328@thinkpad-t410> (raw)
In-Reply-To: <20110325161405.GC5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>

On Fri, Mar 25, 2011 at 09:14:05AM -0700, Dmitry Torokhov wrote:
> > If you keep a keyboard key pressed, you want multiple events, not one right ?
> > I think it's important not to loose informations. If someone keep this
> > key pressed more than 1.5 second, I think it's good idea to send
> > multiple KEY_PROG2.
> 
> You can have input autorepeat facilities do that for you. If you want to
> do this yourself then the proper value for repeated events is _2_, not
> 1, or they will be dropped as duplicates.
> 
> > 
> > About KEY_HOME press / release, and filtering KEY_HOME after
> > KEY_PROG2, I'm not sure. So if you really want it, and nobody
> > complains, I'll be happy to accept your patch.
> > 
> > > And back to the question of KEY_HOME -- that's not really what you want,
> > > is it? As in "move cursor to start of line"?
> > 
> > Ho .. right, that's what mean KEY_HOME :/. So no, I don't want that...
> > What about:
> > - KEY_CYCLEWINDOWS
> > - KEY_COMPUTER
> > - KEY_HOMEPAGE
> > - KEY_DASHBOARD
> > 
> > I think KEY_HOMEPAGE is the best choice.
> 
> No, KEY_HOMEPAGE should cause your browser to go to your home page. What
> you want is either:
> 
> #define KEY_CONFIG         171     /* AL Consumer Control Configuration */
> #define KEY_DASHBOARD      204     /* AL Dashboard */
> 
> ("AL" stands for "Application Launcher", "AC" for 'Application Control",
> matched loosely to HUT tables).

Dmitry,

I didn't see you responses before my last response, so you can ignore
it. Let me make sure I understand correctly. For reference, the button
in question sends an 0xe4 scancode on press, repeated 0xea scancodes on
hold, and 0xe5 on release.

So, would the following make sense (KEY_TBD is may abbreviation for "key
to be determinded"):

 - On press (0xe4), send KEY_TBD, value = 1
 - On hold (0xea), send KEY_TBD, value = 2
 - On release (0xe5), send KEY_TBD, value = 0

Also, is KEY_CYCLEWINDOWS intended to imply screen rotation, or
something else?

Thanks,
Seth


------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar

  parent reply	other threads:[~2011-03-25 16:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 19:39 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24  7:33 ` Corentin Chary
     [not found]   ` <AANLkTinZpt8qmHzhe4WyteMt-C-nkVNwEGQVvq3Nk9Lx-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-24 13:14     ` Seth Forshee
2011-03-24 13:26       ` Corentin Chary
2011-03-24 13:27       ` Chris Bagwell
2011-03-24 13:32         ` Chris Bagwell
     [not found]         ` <AANLkTikrX_wypmrd-PbST603jsHqkuwtA6t5X65Lg1+O-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-24 13:37           ` Seth Forshee
2011-03-24 13:40         ` Corentin Chary
2011-03-24 14:00           ` Chris Bagwell
2011-03-24 19:57             ` Seth Forshee
2011-03-24 20:03               ` [PATCH 1/2] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-24 20:03               ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09                 ` Seth Forshee
2011-03-25 13:28                 ` Corentin Chary
     [not found]                   ` <AANLkTimF2UR8BVQW-3YJaGFEz39q8ydESAiMOjmdM1X7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 13:53                     ` Seth Forshee
2011-03-25 14:05                       ` Corentin Chary
     [not found]                       ` <AANLkTin3MDYdL6x1Qs8Q9oMMgDMfsoO2GjWMJO_65GAR@mail.gmail.com>
2011-03-25 14:53                         ` Chris Bagwell
2011-03-25 15:13                           ` Seth Forshee
2011-03-25 15:43                           ` Corentin Chary
     [not found]                             ` <AANLkTinr2FJA2H3CJWx-wZ_g-hCZ3DT7PR6QsXqi5Rkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-25 16:17                               ` Seth Forshee
2011-03-25 16:14                         ` Dmitry Torokhov
     [not found]                           ` <20110325161405.GC5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 16:28                             ` Seth Forshee [this message]
2011-03-25 17:03                               ` Dmitry Torokhov
     [not found]                                 ` <20110325170333.GD5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 18:58                                   ` Seth Forshee
2011-03-27 17:13                                     ` Dmitry Torokhov
     [not found]                                       ` <20110327171304.GD30244-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-27 18:32                                         ` Chris Bagwell
2011-03-27 19:11                                           ` Dmitry Torokhov
     [not found]                                             ` <20110327191116.GB31692-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-28 13:46                                               ` Seth Forshee
2011-03-28 14:14                                                 ` Corentin Chary
2011-03-25 16:07             ` [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Dmitry Torokhov
     [not found]               ` <20110325160702.GB5099-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2011-03-25 16:08                 ` Corentin Chary
2011-03-25 16:05         ` Dmitry Torokhov
     [not found] <AANLkTi=U2Qkqv7FKfe18f0a=8Xg0QwRX_cxFj-j7ZPC=@mail.gmail.com>
2011-03-28 18:33 ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
     [not found]   ` <1301337224-3293-1-git-send-email-seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-03-29  6:33     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110325162850.GD14328@thinkpad-t410 \
    --to=seth.forshee-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=chris-ZCD0YumhXB+iMFqZbmIluw@public.gmane.org \
    --cc=corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox