From: Dan Carpenter <dan.carpenter@oracle.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
SF Markus Elfring <elfring@users.sourceforge.net>,
Anisse Astier <anisse@astier.eu>,
Corentin Chary <corentin.chary@gmail.com>,
Ike Panhc <ike.pan@canonical.com>,
Jonathan Woithe <jwoithe@just42.net>,
Mattia Dongili <malattia@linux.it>,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()
Date: Sat, 27 Jun 2015 16:16:03 +0300 [thread overview]
Message-ID: <20150627131603.GF28762@mwanda> (raw)
In-Reply-To: <20150626230655.GB57818@vmdeb7>
On Fri, Jun 26, 2015 at 04:06:55PM -0700, Darren Hart wrote:
> Julia, do you have any particular objection to this specific patch? I didn't see
> a reason to prevent it going in.
I hate these patches...
We're saying "these functions have sanity checks so let's pass nonsense
values to them, it's fine." It makes the code harder to understand.
There is no way for a human being to remember the complete list of
functions with sanity checks and which don't have sanity checks.
Markus has introduced quite a few bugs as well (people have so far
managed to catch his bugs before they were committed). He so far has
resisted any suggestion that he should manually review his patches
before sending them.
Btw do have a scripts/coccinelle/free/ifnullfree.cocci which removes
checks before kfree, debugfs_remove, debugfs_remove_recursive, and
usb_free_urb.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-27 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-24 19:40 ` [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() SF Markus Elfring
2014-11-24 8:28 ` Darren Hart
2014-11-24 21:28 ` Anisse Astier
2014-11-24 22:12 ` SF Markus Elfring
2014-11-27 18:13 ` Julia Lawall
2015-06-26 23:06 ` Darren Hart
2015-06-27 7:07 ` Julia Lawall
2015-06-27 10:00 ` SF Markus Elfring
2015-06-27 13:16 ` Dan Carpenter [this message]
2015-06-27 18:06 ` SF Markus Elfring
2014-11-24 21:04 ` [PATCH 1/1] Sony-laptop: Deletion of an unnecessary check before the function call "pci_dev_put" SF Markus Elfring
2014-11-24 8:28 ` Darren Hart
2015-06-26 19:28 ` [PATCH] tc1100-wmi: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-06-26 23:04 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150627131603.GF28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=anisse@astier.eu \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=julia.lawall@lip6.fr \
--cc=jwoithe@just42.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox