X86 platform drivers
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Darren Hart <dvhart@infradead.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Anisse Astier <anisse@astier.eu>,
	Corentin Chary <corentin.chary@gmail.com>,
	Ike Panhc <ike.pan@canonical.com>,
	Jonathan Woithe <jwoithe@just42.net>,
	Mattia Dongili <malattia@linux.it>,
	platform-driver-x86@vger.kernel.org,
	acpi4asus-user@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: platform: x86: Deletion of checks before backlight_device_unregister()
Date: Sat, 27 Jun 2015 20:06:57 +0200	[thread overview]
Message-ID: <558EE641.7040404@users.sourceforge.net> (raw)
In-Reply-To: <20150627131603.GF28762@mwanda>

> There is no way for a human being to remember the complete list of
> functions with sanity checks and which don't have sanity checks.

I understand also this software development challenge.


> Markus has introduced quite a few bugs as well

I have only found other opinions about specific update suggestions.
Which of such "bugs" are real mistakes?
Are you looking for a better consensus?


> (people have so far managed to catch his bugs before they were committed).

Would you like to refer to any concrete software developers?


> He so far has resisted any suggestion that he should manually review
> his patches before sending them.

I am performing source code review to some degree.
My approach does partly not fit to your expectations.

Regards,
Markus

  reply	other threads:[~2015-06-27 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5307CAA2.8060406@users.sourceforge.net>
     [not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
     [not found]   ` <530A086E.8010901@users.sourceforge.net>
     [not found]     ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
     [not found]       ` <530A72AA.3000601@users.sourceforge.net>
     [not found]         ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
     [not found]           ` <530B5FB6.6010207@users.sourceforge.net>
     [not found]             ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
     [not found]               ` <530C5E18.1020800@users.sourceforge.net>
     [not found]                 ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
     [not found]                   ` <530CD2C4.4050903@users.sourceforge.net>
     [not found]                     ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
     [not found]                       ` <530CF8FF.8080600@users.sourceforge.net>
     [not found]                         ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
     [not found]                           ` <530DD06F.4090703@users.sourceforge.net>
     [not found]                             ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
     [not found]                               ` <5317A59D.4@users.sourceforge.net>
2014-11-24 19:40                                 ` [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() SF Markus Elfring
2014-11-24  8:28                                   ` Darren Hart
2014-11-24 21:28                                   ` Anisse Astier
2014-11-24 22:12                                     ` SF Markus Elfring
2014-11-27 18:13                                       ` Julia Lawall
2015-06-26 23:06                                         ` Darren Hart
2015-06-27  7:07                                           ` Julia Lawall
2015-06-27 10:00                                           ` SF Markus Elfring
2015-06-27 13:16                                           ` [PATCH 1/1] " Dan Carpenter
2015-06-27 18:06                                             ` SF Markus Elfring [this message]
2014-11-24 21:04                                 ` [PATCH 1/1] Sony-laptop: Deletion of an unnecessary check before the function call "pci_dev_put" SF Markus Elfring
2014-11-24  8:28                                   ` Darren Hart
2015-06-26 19:28                                 ` [PATCH] tc1100-wmi: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-06-26 23:04                                   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558EE641.7040404@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=anisse@astier.eu \
    --cc=corentin.chary@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dvhart@infradead.org \
    --cc=ike.pan@canonical.com \
    --cc=julia.lawall@lip6.fr \
    --cc=jwoithe@just42.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox