[PATCH v2] platform/x86: mlx-platform: fix module aliases

[PATCH v2] platform/x86: mlx-platform: fix module aliases

[Ivan Vecera]

Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is
not loaded automatically. The driver should use MODULE_DEVICE_TABLE
together with existing mlxplat_dmi_table instead.

Changes:
v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)

Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from arch/x86")
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/platform/x86/mlx-platform.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 504256c3660d..5a8b475668fb 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -370,8 +370,4 @@ module_exit(mlxplat_exit);
 MODULE_AUTHOR("Vadim Pasternak (vadimp@mellanox.com)");
 MODULE_DESCRIPTION("Mellanox platform driver");
 MODULE_LICENSE("Dual BSD/GPL");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
+MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
-- 
2.13.6

RE: [PATCH v2] platform/x86: mlx-platform: fix module aliases

[Vadim Pasternak]

> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> Sent: Monday, January 22, 2018 12:12 PM
> To: platform-driver-x86@vger.kernel.org
> Cc: Vadim Pasternak <vadimp@mellanox.com>; Bjørn Mork <bjorn@mork.no>
> Subject: [PATCH v2] platform/x86: mlx-platform: fix module aliases
> 
> Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is not loaded
> automatically. The driver should use MODULE_DEVICE_TABLE together with
> existing mlxplat_dmi_table instead.
> 
> Changes:
> v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)
> 
> Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from
> arch/x86")
> Cc: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/platform/x86/mlx-platform.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index 504256c3660d..5a8b475668fb 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -370,8 +370,4 @@ module_exit(mlxplat_exit);  MODULE_AUTHOR("Vadim
> Pasternak (vadimp@mellanox.com)");  MODULE_DESCRIPTION("Mellanox
> platform driver");  MODULE_LICENSE("Dual BSD/GPL"); -
> MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);

I am not sure about the location of MODULE_DEVICE_TABLE record.
Should it be placed at the end of the module or after mlxplat_dmi_table
declaration?


> --
> 2.13.6

Re: [PATCH v2] platform/x86: mlx-platform: fix module aliases

[Andy Shevchenko]

On Mon, Jan 22, 2018 at 12:23 PM, Vadim Pasternak <vadimp@mellanox.com> wrote:

>> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
>
> I am not sure about the location of MODULE_DEVICE_TABLE record.
> Should it be placed at the end of the module or after mlxplat_dmi_table
> declaration?

Yeah, it would be better.
I dunno if Darren is going to ask for another version or fix this
manually when apply.
To be on the safer side, send a v3 with properly attached line as
Vadim suggested.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] platform/x86: mlx-platform: fix module aliases

[Ivan Vecera]

On 22.1.2018 12:48, Andy Shevchenko wrote:
> On Mon, Jan 22, 2018 at 12:23 PM, Vadim Pasternak <vadimp@mellanox.com> wrote:
> 
>>> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
>>
>> I am not sure about the location of MODULE_DEVICE_TABLE record.
>> Should it be placed at the end of the module or after mlxplat_dmi_table
>> declaration?
> 
> Yeah, it would be better.
> I dunno if Darren is going to ask for another version or fix this
> manually when apply.
> To be on the safer side, send a v3 with properly attached line as
> Vadim suggested.
> 
Will do.

Thanks,
I.