Request for pre-review of pending MID removal patch series

Request for pre-review of pending MID removal patch series

[Andy Shevchenko]

Hi!

There is a pending patch series [1] to remove a lot of legacy code
related to old Intel MID platforms. (Note, not all of them, since we
have an ACPI based Intel Edison edition which continue working nicely
after this)

Most of the code is shuffling arch/x86 and the series is quite
dependent on the contents of that folder (for the sake of
bisectability). Since that the only way it would be integrated is
through the tip tree I would like to have your preliminary review on
other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
I won't resend this many times.

I have a preliminary offline agreement with Len Brown on SFI removal
(#2 in the list).

[1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/

-- 
With Best Regards,
Andy Shevchenko

Re: Request for pre-review of pending MID removal patch series

[Andy Shevchenko]

+Cc: Bart (sorry, forgot to include you)

On Fri, Oct 23, 2020 at 8:07 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> Hi!
>
> There is a pending patch series [1] to remove a lot of legacy code
> related to old Intel MID platforms. (Note, not all of them, since we
> have an ACPI based Intel Edison edition which continue working nicely
> after this)
>
> Most of the code is shuffling arch/x86 and the series is quite
> dependent on the contents of that folder (for the sake of
> bisectability). Since that the only way it would be integrated is
> through the tip tree I would like to have your preliminary review on
> other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> I won't resend this many times.
>
> I have a preliminary offline agreement with Len Brown on SFI removal
> (#2 in the list).
>
> [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko

Re: Request for pre-review of pending MID removal patch series

[Hans de Goede]

Hi,

On 10/23/20 7:07 PM, Andy Shevchenko wrote:
> Hi!
> 
> There is a pending patch series [1] to remove a lot of legacy code
> related to old Intel MID platforms. (Note, not all of them, since we
> have an ACPI based Intel Edison edition which continue working nicely
> after this)
> 
> Most of the code is shuffling arch/x86 and the series is quite
> dependent on the contents of that folder (for the sake of
> bisectability). Since that the only way it would be integrated is
> through the tip tree I would like to have your preliminary review on
> other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> I won't resend this many times.

The drivers/platform/x86 changes (including moving some code there)
are all fine with me. You can add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

To those.

I'm fine with this being merged through another tree. But keep
in mind that Lee Jones will likely merge the Intel PMT series
through the MFD tree soon and that touches CONFIG_INTEL_FOO
bits of drivers/platform/x86/{Kconfig,Makefile} too, so there
might be a possible conflict there.

Regards,

Hans

Re: Request for pre-review of pending MID removal patch series

[Linus Walleij]

On Fri, Oct 23, 2020 at 7:07 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:

> There is a pending patch series [1] to remove a lot of legacy code
> related to old Intel MID platforms. (Note, not all of them, since we
> have an ACPI based Intel Edison edition which continue working nicely
> after this)
>
> Most of the code is shuffling arch/x86 and the series is quite
> dependent on the contents of that folder (for the sake of
> bisectability). Since that the only way it would be integrated is
> through the tip tree I would like to have your preliminary review on
> other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> I won't resend this many times.
>
> I have a preliminary offline agreement with Len Brown on SFI removal
> (#2 in the list).
>
> [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/

The series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: Request for pre-review of pending MID removal patch series

[Andy Shevchenko]

+Cc: Mika

On Fri, Oct 23, 2020 at 8:07 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> Hi!
>
> There is a pending patch series [1] to remove a lot of legacy code
> related to old Intel MID platforms. (Note, not all of them, since we
> have an ACPI based Intel Edison edition which continue working nicely
> after this)
>
> Most of the code is shuffling arch/x86 and the series is quite
> dependent on the contents of that folder (for the sake of
> bisectability). Since that the only way it would be integrated is
> through the tip tree I would like to have your preliminary review on
> other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> I won't resend this many times.
>
> I have a preliminary offline agreement with Len Brown on SFI removal
> (#2 in the list).
>
> [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/

-- 
With Best Regards,
Andy Shevchenko

Re: Request for pre-review of pending MID removal patch series

[Mika Westerberg]

On Mon, Nov 23, 2020 at 07:59:29PM +0200, Andy Shevchenko wrote:
> +Cc: Mika
> 
> On Fri, Oct 23, 2020 at 8:07 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > Hi!
> >
> > There is a pending patch series [1] to remove a lot of legacy code
> > related to old Intel MID platforms. (Note, not all of them, since we
> > have an ACPI based Intel Edison edition which continue working nicely
> > after this)
> >
> > Most of the code is shuffling arch/x86 and the series is quite
> > dependent on the contents of that folder (for the sake of
> > bisectability). Since that the only way it would be integrated is
> > through the tip tree I would like to have your preliminary review on
> > other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> > I won't resend this many times.
> >
> > I have a preliminary offline agreement with Len Brown on SFI removal
> > (#2 in the list).
> >
> > [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/

Looks pretty good to me. I wonder it is possible to remove gma500 also
or it is used in Edison?

Re: Request for pre-review of pending MID removal patch series

[Andy Shevchenko]

On Tue, Nov 24, 2020 at 4:43 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Mon, Nov 23, 2020 at 07:59:29PM +0200, Andy Shevchenko wrote:
> > +Cc: Mika
> >
> > On Fri, Oct 23, 2020 at 8:07 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > Hi!
> > >
> > > There is a pending patch series [1] to remove a lot of legacy code
> > > related to old Intel MID platforms. (Note, not all of them, since we
> > > have an ACPI based Intel Edison edition which continue working nicely
> > > after this)
> > >
> > > Most of the code is shuffling arch/x86 and the series is quite
> > > dependent on the contents of that folder (for the sake of
> > > bisectability). Since that the only way it would be integrated is
> > > through the tip tree I would like to have your preliminary review on
> > > other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> > > I won't resend this many times.
> > >
> > > I have a preliminary offline agreement with Len Brown on SFI removal
> > > (#2 in the list).
> > >
> > > [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/
>
> Looks pretty good to me.

Thanks! Can I use your tag (which is better?) for some patches (which ones?)?

> I wonder it is possible to remove gma500 also
> or it is used in Edison?

It can be used on other platforms based on not-going-to-be-removed
Merrifield and possibly Moorefield.
Hence I would like to leave it for now.

-- 
With Best Regards,
Andy Shevchenko

Re: Request for pre-review of pending MID removal patch series

[Mika Westerberg]

On Tue, Nov 24, 2020 at 05:02:13PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 24, 2020 at 4:43 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Mon, Nov 23, 2020 at 07:59:29PM +0200, Andy Shevchenko wrote:
> > > +Cc: Mika
> > >
> > > On Fri, Oct 23, 2020 at 8:07 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
> > > >
> > > > Hi!
> > > >
> > > > There is a pending patch series [1] to remove a lot of legacy code
> > > > related to old Intel MID platforms. (Note, not all of them, since we
> > > > have an ACPI based Intel Edison edition which continue working nicely
> > > > after this)
> > > >
> > > > Most of the code is shuffling arch/x86 and the series is quite
> > > > dependent on the contents of that folder (for the sake of
> > > > bisectability). Since that the only way it would be integrated is
> > > > through the tip tree I would like to have your preliminary review on
> > > > other contents — #3 and #4 are PDx86 and GPIO subsystems. In this case
> > > > I won't resend this many times.
> > > >
> > > > I have a preliminary offline agreement with Len Brown on SFI removal
> > > > (#2 in the list).
> > > >
> > > > [1]: https://gitlab.com/andy-shev/next/-/commits/topic/mid-removal/
> >
> > Looks pretty good to me.
> 
> Thanks! Can I use your tag (which is better?) for some patches (which ones?)?

Aren't you going to submit this series for real review at some point? I
can then formally review some of the patches.

> > I wonder it is possible to remove gma500 also
> > or it is used in Edison?
> 
> It can be used on other platforms based on not-going-to-be-removed
> Merrifield and possibly Moorefield.
> Hence I would like to leave it for now.

OK.