Re: [PATCH 09/10] platform/x86/amd/pmf: Call enact function sooner to process early pending requests

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Fri, 9 May 2025, Shyam Sundar S K wrote:

> Call the amd_pmf_invoke_cmd_enact() function to manage early pending
> requests and their associated custom BIOS inputs. Additionally, add a
> return statement for cases of failure.
> 
> The PMF driver will adjust power settings according to custom BIOS inputs
> after assessing the policy conditions.
> 
> Cc: Yijun Shen <Yijun.Shen@dell.com>
> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
>  drivers/platform/x86/amd/pmf/acpi.c   | 18 ++++++++++++++++--
>  drivers/platform/x86/amd/pmf/pmf.h    |  2 ++
>  drivers/platform/x86/amd/pmf/tee-if.c |  3 ++-
>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c
> index 1521988c1002..a3319ac89fd1 100644
> --- a/drivers/platform/x86/amd/pmf/acpi.c
> +++ b/drivers/platform/x86/amd/pmf/acpi.c
> @@ -339,8 +339,15 @@ static void apmf_event_handler_v2(acpi_handle handle, u32 event, void *data)
>  	guard(mutex)(&pmf_dev->cb_mutex);
>  
>  	ret = apmf_get_sbios_requests_v2(pmf_dev, &pmf_dev->req);
> -	if (ret)
> +	if (ret) {
>  		dev_err(pmf_dev->dev, "Failed to get v2 SBIOS requests: %d\n", ret);
> +		return;
> +	}
> +
> +	if (pmf_dev->cb_flag) {
> +		amd_pmf_invoke_cmd_enact(pmf_dev);
> +		pmf_dev->cb_flag = false;
> +	}
>  }
>  
>  static void apmf_event_handler_v1(acpi_handle handle, u32 event, void *data)
> @@ -351,8 +358,15 @@ static void apmf_event_handler_v1(acpi_handle handle, u32 event, void *data)
>  	guard(mutex)(&pmf_dev->cb_mutex);
>  
>  	ret = apmf_get_sbios_requests_v1(pmf_dev, &pmf_dev->req1);
> -	if (ret)
> +	if (ret) {
>  		dev_err(pmf_dev->dev, "Failed to get v1 SBIOS requests: %d\n", ret);
> +		return;
> +	}
> +
> +	if (pmf_dev->cb_flag) {
> +		amd_pmf_invoke_cmd_enact(pmf_dev);
> +		pmf_dev->cb_flag = false;
> +	}

Why isn't there another function which can be called by both???

>  }
>  
>  static void apmf_event_handler(acpi_handle handle, u32 event, void *data)
> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
> index d9e6467be852..71cc94bdbd32 100644
> --- a/drivers/platform/x86/amd/pmf/pmf.h
> +++ b/drivers/platform/x86/amd/pmf/pmf.h
> @@ -404,6 +404,7 @@ struct amd_pmf_dev {
>  	u32 notifications;
>  	struct apmf_sbios_req_v1 req1;
>  	struct pmf_bios_inputs_prev cb_prev; /* To preserve custom BIOS inputs */
> +	bool cb_flag; /* To handle first custom BIOS input */

Please more the comment more to right, preferrably align it with the 
previous line.

>  };
>  
>  struct apmf_sps_prop_granular_v2 {
> @@ -891,5 +892,6 @@ int amd_pmf_smartpc_apply_bios_output(struct amd_pmf_dev *dev, u32 val, u32 preq
>  /* Smart PC - TA interfaces */
>  void amd_pmf_populate_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in);
>  void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in);
> +int amd_pmf_invoke_cmd_enact(struct amd_pmf_dev *dev);
>  
>  #endif /* PMF_H */
> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
> index 679c5bf5faca..249683509635 100644
> --- a/drivers/platform/x86/amd/pmf/tee-if.c
> +++ b/drivers/platform/x86/amd/pmf/tee-if.c
> @@ -223,7 +223,7 @@ static void amd_pmf_apply_policies(struct amd_pmf_dev *dev, struct ta_pmf_enact_
>  	}
>  }
>  
> -static int amd_pmf_invoke_cmd_enact(struct amd_pmf_dev *dev)
> +int amd_pmf_invoke_cmd_enact(struct amd_pmf_dev *dev)
>  {
>  	struct ta_pmf_shared_memory *ta_sm = NULL;
>  	struct ta_pmf_enact_result *out = NULL;
> @@ -559,6 +559,7 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev)
>  		switch (ret) {
>  		case TA_PMF_TYPE_SUCCESS:
>  			status = true;
> +			dev->cb_flag = true;
>  			break;
>  		case TA_ERROR_CRYPTO_INVALID_PARAM:
>  		case TA_ERROR_CRYPTO_BIN_TOO_LARGE:
> 

-- 
 i.